apt/methods/store.cc, branch 2.9.27Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.9.272025-01-05T22:16:08ZDrop usage of macro APT_OVERRIDE for simple override2025-01-05T22:16:08ZDavid Kalnischkiesdavid@kalnischkies.de2024-12-26T19:41:53Zurn:sha1:f73593a4034d9eec0ec4466b8e173d4a4daece1f
We were rather inconsistent in using it and as our public headers
contain deduction guides (a c++17 feature) it seems silly to try to hide
a c++11 feature in a macro, so lets stop this charade and drop the
macro and while we are changing all these lines lets apply [[nodiscard]]
(another c++17 feature) and other suggestions from clang-tidy and
formatting for a little more consistency.
Tag hidden acquire classes as final for devirtualization2024-11-22T12:13:25ZDavid Kalnischkiesdavid@kalnischkies.de2024-11-19T22:42:44Zurn:sha1:8c760266c8c736bff62055c008ab74d78f3ed82a
gcc reports `warning: Declaring type ‘class X’ final would
enable devirtualization of Y calls [-Wsuggest-final-types]`.
Not that this would massively improve performance, but it
shouldn't hurt telling the compiler what is obvious for a human.
Turn char[APT_BUFFER_SIZE] buffers into std::array<char, APT_BUFFER_SIZE>2024-11-11T14:52:43Zнабnabijaczleweli@nabijaczleweli.xyz2024-11-11T14:23:46Zurn:sha1:e59793e29ecb47c63b72de4f9d1e6d044a0ff6f2Modernize standard library includes2024-02-20T12:49:04ZJulian Andres Klodejulian.klode@canonical.com2024-02-20T12:43:08Zurn:sha1:40a75722c43ae24cb9a99d6730a3b25b65819c49
This was automated with sed and git-clang-format, and then I had to
fix up the top of policy.cc by hand as git-clang-format accidentally
indented it by two spaces.
methods: store: Use APT_BUFFER_SIZE (64k) instead of 4k buffers2023-08-30T13:05:34ZJulian Andres Klodejulian.klode@canonical.com2023-08-30T13:05:34Zurn:sha1:52dd18670bf7d22ecf234141d3c7b7b9f67c6fa3Implement encoded URI handling in all methods2020-12-18T18:31:19ZDavid Kalnischkiesdavid@kalnischkies.de2020-07-09T22:02:25Zurn:sha1:97d6c3b2d05fe0d965657197adf56cc78f9edf81
Every method opts in to getting the encoded URI passed along while
keeping compat in case we are operated by an older acquire system.
Effectively this is just a change for the http-based methods as the
others just decode the URI as they work with files directly.
apt-pkg: URI: Add 'explicit' to single argument constructor2019-04-30T15:43:56ZJulian Andres Klodejulian.klode@canonical.com2019-04-30T10:32:54Zurn:sha1:af74a9e2d55d6a9532eb3fbb9b96c65b7ddc1e4d
This needs a fair amount of changes elsewhere in the code,
hence this is separate from the previous commits.
Sandbox methods with seccomp-BPF; except cdrom, gpgv, rsh2017-10-22T21:38:31ZJulian Andres Klodejak@debian.org2017-10-22T21:34:03Zurn:sha1:32bcbd73e0988d2d2237690ffae33b4f5cc5ff81
This reduces the number of syscalls to about 140 from about
350 or so, significantly reducing security risks.
Also change prepare-release to ignore the architecture lists
in the build dependencies when generating the build-depends
package for travis.
We might want to clean up things a bit more and/or move it
somewhere else.
Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
implement generic config fallback for methods2016-08-10T21:19:44ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-31T16:05:56Zurn:sha1:30060442025824c491f58887ca7369f3c572fa57
The https method implemented for a long while now a hardcoded fallback
to the same options in http, which, while it works, is rather inflexible
if we want to allow the methods to use another name to change their
behavior slightly, like apt-transport-tor does to https – most of the
diff being s#https#tor#g which then fails to do the full circle
fallthrough tor -> https -> http for https sources. With this config
infrastructure this could be implemented now.