apt/methods, branch 1.1.exp1Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.1.exp12014-05-09T11:06:27Zreenable pipelining via hashsum reordering support2014-05-09T11:06:27ZDavid Kalnischkiesdavid@kalnischkies.de2014-04-28T08:02:27Zurn:sha1:895417ef99bb1371d8970da1afe87c6d64382f67
Now that methods have the expected hashes available they can check if
the response from the server is what they expected. Pipelining is one of
those areas in which servers can mess up by not supporting it properly,
which forced us to disable it for the time being. Now, we check if
we got a response out of order, which we can not only use to disable
pipelining automatically for the next requests, but we can fix it up
just like the server responded in proper order for the current requests.
To ensure that this little trick works pipelining is only attempt if we
have hashsums for all the files in the chain which in theory reduces the
use of pipelining usage even on the many servers which work properly,
but in practice only the InRelease file (or similar such) will be
requested without a hashsum – and as it is the only file requested in
that stage it can't be pipelined even if we wanted to.
Some minor annoyances remain: The display of the progress we have
doesn't reflect this change, so it looks like the same package gets
downloaded multiple times while others aren't at all. Further more,
partial files are not supported in this recovery as the received data
was appended to the wrong file, so the hashsum doesn't match.
Both seem to be minor enough to reenable pipelining by default until
further notice through to test if it really solves the problem.
This therefore reverts commit 8221431757c775ee875a061b184b5f6f2330f928.
enforce LFS for partial files in https range requests2014-04-26T07:51:05ZDavid Kalnischkiesdavid@kalnischkies.de2014-04-24T08:49:41Zurn:sha1:062074cb519aa05110d24936d95747c59cc0ffc1build http request in a stringstream2014-04-26T07:51:05ZDavid Kalnischkiesdavid@kalnischkies.de2014-04-24T08:20:45Zurn:sha1:b123b0ba77936a82d7964bebf01693acf94cae1f
beside reducing code a bit, it avoids oddball problems while building
the string and doesn't trigger static analyse warnings.
add a config option to switch uncompress methods to compress2014-03-13T12:58:47ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-12T13:24:41Zurn:sha1:0ec6b98b24939100a6d4c333abe5bc62a4455f9f
Not very useful in the normal operation of work, but handy for tests.
Git-Dch: Ignore
follow method attribute suggestions by gcc2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T23:33:10Zurn:sha1:a02db58fd50ef7fc2f0284852c6b3f98e458a232
Git-Dch: Ignore
Reported-By: gcc -Wsuggest-attribute={pure,const,noreturn}
cleanup headers and especially #includes everywhere2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T21:11:25Zurn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
warning: unused parameter ‘foo’ [-Wunused-parameter]2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-01T14:11:42Zurn:sha1:655122418d714f342b5d9789f45f8035f3fe8b9a
Reported-By: gcc -Wunused-parameter
Git-Dch: Ignore
StartPos is always positive for http/https2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-02-27T00:26:29Zurn:sha1:3de8f956d5fcf023ab65f88579cd77121694d872
server.cc: In member function ‘bool ServerState::HeaderLine(std::string)’:
server.cc:198:72: warning: format ‘%llu’ expects argument of type ‘long long unsigned int*’, but argument 3 has type ‘long long int*’ [-Wformat=]
else if (sscanf(Val.c_str(),"bytes %llu-%*u/%llu",&StartPos,&Size) != 2)
Git-Dch: Ignore
Reported-By: gcc -Wpedantic
warning: extra ‘;’ [-Wpedantic]2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-02-27T00:20:53Zurn:sha1:d3e8fbb395f57954acd7a2095f02ce530a05ec6a
Git-Dch: Ignore
Reported-By: gcc -Wpedantic
fix -Wformat= warnings about size_t != %lu on e.g. armel2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-02-25T21:30:39Zurn:sha1:6298ff8b6492e2071a8f2ca7669a3aeef0fb29c7
Git-Dch: Ignore
Reported-By: gcc