apt/methods, branch 1.9.2

Fix typos reported by codespell in code comments

2019-07-10T14:15:30Z

Also in old changelogs, but nothing really user visible like error messages or alike so barely noteworthy. Reported-By: codespell Gbp-Dch: Ignore

Apply various suggestions by cppcheck

2019-07-08T13:51:17Z

Reported-By: cppcheck

RFC1123StrToTime: Accept const std::string& as first argument

2019-06-17T16:28:52Z

We are converting to std::string anyway by passing to istringstream, and this removes the need for .c_str() in callers.

http: Fix Host header in proxied https connections

2019-06-11T15:27:34Z

Currently CONNECT requests use the name of the proxy as Host value, instead of the origin server's name. According to RFC 2616 "The Host field value MUST represent the naming authority of the origin server or gateway given by the original URL." The current implementation causes problems with some proxy vendors. This commit fixes this. [jak: Adding a test case] See merge request apt-team/apt!66

Merge tag '1.8.2'

2019-06-11T12:16:18Z

apt Debian release 1.8.2

methods: https: handle requests for TLS re-handshake

2019-05-21T12:53:01Z

When accessing repository protected by TLS mutual auth, apt may receive a "re-handshake" request from the server, which must be handled in order for download to proceed. This situation arises when the server requests a client certificate based on the resource path provided in the GET request, after the inital handshake in UnwrapTLS() has already occurred, and a secure connection has been established. This issue has been observed with Artifactory-backed Debian repository. To address the issue, split TLS handshake code out into its own method in TlsFd, and call it when GNUTLS_E_REHANDSHAKE error is received. Signed-off-by: Michael Zhivich (merged from Debian/apt#93) LP: #1829861

apt-pkg: URI: Add 'explicit' to single argument constructor

2019-04-30T15:43:56Z

This needs a fair amount of changes elsewhere in the code, hence this is separate from the previous commits.

Add 'explicit' to most single argument constructors

2019-04-30T15:43:31Z

This prevents implicit conversions that we do not want, such as having a FileFd* being converted to a debListParser. Two cases are not yet handled because they require changes in code using them: 1. The classes in hashes.h 2. The URI class - this one is used quite a lot

Fix new gcc-9 warning -Wpessimizing-move

2019-04-16T10:59:54Z

warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] Reported-By: gcc-9 Gbp-Dch: Ignore

aptmethod.h: Do not have gcc warning about ignoring write() result

2019-02-05T11:50:05Z

This is a special case here, a best effort write, so there's no point in having warnings about it for every method.