apt/methods, branch 2.9.18

methods/gpgv: Remove apt-key mentions

2024-12-07T14:14:34Z

Detect working gpgv using gpgv --dump-options

2024-11-28T18:01:36Z

This gains us support for not using an absolute path, which is nice, and we can now cache the invocation across fork() in the method. Still keep preferring absolute paths, this avoids execvp() having to iterate the path and reduces bug potential with custom gpgv in /usr/local. Fix the last entry in the list of gpgvs to say gpgv1

Do not implode key file name vector for calling gpgv

2024-11-28T09:17:21Z

Converting it to a comma-separated string and back loses precision.

Merge branch 'fix/partialfilemirror' into 'main'

2024-11-22T16:12:34Z

Support uncompressed indexes from partial file:/ mirrors See merge request apt-team/apt!235

Look at non by-hash paths in copy and file methods

2024-11-22T12:40:10Z

Ideally copy and file mirrors would support by-hash as well, but its harder to setup and maintain especially if you want to cache an online mirror who has by-hash enabled. We can avoid unneeded roundtrips (in the best case) and entire cache misses (in the usual worst case) by "just" telling methods that the URI we passed it has the requested file perhaps also in other paths. This is done in pseudo-relative paths as we would otherwise need to teach redirection code to rewrite those URIs as well. A method like http can easily ignore this value and await explicit instructions to look at that file, but inspecting the path in local sources via file or copy is (comparatively) free, so we just do it immediately. If that ends up being the wrong version of the file as by-hash would have protected us from we are in this feature branch now falling back to other mirrors which are like the ones online and in support of by-hash.

Do not assume mirror-URIs end in a filename causing a hang

2024-11-22T12:40:10Z

In practice most of them will, but making the acquire process hang in response if they don't seems like an overly excessive response if we can just support it gracefully to reply with an error (or actually succeed in the unlikely event this URI is actually correct).

Alternatively calculate alternative file hashes in file method

2024-11-22T12:21:24Z

If we do not have the requested file we haven't calculated the hashes for it either and it is likely that the alternative file will be used, so to save the main thread from being busy with calculating hashes we do the calculation here in the method.

Tag hidden acquire classes as final for devirtualization

2024-11-22T12:13:25Z

gcc reports `warning: Declaring type ‘class X’ final would enable devirtualization of Y calls [-Wsuggest-final-types]`. Not that this would massively improve performance, but it shouldn't hurt telling the compiler what is obvious for a human.

http: use Retry-After HTTP header to optimize retries

2024-11-18T12:44:49Z

Some mirrors like snapshot.debian.org apply strict http rate limits. While apt already has an exponential backoff mechanism implemented, this is not sufficient due to the following reasons: 1. all retries happen roughly at the same time 2. the retry-after information from the server is not used We fix this by improving the algorithm: First, if present, the timestamp or duration of the Retry-After header is added to the exponential backoff, optimizing for success-on-second-try. Second, a random delay is added (delay += [0, delay]) to distribute the retries to not immediately run into the limit again. To avoid super-long delays, this is capped by the configured maximum delay. This logic only becomes active if the option Acquire::Retries::HandleRetryAfter is enabled. Signed-off-by: Felix Moessbauer

methods/http.cc: APT::StringView -> std::string_view

2024-11-12T19:36:20Z