Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.1_exp14 2015-08-12T09:55:47Z 2015-08-12T09:55:47Z Luca Bruno lethalman88@gmail.com 2015-08-11T18:08:43Z urn:sha1:94171725b18be91ddcc2530c5fe5f40e78d041c1 Thanks: Andre Felipe Machado for initial patch Closes: 414848 2015-06-15T21:35:55Z David Kalnischkies david@kalnischkies.de 2015-06-15T14:41:43Z urn:sha1:1eb1836f4b5397497bd34f0cf516e6e4e73117bf Again, consistency is the main sellingpoint here, but this way it is now also easier to explain that some files move through different stages and lines are printed for them hence multiple times: That is a bit hard to believe if the number is changing all the time, but now that it keeps consistent. 2015-06-15T21:35:54Z David Kalnischkies david@kalnischkies.de 2015-06-15T11:36:11Z urn:sha1:ff86d7df6a53ff6283de4b9a858c1dad98ed887f All other methods call it, so they should follow along even if the work they do afterwards is hardly breathtaking and usually results in a URIDone pretty soon, but the acquire system tells the individual item about this via a virtual method call, so even through none of our existing items contains any critical code in these, maybe one day they might. Consistency at least once… Which is also why this has a good sideeffect: file: and cdrom: requests appear now in the 'apt-get update' output. Finally - it never made sense to hide them for me. Okay, I guess it made before the new hit behavior, but now that you can actually see the difference in an update it makes sense to see if a file: repository changed or not as well. 2015-04-18T23:13:09Z David Kalnischkies david@kalnischkies.de 2015-04-11T18:13:19Z urn:sha1:d84da4995df24329e96d57a22136683a9e370f4e Its a bit unpredictable which permissons and owners we will encounter on a CD-ROM (or a USB stick, as apt-cdrom is responsible for those too), so we have to ensure in this codepath as well that everything is nicely setup without waiting for a 'apt-get update' to fix up the (potential) mess. 2015-03-16T17:01:54Z David Kalnischkies david@kalnischkies.de 2015-03-09T23:59:44Z urn:sha1:25b86db159fbc3c043628e285c0c1ef24dec2c6e We use test{success,failure} now all over the place in the framework, so its only consequencial to do this in the situations in which we test for a specific output as well. Git-Dch: Ignore 2014-11-18T01:41:20Z David Kalnischkies david@kalnischkies.de 2014-11-17T21:54:29Z urn:sha1:4bb006d1ddcf1807474067dcbef9fb0bb5def0ac While on linux files are created in /tmp with $USER:$USER, on my kfreebsd testmachine they are created with $USER:root, so we pull some strings here to make it work on both. 2014-11-18T01:41:20Z David Kalnischkies david@kalnischkies.de 2014-11-14T17:01:09Z urn:sha1:8fe964f148344b8a55252fe52b6292a4ab86ea98 We autocreate for a while now the last two directories in /var/lib/apt/lists (similar for /var/cache/apt/archives) which is very nice for systems having any of those on tmpfs or other non-persistent storage. This also means though that this creation is effected by the default umask, so for people with aggressive umasks like 027 the directories will be created with 750, which means all non-root users are left out, which is usually exactly what we want then this umask is set, but the cache and lib directories contain public knowledge. There isn't any need to protect them from viewers and they render apt completely useless if not readable. 2014-10-23T14:54:27Z David Kalnischkies david@kalnischkies.de 2014-10-23T08:42:18Z urn:sha1:b0314abb0cbe5937d2d3cdcd6df9d322b69d03a0 Git-Dch: Ignore 2014-10-22T23:28:05Z David Kalnischkies david@kalnischkies.de 2014-10-22T23:28:05Z urn:sha1:03aa08472dcd689572a46ce6efdb1dccf6136334 partial files are chowned by the Item baseclass to let the methods work with them. Now, this baseclass is also responsible for chowning the files back to root instead of having various deeper levels do this. The consequence is that all overloaded Failed() methods now call the Item::Failed base as their first step. The same is done for Done(). The effect is that even in partial files usually don't belong to _apt anymore, helping sneakernets and reducing possibilities of a bad method modifying files not belonging to them. The change is supported by the framework not only supporting being run as root, but with proper permission management, too, so that privilege dropping can be tested with them. 2014-10-15T16:32:14Z David Kalnischkies david@kalnischkies.de 2014-10-15T16:32:14Z urn:sha1:0977f81757f42889a9edb761061529041afe0a06 The acquire code changed completely, so this is more an import of the testcase and a new fix than the merge of an existent fix. Conflicts: apt-pkg/acquire-item.cc