Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=main 2021-09-13T14:08:52Z 2021-09-13T14:08:52Z David Kalnischkies david@kalnischkies.de 2021-09-12T14:08:52Z urn:sha1:2b0369a5d1673d9e40f2af4db7677b040a26ee58 We allow file (and other file-based methods) URIs to either be given as file:///path or as file:/path, but in various places of the acquire system we perform string comparisons on URIs which do not handle this expecting the canonical representation produced by our URI code. That used to be hidden by us quoting and dequoting the URIs in the system, but as we don't do this anymore we have to be a bit more careful on input. Ideally we would do less of these comparisons, but for now lets be content with inserting a canonicalisation early on to prevent hangs in the acquire system. 2021-06-04T14:43:41Z David Kalnischkies david@kalnischkies.de 2021-06-04T11:06:34Z urn:sha1:149b23c2b9697bc262c0af1934c7a3f6114d903f Keeping URIs encoded in the acquire system depends on having them encoded in the first place. While many other places got the encoding 2 out of 3 ArchiveURI implementations were missed which are in practice responsible for nearly all of the URI building, just that index filename do not contain characters to escape and the Filename fields in Packages files usually aren't. Usually. Except if you happen to have e.g. an epoch featuring package with the colon encoded in the filename. On the upside, in most repositories the epoch isn't part of the filename. Reported-By: Johannes 'josch' Schauer on IRC References: e6c55283d235aa9404395d30f2db891f36995c49 2015-12-19T22:04:34Z David Kalnischkies david@kalnischkies.de 2015-12-15T16:20:26Z urn:sha1:3abb6a6a1e485b3bc899b64b0a1b7dc2db25a9c2 This doesn't allow all tests to run cleanly, but it at least allows to write tests which could run successfully in such environments. Git-Dch: Ignore 2015-08-17T16:37:18Z Julian Andres Klode jak@debian.org 2015-08-17T16:37:09Z urn:sha1:e7ebb41440cbe298b07c7fb7c6b20a64a17200f0 Gbp-Dch: ignore 2014-02-14T18:10:47Z Michael Vogt mvo@debian.org 2014-02-14T16:32:42Z urn:sha1:3f621056f7f672988c0efc6d38935c22b5ae041f 2013-09-20T11:34:22Z David Kalnischkies kalnischkies@gmail.com 2013-09-20T11:34:22Z urn:sha1:5985c230c8ac85fe2b2eb504b798377843bdc7cd The Eof check was added (by me of course) in 0aae6d14390193e25ab6d0fd49295bd7b131954f as part of a fix up ~a month ago (at DebConf). The idea was not that bad, but doesn't make that much sense either as this bit is set by the FileFd based on Actual as well, so this is basically doing the same check again – with the difference that the HitEof bit can still linger from a previous Read we did at the end of the file, but have seek'd away from it now. Combined with the length of entries, entry order and other not that easily controllable conditions you can be 'lucky' enough to hit this problem in a way which even visible (truncating of other fields might not be visible easily, like 'Tags' and others). Closes: 723705 Thanks: Cyril Brulebois