Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.2.1 2020-12-18T19:45:35Z 2020-12-18T19:45:35Z David Kalnischkies david@kalnischkies.de 2020-07-10T18:19:31Z urn:sha1:a5859bafdaa6bcf12934d0fb1715a5940965e13a This commit potentially breaks code feeding apt an encoded URI using a method which does not get URIs send encoded. The webserverconfig requests in our tests are an example for this – but they only worked before if the server was expecting a double encoding as that was what was happening to an encoded URI: so unlikely to work as expected in practice. Now with the new methods we can drop this double encoding and rely on the URI being passed properly (and without modification) between the layers so that passing in encoded URIs should now work correctly. 2020-12-18T18:02:05Z David Kalnischkies david@kalnischkies.de 2020-07-08T15:51:40Z urn:sha1:97be873d782c5e9aaa8b4f4f4e6e18805d0fa51c Our http method encodes the URI again which results in the double encoding we have unwrap in the webserver (we did already, but we skip the filename handling now which does the first decode). 2020-08-04T10:12:10Z Julian Andres Klode julian.klode@canonical.com 2020-07-14T14:06:44Z urn:sha1:264137c679fb0d3c1f476dcb4ae207abc601b0b2 Apologies. 2019-06-17T16:28:52Z Julian Andres Klode julian.klode@canonical.com 2019-06-17T16:28:52Z urn:sha1:97553e635d2265ec4aad96b00b1fd72d98437f15 We are converting to std::string anyway by passing to istringstream, and this removes the need for .c_str() in callers. 2019-02-10T12:16:27Z Jakub Wilk jwilk@jwilk.net 2019-02-10T11:51:30Z urn:sha1:9a702b150c8ddeafa8c10c9f120dafdeb08ef93b 2018-11-25T16:22:53Z David Kalnischkies david@kalnischkies.de 2018-11-25T15:44:03Z urn:sha1:b38060dba0273f1981caba4502eb1ffc9f8fac0e The filename can be overridden, but sometimes it is useful to do it only for the directory-part of the filename – e.g. if you want to let a flat archive directory (like /var/cache/apt/archives) serve a pool-based request like /pool/a/apt_version.deb. Gbp-Dch: Ignore 2018-11-25T16:22:35Z David Kalnischkies david@kalnischkies.de 2018-10-10T10:38:19Z urn:sha1:85399d2b28ba0bbd3b66e1ab50fde43a9f301f68 We sometimes autogenerate HTML pages e.g. for listing files in a directory or for various error codes. If this would be a serious webserver this would be a security problem (althrough a bit hard to exploit), but as it is not shipped and intended to be used by our testcases only the world hasn't ended & we can ignore it for changelog and fix it for brownie points. Gbp-Dch: Ignore 2018-11-25T16:22:25Z David Kalnischkies david@kalnischkies.de 2018-09-18T14:09:03Z urn:sha1:62fd535c5f77cea773652fa2f371025c4fd1f32c Browsing pages served via aptwebserver is working better if we tell the browser the Content-Type which for this simple usecase we can just do by guessing based on the file extension – and because hardcoding a list would be boring we just reuse the mime.types data from mime-support if available and allow it to be overridden by files and config. Gbp-Dch: Ignore 2018-08-19T15:25:26Z David Kalnischkies david@kalnischkies.de 2018-07-09T14:12:31Z urn:sha1:d298701bd765357905705aa133c3fdb2d1a4835c If multiple threads act on requests (like if connection comes from a webbrowser) a thread might request the supported compressors while another thread is still working on creating the list to be stored in the static cache variable. As the price to pay for atomic and co seems to high for the fringe usecase of manual usage of aptwebserver the patch just makes a call to generate the list while still single threaded. Gbp-Dch: Ignore 2017-12-13T22:56:29Z David Kalnischkies david@kalnischkies.de 2017-10-25T23:09:48Z urn:sha1:dff555d40bb9776b5b809e06527e46b15e78736c Moving the Retry-implementation from individual items to the worker implementation not only gives every file retry capability instead of just a selected few but also avoids needing to implement it in each item (incorrectly).