apt/test/interactive-helper/aptwebserver.cc, branch 2.9.1

Modernize standard library includes

2024-02-20T12:49:04Z

This was automated with sed and git-clang-format, and then I had to fix up the top of policy.cc by hand as git-clang-format accidentally indented it by two spaces.

Fix build failure with gcc-12 due to missing include

2022-03-21T01:57:24Z

apt/test/interactive-helper/aptwebserver.cc: In function ‘std::string HTMLEncode(std::string)’: error: variable ‘constexpr const std::array, 6> htmlencode’ has initializer but incomplete type Reported-By: Helmut Grohne on IRC

Use exact If-Range match in our test webserver

2021-09-16T20:40:05Z

RFC7233 3.2 If-Range specifies the comparison to be an exact match, not a less or equal, which makes no sense in this context anyhow. Our server exists only to write our tests against it so this isn't much of a practical issue. I did confirm with a crashing server that no test (silently) depends on this or exhibits a different behaviour not explicitly checked for.

Don't re-encode encoded URIs in pkgAcqFile

2020-12-18T19:45:35Z

This commit potentially breaks code feeding apt an encoded URI using a method which does not get URIs send encoded. The webserverconfig requests in our tests are an example for this – but they only worked before if the server was expecting a double encoding as that was what was happening to an encoded URI: so unlikely to work as expected in practice. Now with the new methods we can drop this double encoding and rely on the URI being passed properly (and without modification) between the layers so that passing in encoded URIs should now work correctly.

Proper URI encoding for config requests to our test webserver

2020-12-18T18:02:05Z

Our http method encodes the URI again which results in the double encoding we have unwrap in the webserver (we did already, but we skip the filename handling now which does the first decode).

aptwebserver: Rename slaves to workers

2020-08-04T10:12:10Z

Apologies.

RFC1123StrToTime: Accept const std::string& as first argument

2019-06-17T16:28:52Z

We are converting to std::string anyway by passing to istringstream, and this removes the need for .c_str() in callers.

Fix various typos in the documentation

2019-02-10T12:16:27Z

Allow to override the directory of a request in aptwebserver

2018-11-25T16:22:53Z

The filename can be overridden, but sometimes it is useful to do it only for the directory-part of the filename – e.g. if you want to let a flat archive directory (like /var/cache/apt/archives) serve a pool-based request like /pool/a/apt_version.deb. Gbp-Dch: Ignore

aptwebserver: Prevent XSS in debug and file listing

2018-11-25T16:22:35Z

We sometimes autogenerate HTML pages e.g. for listing files in a directory or for various error codes. If this would be a serious webserver this would be a security problem (althrough a bit hard to exploit), but as it is not shipped and intended to be used by our testcases only the world hasn't ended & we can ignore it for changelog and fix it for brownie points. Gbp-Dch: Ignore