apt/test/libapt/acqprogress_test.cc, branch 2.7.11Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.7.112017-07-12T11:57:51ZReformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
apply various suggestions made by cppcheck2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T20:08:55Zurn:sha1:258b9e512c4001e806c5c0966acecd3d742ec6e9
Reported-By: cppcheck
Git-Dch: Ignore
add c++11 override marker to overridden methods2015-08-10T15:27:17ZDavid Kalnischkiesdavid@kalnischkies.de2015-07-08T22:35:40Zurn:sha1:3b3028467ceccca0b73a8f53051c0fa4de313111
C++11 adds the 'override' specifier to mark that a method is overriding
a base class method and error out if not. We hide it in the APT_OVERRIDE
macro to ensure that we keep compiling in pre-c++11 standards.
Reported-By: clang-modernize -add-override -override-macros
Git-Dch: Ignore
add d-pointer, virtual destructors and de-inline de/constructors2015-06-16T14:22:46ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-16T14:22:46Zurn:sha1:c8a4ce6cbed57ae108dc955d4a850f9b129a0693
To have a chance to keep the ABI for a while we need all three to team
up. One of them missing and we might loose, so ensuring that they are
available is a very tedious but needed task once in a while.
Git-Dch: Ignore
rework hashsum verification in the acquire system2015-06-09T10:57:35ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-06T10:28:00Zurn:sha1:448c38bdcd72b52f11ec5f326f822cf57653f81c
Having every item having its own code to verify the file(s) it handles
is an errorprune process and easy to break, especially if items move
through various stages (download, uncompress, patching, …). With a giant
rework we centralize (most of) the verification to have a better
enforcement rate and (hopefully) less chance for bugs, but it breaks the
ABI bigtime in exchange – and as we break it anyway, it is broken even
harder.
It shouldn't effect most frontends as they don't deal with the acquire
system at all or implement their own items, but some do and will need to
be patched (might be an opportunity to use apt on-board material).
The theory is simple: Items implement methods to decide if hashes need to
be checked (in this stage) and to return the expected hashes for this
item (in this stage). The verification itself is done in worker message
passing which has the benefit that a hashsum error is now a proper error
for the acquire system rather than a Done() which is later revised to a
Failed().
add a simple unit test for acquire progress2015-04-10T20:29:08ZDavid Kalnischkiesdavid@kalnischkies.de2015-03-15T21:34:54Zurn:sha1:dfad5beea77d75983f6ff8a1b8296b74dd48203e
This isn't testing much of the 'complex' parts,
but its better than nothing for now.
Git-Dch: Ignore