apt/test/libapt/fileutl_test.cc, branch 1.1.9Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.1.92015-12-19T11:51:10ZFix FileUtlTest.GetTempDir failure when run as root2015-12-19T11:51:10ZPino Toscanopino@debian.org2015-12-19T11:09:18Zurn:sha1:dbbe1e6393dab381db0f48b2a645babdddb14eca
Testing /usr as TMPDIR assumes that GetTempDir() cannot use it
because it cannot write to it; this is true for non-root users, but
not so much for root.
Since root can access everything, perform this particular test case
only when not running as root.
Closes: #808383
ensure FileFd doesn't try to open /dev/null as atomic and co2015-11-04T17:42:28ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-02T15:02:44Zurn:sha1:cd46d4ebd33e74ee53bbc73dcdb7fe1d4d006558
The wrapping will fail in the best case and actually end up deleting
/dev/null in the worst case. Given that there is no point in trying to
write atomically to /dev/null as you can't read from it again just
ignore these flags if higher level code ends up trying to use them on
/dev/null.
Git-Dch: Ignore
fileutl_test.cc: Check for /etc/passwd instead of /bin/sh2015-08-10T09:43:23ZJulian Andres Klodejak@debian.org2015-08-10T09:42:34Zurn:sha1:20cf708a62df5e4aa45a506819db425c6cc975fe
This fixes the tests on systems where usrmerge is installed.
Gbp-dch: ignore
(style) Variable 'res' is assigned a value that is never used2014-11-08T13:26:00ZDavid Kalnischkiesdavid@kalnischkies.de2014-11-05T17:56:12Zurn:sha1:23fb7b2cbbda62c99a199d29ad62205b23d35af4
Checking the return value of this (and many other calls) in this
testcase is a good idea, so we do it now.
Reported-By: cppcheck
Git-Dch: Ignore
Division by result of sizeof(). memset() expects a size in bytes2014-11-08T13:26:00ZDavid Kalnischkiesdavid@kalnischkies.de2014-11-05T17:42:56Zurn:sha1:ad5ffe1ffb203eb58e5e25fe6f4c0dabc53253c9
"did you intend to multiply instead?" is what cppcheck helpful says and
it is absolutely right. Doesn't make a whole lot of a difference though
as we are talking about 'char' in this testcase, but just to be sure.
Reported-By: cppcheck
Git-Dch: Ignore
test if TMPDIR is accessible before using2014-10-20T12:42:47ZDavid Kalnischkiesdavid@kalnischkies.de2014-10-20T10:00:46Zurn:sha1:0d303f1764645284b33924c9be8bf29f0a32ca5c
Private temporary directories as created by e.g. libpam-tmpdir are nice,
but they are also very effective in preventing our priviledge dropping
to work as TMPDIR will be set to a directory only root has access to, so
working with it as _apt will fail. We circumvent this by extending our
check for a usable TMPDIR setting by checking access rights.
Closes: 765951
Merge branch 'feature/abspath' into feature/apt-install-deb2014-04-28T15:45:07ZMichael Vogtmvo@ubuntu.com2014-04-28T15:45:07Zurn:sha1:713ee8ad3f4d7be00d2fbacd979e78772f24a675fix tests2014-04-28T15:44:34ZMichael Vogtmvo@ubuntu.com2014-04-28T15:44:34Zurn:sha1:a111a024a30b805fc3f2b8a5b4db8d0c26c10fb8Merge branch 'feature/abspath' into feature/apt-install-deb2014-04-28T15:25:28ZMichael Vogtmvo@ubuntu.com2014-04-28T15:25:28Zurn:sha1:8e0002ac420707b94a8a43dfedea7fc182dd5851
Conflicts:
test/libapt/fileutl_test.cc
add flAbsPath() as a wrapper to realpath()2014-04-28T15:24:35ZMichael Vogtmvo@ubuntu.com2014-04-28T15:24:35Zurn:sha1:53ac87ac9c27af39df062516aab5dce880af107a