Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.7.0_alpha0 2017-12-13T22:56:29Z 2017-12-13T22:56:29Z David Kalnischkies david@kalnischkies.de 2017-07-17T08:52:09Z urn:sha1:07cd99066c30e70a9f41851c80e7c51f4e507163 LookupTag is a little helper to deal with rfc822-style strings we use in apt e.g. to pass acquire messages around for cases in which our usual rfc822 parser is too heavy. All the fields it had to deal with so far were single line, but if they aren't it should really produce the right output and not just return the first line. Error messages are a prime candidate for becoming multiline as at the moment they are stripped of potential newlines due to the previous insufficiency of LookupTag. 2017-07-12T11:57:51Z Julian Andres Klode jak@debian.org 2017-07-12T11:40:41Z urn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3 This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh. 2016-09-01T14:13:32Z David Kalnischkies david@kalnischkies.de 2016-09-01T06:49:22Z urn:sha1:d8a57c1953b876917a9deb098d1ef3d2b093f3dc Gbp-Dch: Ignore Reported-By: gcc -Wmissing-declarations 2016-06-17T16:09:20Z David Kalnischkies david@kalnischkies.de 2016-06-17T15:56:45Z urn:sha1:1d742e01470bba27715a8191c50adde4b39c2f19 As reported upstream in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71556 the implementation of std::get_time is currently not as accepting as strptime is, especially in how hours should be formatted. Just reverting 9febc2b238e1e322dce1f94ecbed46d595893b52 would be possible, but then we would reopen the problems fixed by it, so instead I opted here for a rewrite of the parsing logic which makes this method a lot longer, but at least it provides the same benefits as the rewrite in std::get_time was intended to give us and decouples us from the fix of the issue in the standard library implementation of GCC. LP: 1593583 2016-05-28T09:42:20Z David Kalnischkies david@kalnischkies.de 2016-05-28T09:03:35Z urn:sha1:9febc2b238e1e322dce1f94ecbed46d595893b52 HTTP/1.1 hardcodes GMT (RFC 7231 §7.1.1.1) and what is good enough for the internet must be good enough for us™ as we reuse the implementation internally to parse (most) dates we encounter in various places like the Release files with their Date and Valid-Until header fields. Implementing a fully timezone aware parser just feels too hard for no effective benefit as it would take 5+ years (= until LTS's are out of fashion) until a repository could use non-UTC dates and expect it to work. Not counting non-apt implementations which might or might not only want to encounter UTC here as well. As a bonus, this eliminates the use of an instance of setlocale in libapt. Closes: 819697 2015-11-05T11:21:33Z David Kalnischkies david@kalnischkies.de 2015-11-04T22:38:40Z urn:sha1:4453cfdcf42f7fe6859bb0fc6b310a2a391bee77 Limit the field length to a char to avoid bogus FF for utf-8 characters with the default length. Closes: 799123 2015-04-10T18:18:17Z David Kalnischkies david@kalnischkies.de 2015-03-10T13:11:54Z urn:sha1:b8eba208daebe3e3f235983e44da9c398d6f7a57 Working with strings c-style is complicated and error-prune, so by converting to c++ style we gain some simplicity and avoid buffer overflows by later extensions. Git-Dch: Ignore 2014-10-26T13:13:34Z David Kalnischkies david@kalnischkies.de 2014-10-24T21:55:15Z urn:sha1:d8c71b3b5dc98daa247433503ad8242c9e7b77db Central methods of our infrastructure like this one responsible for communication with our methods shouldn't be more complicated then they have to and not claim to have (albeit unlikely) bugs. While I am not sure about having improved the first part, the bug is now gone and a few explicit tests check that it stays that way, so nobody will notice the difference (hopefully) – expect that this should a very tiny bit faster as well as we don't manually proceed through the string. Git-Dch: Ignore 2014-10-23T14:54:27Z David Kalnischkies david@kalnischkies.de 2014-10-23T08:42:18Z urn:sha1:b0314abb0cbe5937d2d3cdcd6df9d322b69d03a0 Git-Dch: Ignore 2014-09-23T12:20:27Z Michael Vogt mvo@ubuntu.com 2014-09-23T12:20:27Z urn:sha1:c511c5e8ed3f59ddee1b174b39e5cc16a2f11922 Conflicts: apt-pkg/acquire-item.cc apt-pkg/acquire-item.h apt-pkg/cachefilter.h configure.ac debian/changelog