apt/test/libapt/strutil_test.cc, branch 2.9.0Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.9.02021-02-03T16:36:46ZForbid negative values in unsigned StrToNum explicitly2021-02-03T16:36:46ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-13T07:07:19Zurn:sha1:e0743a85c5f5f2f83d91c305450e8ba192194cd8
strtoul(l) surprises us with parsing negative values which should not
exist in the places we use to parse them, so we can just downright
refuse them rather than trying to work with them by having them promoted
to huge positive values.
Don't parse \x and \0 past the end in DeEscapeString2021-02-03T16:36:45ZDavid Kalnischkiesdavid@kalnischkies.de2020-12-03T09:44:27Zurn:sha1:ed192f410da36aedf5e54bb3f967e6613ab4bb51
This has no attack surface though as the loop is to end very soon anyhow
and the method only used while reading CD-ROM mountpoints which seems
like a very unlikely attack vector…
Fix incorrect base64 encoding due to int promotion2021-02-03T16:36:45ZDavid Kalnischkiesdavid@kalnischkies.de2020-12-03T09:41:43Zurn:sha1:10f13938bbf1474451fadcd62e1c31c4b5f5b3d7
For \xff and friends with the highest bit set and hence being a negative
value on signed char systems the wrong encoding is produced as we run
into undefined behaviour accessing negative array indexes.
We can avoid this problem simply by using an unsigned data type.
Add a simple test for APT::String::DisplayLength2021-02-03T16:36:45ZDavid Kalnischkiesdavid@kalnischkies.de2020-12-03T09:35:29Zurn:sha1:1b3ad3891465f8b72bcedfb4edd513cb74eec7f3
References: 2497198e9599a6a8d4d0ad08627bcfc7ea49c644
Gbp-Dch: Ignore
Allow prefix to be a complete filename for GetTempFile2020-05-18T13:55:36ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-18T09:55:54Zurn:sha1:c470d92366d7c3c239a689f0a10d6d0d9daafbff
Our testcases had their own implementation of GetTempFile with the
feature of a temporary file with a choosen suffix. Merging this into
GetTempFile lets us drop this duplicate and hence test more our code
rather than testing our helpers for test implementation.
And then hashsums_test had another implementation… and extracttar wasn't
even trying to use a real tempfile… one GetTempFile to rule them all!
That also ensures that these tempfiles are created in a temporary
directory rather than the current directory which is a nice touch and
tries a little harder to clean up those tempfiles.
Prevent GTest from flooding us with compiler warnings2018-05-04T16:42:37ZDavid Kalnischkiesdavid@kalnischkies.de2018-05-04T16:24:57Zurn:sha1:1d77c915005f7630949e2ce706055ee3235009b6
GTest has a bunch of undefined macros which causes the compiler to spit
out warnings for each one on each test file. There isn't much we can do,
so we just disable the warning for the testcases. Other warnings like
sign-promo and sign-compare we can avoid by being more explicit about
our expected integer constants being unsigned.
As we are just changing testcases, there is no user visible change which
would deserve to be noted in the changelog.
Gbp-Dch: Ignore
Reported-By: gcc-8
support multiline values in LookupTag2017-12-13T22:56:29ZDavid Kalnischkiesdavid@kalnischkies.de2017-07-17T08:52:09Zurn:sha1:07cd99066c30e70a9f41851c80e7c51f4e507163
LookupTag is a little helper to deal with rfc822-style strings we use in
apt e.g. to pass acquire messages around for cases in which our usual
rfc822 parser is too heavy. All the fields it had to deal with so far
were single line, but if they aren't it should really produce the right
output and not just return the first line. Error messages are a prime
candidate for becoming multiline as at the moment they are stripped of
potential newlines due to the previous insufficiency of LookupTag.
Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
tests: silence -Wmissing-declarations2016-09-01T14:13:32ZDavid Kalnischkiesdavid@kalnischkies.de2016-09-01T06:49:22Zurn:sha1:d8a57c1953b876917a9deb098d1ef3d2b093f3dc
Gbp-Dch: Ignore
Reported-By: gcc -Wmissing-declarations
avoid std::get_time usage to sidestep libstdc++6 bug2016-06-17T16:09:20ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-17T15:56:45Zurn:sha1:1d742e01470bba27715a8191c50adde4b39c2f19
As reported upstream in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71556
the implementation of std::get_time is currently not as accepting as
strptime is, especially in how hours should be formatted.
Just reverting 9febc2b238e1e322dce1f94ecbed46d595893b52 would be
possible, but then we would reopen the problems fixed by it, so instead
I opted here for a rewrite of the parsing logic which makes this method
a lot longer, but at least it provides the same benefits as the rewrite
in std::get_time was intended to give us and decouples us from the fix
of the issue in the standard library implementation of GCC.
LP: 1593583