Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.9.33 2025-03-12T17:54:25Z 2025-03-12T17:54:25Z Julian Andres Klode julian.klode@canonical.com 2025-03-12T17:47:55Z urn:sha1:460753f991ca42c3c4a5ed494038db76c55e2a08 Reorder the if branches a bit to simplify the understanding of the promotions, and allow us to keep track of which dependency existed in the installed version. Change the rule for promoting new recommends to only promote new recommends to depends in *upgrade* and not *dist-upgrade* per the test-resolve-by-keep-new-recommends test case. This makes some sense: In a dist-upgrade, the solver could otherwise decide to remove an installed package if both the following hold: (1) something needs the upgraded version | something else (2) the upgraded version is not installable due to unsat recommends 2025-03-12T17:52:16Z Julian Andres Klode julian.klode@canonical.com 2025-03-12T17:34:48Z urn:sha1:a4ce187b40f3bbd110a7cc35f9a5af5a8b7b0c9e We accidentally considered an Enhances a reason to keep a package installed, which of course it is not, fix the determination of "existing soft dependency" to only include soft dependencies that should keep a package installed in the autoremover to solve the issue. This also fixes edsp/mantic-upgrade-rel-to-2024-05-29.edsp to not install llvm-13-dev for clang-13 which is an installed package with no upgrade. Also ensure we stop after the first match; the DependsList() is ordered by decreasing priority and we don't want to override Recommends by Suggests in case a package declares both... LP: #2101800 2025-03-12T17:18:17Z Julian Andres Klode julian.klode@canonical.com 2025-03-12T17:17:48Z urn:sha1:5c101b3d4651b2f181ac586b088894cce5008d3b 2025-03-10T21:47:39Z Julian Andres Klode julian.klode@canonical.com 2025-03-10T21:05:52Z urn:sha1:8a6b694108f41afd1e6cdba4c91481697f9b3004 We incorrectly used the DependencyData of the first or group member, however that only checked that the first or group member was the same and that both either had a next member or not. 2025-03-10T21:33:05Z Julian Andres Klode julian.klode@canonical.com 2025-03-10T17:37:55Z urn:sha1:1fc8e9eee4d6a81f907b399034f6f82da2e98140 The upgrade code may also set Upgrade: yes, and this sets both to yes, so `apt upgrade` dumps behave like `apt-get upgrade` ones, which of course is not intentional. moo 2025-03-09T13:53:53Z Julian Andres Klode julian.klode@canonical.com 2025-03-09T13:52:53Z urn:sha1:5daf6dbfd272be2f8e3c59d4bab4be8c119b7aa1 Only move obsolete packages last that are automatically installed, as we don't want to remove manually installed obsolete packages. Add some missing const annotations to the operator[] arguments as well that were needed. LP: #2100247 2025-03-09T12:55:23Z Julian Andres Klode julian.klode@canonical.com 2025-03-09T12:55:23Z urn:sha1:6c112f9860c1730237029f4e23d40bf658d73704 This can provide useful additional context. To avoid updating the whole test suite for it, introduce a new option `quiet::NoSolver3Explanation` and set it by default. All the other tests that assert output will already have matching tests for --solver 3.0 with the correct messages asserted, it makes no sense to duplicate them. 2025-03-09T12:33:53Z Julian Andres Klode julian.klode@canonical.com 2025-02-18T12:06:32Z urn:sha1:935a9ab334e55a29363f45e7de6338c47337e806 Always run the 3.0 solver after the internal solver. If the internal solver failed, and the 3.0 solver did not, use the 3.0 result. If 3.0 solver failed or produced a worse result than the internal solver, write an apport crash dump. We exclude situations which we now the solver can't handle, i.e. removals are forbidden and you requested removals, and stuff like that. 2025-03-08T22:18:05Z Julian Andres Klode julian.klode@canonical.com 2025-03-06T19:07:30Z urn:sha1:3967b75ae4a10d0d79560dfecb8eb210aad4f4f2 Introduce a new function, LongWhyStr() that returns a longer reason for why something is being installed (or not). This does the same path walk as the other function does, but it renders the clauses at each level, and one per line, so the whole output is a lot more informative. It is a separate function to keep the existing debug messages use the simple single line implication graph We remove the other special case in AddWork() for empty solutions to mke use of the general case in Solve() instead, and then adapt the case in Solve() to the same case as in Enqueue(). This also happens to fix the bug that when we encountered an empty clause we just printed the clause had no solution, but not how we got to install the package with the clause. Adapt the test suite for the changes which is an annoying amount of paperwork. 2025-03-04T20:41:41Z Julian Andres Klode julian.klode@canonical.com 2025-03-04T20:41:41Z urn:sha1:1b959f0129460f2267e66bc77ca9464c28c915c5 This is important for upcoming multi-line solver error message work.