Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.9.6 2024-07-01T19:49:26Z 2024-07-01T19:49:26Z Julian Andres Klode julian.klode@canonical.com 2024-06-13T15:55:10Z urn:sha1:b69f11fac9f4df52726ea7ac4f2c5920b7f71ccb Refactor the various Install requests into a single one and move some stuff around, this should be a bit easier to maintain and we don't repeat ourselves all the time. This accidentally uncovered some bugs in the code, that get fixed by this: - The UpgradeManual and InstallManual groups did not work correctly, Essential packages were Install and others were Upgrade. - Automatically installed packages falsely got promoted to the manual groups as they got promoted into the manual code path, whenever we ran without allowing their removal. - The combination of --mark-auto --auto-remove now works correctly We previously skipped the installation of automatically installed packages when we did autoremoval, but we did not consider if the action was protected, that is specified on the command-line. Now we do not autoremove protected actions, and have added a test case for it. - The AllowRemoveManual option no longer is applied if removals are generally denied. Closes: #1071519 2024-07-01T14:28:53Z Julian Andres Klode julian.klode@canonical.com 2024-07-01T14:27:15Z urn:sha1:b636668788fe8b1f7183b21eaf7b87f34209169e As part of the refactoring, we allowed the code to work on unimportant dependencies as we needed to promote Suggests to Depends if they are currently satisfied. However, Replaces and Enhances were not considered properly and both are not negative dependencies so they were accidentally promoted to Depends too if they were currently satisfied. 2024-06-13T13:10:06Z Julian Andres Klode julian.klode@canonical.com 2024-06-06T09:19:04Z urn:sha1:6708203296911800caf94bb94ce204d3a39af0bd This has two aspects: 1. For a dependency A | B | C we order the obsolete packages last, that is, if A is obsolete, this gets reordered to B | C | A, such that we try to pick non-obsolete packages first to ease upgrade calculation. 2. When comparing two dependencies, we order dependencies into three groups: First we satisfy dependencies mentioning only non-installed (NEW) packages, then we satisfy "normal" dependencies, and finally we satisfy any dependencies mentioning obsolete packages. This means for example if you have obsolete libfoo1 and a new libfoo1t64, that we will see Depends: libfoo1t64 before any Depends: libfoo1 (which may expand to libfoo1 | libfoo1t64), so we effectively will have selected "replacement" packages this way already before getting to older packages where we would have to choose between the obsolete package and its replacement. 2024-06-13T12:32:32Z Julian Andres Klode julian.klode@canonical.com 2024-06-06T09:40:14Z urn:sha1:bfb9f2124b8f9da48b53d279278de3f8f0a00b82 When a test-* file is created but not executable, we'd ignore the argument and then our subprocess would run the entire test suite itself, sequentially. Silly. Let's just see if the file exists instead, then the test will fail. 2024-05-28T10:12:00Z Julian Andres Klode julian.klode@canonical.com 2024-05-28T10:12:00Z urn:sha1:32a503b97583ab227e9a34d7c3d3d30171c6bcf5 These got broken by the recent solver3 changes by accident, and we did not notice as I also broke the test suite detection with the new statistics feature, hooray. 2024-05-24T15:01:55Z Julian Andres Klode julian.klode@canonical.com 2024-05-23T11:24:25Z urn:sha1:4a2b89be6fa73b9c193d5b70e11a9305272efc3e We also need to issue a MarkDelete() if the package is marked for installation currently but should not be, not only if it did not have a previous version. This fixes the final test in test-multiarch-barbarian, the others only needed adjustments to mark all packages as automatic. 2024-05-24T15:01:55Z Julian Andres Klode julian.klode@canonical.com 2024-05-21T14:57:56Z urn:sha1:aaa9e415ce48964726401462767d6038da6d82e7 When restoring previously solved items, we try to restore items that have become unsolved again by skipping items that have a solved solution. Well at least we thought we did, but we accidentally had a "not" in there that inverted the meaning, hence we lost work items on backtracking. This mostly did not seem to have caused any issues, I stumbled over it while trying to add `autoremove` listings to `upgrade`, but fixing it also fixes: test-ubuntu-bug-1130419-prefer-installed-ma-same-siblings This used to say "E: Broken packages", meaning the solver lost a non-optional install request and the 2nd stage solver caught an incomplete solution. Also test-bug-735967-lib32-to-i386-unavailable restores the legacy solver behavior, so win win? 2024-05-24T15:01:55Z Julian Andres Klode julian.klode@canonical.com 2024-05-20T12:59:58Z urn:sha1:cd245a57f273d3c069543c19d6ac31c84879ce7b This somewhat improves reliability of not breaking Recommends, e.g. if the Recommends gets tightened. One test case enabled by this now is the test-resolver-provider-exchange, which with a simple change to allow removal of automatically installed packages works now. 2024-05-24T15:01:55Z Julian Andres Klode julian.klode@canonical.com 2024-05-19T19:24:08Z urn:sha1:0fa3b176652ff10276569a478c910ca866a4da5d As per the test-suggests-promoted-to-recommends test. This is still a bit messy as we ignore alternative choices and only check the last one, but um seems useful? 2024-05-24T15:01:55Z Julian Andres Klode julian.klode@canonical.com 2024-05-24T13:17:41Z urn:sha1:56737e4bdb58e03eeea6f915259f3a18a79642a3 The previous commit basically fixes this, it just requires some minor small adjustments