diff options
author | David Kalnischkies <david@kalnischkies.de> | 2023-01-29 13:27:24 +0100 |
---|---|---|
committer | David Kalnischkies <david@kalnischkies.de> | 2023-01-29 13:59:30 +0100 |
commit | 2cd6be476d1e5a5592ddac8a912ae73bc882d55e (patch) | |
tree | 3a9f5ce8038ff316d6d2cfd0f0406ab5c75b7366 | |
parent | b7d4e96379c2a56b9222d4640618576a03e4dafd (diff) |
Drop redundant 'virtual' on function marked 'override'
Reported-By: clang-tidy [cppcoreguidelines-explicit-virtual-functions]
Gbp-Dch: Ignore
-rw-r--r-- | apt-pkg/cachefilter.h | 64 |
1 files changed, 32 insertions, 32 deletions
diff --git a/apt-pkg/cachefilter.h b/apt-pkg/cachefilter.h index ccff6f9a3..8ea8cf3da 100644 --- a/apt-pkg/cachefilter.h +++ b/apt-pkg/cachefilter.h @@ -30,35 +30,35 @@ public: class APT_PUBLIC PackageMatcher : public Matcher { public: - virtual bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE = 0; - virtual bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE { return (*this)(Ver.ParentPkg()); } - virtual bool operator() (pkgCache::GrpIterator const &/*Grp*/) APT_OVERRIDE { return false; } - virtual ~PackageMatcher(); + bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE = 0; + bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE { return (*this)(Ver.ParentPkg()); } + bool operator() (pkgCache::GrpIterator const &/*Grp*/) APT_OVERRIDE { return false; } + ~PackageMatcher() APT_OVERRIDE; }; // Generica like True, False, NOT, AND, OR /*{{{*/ class APT_PUBLIC TrueMatcher : public Matcher { public: - virtual bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; - virtual bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; - virtual bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE; + bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; + bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; + bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE; }; class APT_PUBLIC FalseMatcher : public Matcher { public: - virtual bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; - virtual bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; - virtual bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE; + bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; + bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; + bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE; }; class APT_PUBLIC NOTMatcher : public Matcher { Matcher * const matcher; public: explicit NOTMatcher(Matcher * const matcher); - virtual bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; - virtual bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; - virtual bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE; - virtual ~NOTMatcher(); + bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; + bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; + bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE; + ~NOTMatcher() APT_OVERRIDE; }; class APT_PUBLIC ANDMatcher : public Matcher { @@ -72,10 +72,10 @@ public: ANDMatcher(Matcher * const matcher1, Matcher * const matcher2, Matcher * const matcher3, Matcher * const matcher4); ANDMatcher(Matcher * const matcher1, Matcher * const matcher2, Matcher * const matcher3, Matcher * const matcher4, Matcher * const matcher5); ANDMatcher& AND(Matcher * const matcher); - virtual bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; - virtual bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; - virtual bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE; - virtual ~ANDMatcher(); + bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; + bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; + bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE; + ~ANDMatcher() APT_OVERRIDE; }; class APT_PUBLIC ORMatcher : public Matcher { std::vector<Matcher *> matchers; @@ -88,28 +88,28 @@ public: ORMatcher(Matcher * const matcher1, Matcher * const matcher2, Matcher * const matcher3, Matcher * const matcher4); ORMatcher(Matcher * const matcher1, Matcher * const matcher2, Matcher * const matcher3, Matcher * const matcher4, Matcher * const matcher5); ORMatcher& OR(Matcher * const matcher); - virtual bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; - virtual bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; - virtual bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE; - virtual ~ORMatcher(); + bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; + bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; + bool operator() (pkgCache::VerIterator const &Ver) APT_OVERRIDE; + ~ORMatcher() APT_OVERRIDE; }; /*}}}*/ class APT_PUBLIC PackageNameMatchesRegEx : public PackageMatcher { /*{{{*/ regex_t* pattern; public: explicit PackageNameMatchesRegEx(std::string const &Pattern); - virtual bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; - virtual bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; - virtual ~PackageNameMatchesRegEx(); + bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; + bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; + ~PackageNameMatchesRegEx() APT_OVERRIDE; }; /*}}}*/ class APT_PUBLIC PackageNameMatchesFnmatch : public PackageMatcher { /*{{{*/ const std::string Pattern; public: explicit PackageNameMatchesFnmatch(std::string const &Pattern); - virtual bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; - virtual bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; - virtual ~PackageNameMatchesFnmatch() {}; + bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; + bool operator() (pkgCache::GrpIterator const &Grp) APT_OVERRIDE; + ~PackageNameMatchesFnmatch() APT_OVERRIDE = default; }; /*}}}*/ class APT_PUBLIC PackageArchitectureMatchesSpecification : public PackageMatcher { /*{{{*/ @@ -134,16 +134,16 @@ public: */ PackageArchitectureMatchesSpecification(std::string const &pattern, bool const isPattern = true); bool operator() (char const * const &arch); - virtual bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; - virtual ~PackageArchitectureMatchesSpecification(); + bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; + ~PackageArchitectureMatchesSpecification() APT_OVERRIDE; }; /*}}}*/ class APT_PUBLIC PackageIsNewInstall : public PackageMatcher { /*{{{*/ pkgCacheFile * const Cache; public: explicit PackageIsNewInstall(pkgCacheFile * const Cache); - virtual bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; - virtual ~PackageIsNewInstall(); + bool operator() (pkgCache::PkgIterator const &Pkg) APT_OVERRIDE; + ~PackageIsNewInstall() APT_OVERRIDE; }; /*}}}*/ |