summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Vogt <mvo@ubuntu.com>2019-01-29 10:17:33 +0100
committerMichael Vogt <mvo@ubuntu.com>2019-01-29 10:17:33 +0100
commit6af48a7f83540c807be1d2777470d23e6b260eb8 (patch)
tree273f0f571301ce8facbc5a5acb1f787f0f9ab9c2
parentfb700bfa9e1850ca3379c69db0b73435bcd48fea (diff)
private-json-hooks.cc: deal with EPIPE
While running our CI we noticed that sometimes we see an error from the new json hooks code. The error message is: ``` E: Could not read response to hello message from hook [ ! -f /usr/bin/snap ] || /usr/bin/snap advise-snap --from-apt 2>/dev/null || true: Broken pipe ``` when purging the snapd package which provides the hook. This indicates that we should probably also consider EPIPE not an error (just like we do for ECONNRESET). This PR does exactly this.
-rw-r--r--apt-private/private-json-hooks.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/apt-private/private-json-hooks.cc b/apt-private/private-json-hooks.cc
index b5c1a7172..65ff87924 100644
--- a/apt-private/private-json-hooks.cc
+++ b/apt-private/private-json-hooks.cc
@@ -387,7 +387,7 @@ bool RunJsonHook(std::string const &option, std::string const &method, const cha
if (size < 0)
{
- if (errno != ECONNRESET)
+ if (errno != ECONNRESET && errno != EPIPE)
_error->Error("Could not read response to hello message from hook %s: %s", Opts->Value.c_str(), strerror(errno));
goto out;
}