diff options
| author | Julian Andres Klode <julian.klode@canonical.com> | 2019-04-30 12:07:07 +0200 |
|---|---|---|
| committer | Julian Andres Klode <julian.klode@canonical.com> | 2019-04-30 17:43:31 +0200 |
| commit | b52c6552c44fcb997b0db9f5e9f17b4674dd5359 (patch) | |
| tree | 711f7259a65f5b658cb5ad4798323c2226cfb7c2 /apt-inst/deb | |
| parent | 4fa03143eee3776e2fa8fbd59d3cbaea40be0871 (diff) | |
Add 'explicit' to most single argument constructors
This prevents implicit conversions that we do not want, such
as having a FileFd* being converted to a debListParser.
Two cases are not yet handled because they require changes
in code using them:
1. The classes in hashes.h
2. The URI class - this one is used quite a lot
Diffstat (limited to 'apt-inst/deb')
| -rw-r--r-- | apt-inst/deb/debfile.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/apt-inst/deb/debfile.h b/apt-inst/deb/debfile.h index 23a76bfdf..21c59a567 100644 --- a/apt-inst/deb/debfile.h +++ b/apt-inst/deb/debfile.h @@ -56,7 +56,7 @@ class debDebFile const ARArchive::Member *GotoMember(const char *Name); inline FileFd &GetFile() {return File;}; - debDebFile(FileFd &File); + explicit debDebFile(FileFd &File); }; class debDebFile::ControlExtract : public pkgDirStream @@ -87,7 +87,7 @@ class debDebFile::MemControlExtract : public pkgDirStream bool TakeControl(const void *Data,unsigned long long Size); MemControlExtract() : IsControl(false), Control(0), Length(0), Member("control") {}; - MemControlExtract(std::string Member) : IsControl(false), Control(0), Length(0), Member(Member) {}; + explicit MemControlExtract(std::string Member) : IsControl(false), Control(0), Length(0), Member(Member) {}; ~MemControlExtract() {delete [] Control;}; }; /*}}}*/ |