diff options
author | Julian Andres Klode <julian.klode@canonical.com> | 2019-04-30 12:07:07 +0200 |
---|---|---|
committer | Julian Andres Klode <julian.klode@canonical.com> | 2019-04-30 17:43:31 +0200 |
commit | b52c6552c44fcb997b0db9f5e9f17b4674dd5359 (patch) | |
tree | 711f7259a65f5b658cb5ad4798323c2226cfb7c2 /apt-inst | |
parent | 4fa03143eee3776e2fa8fbd59d3cbaea40be0871 (diff) |
Add 'explicit' to most single argument constructors
This prevents implicit conversions that we do not want, such
as having a FileFd* being converted to a debListParser.
Two cases are not yet handled because they require changes
in code using them:
1. The classes in hashes.h
2. The URI class - this one is used quite a lot
Diffstat (limited to 'apt-inst')
-rw-r--r-- | apt-inst/contrib/arfile.h | 2 | ||||
-rw-r--r-- | apt-inst/deb/debfile.h | 4 | ||||
-rw-r--r-- | apt-inst/filelist.h | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/apt-inst/contrib/arfile.h b/apt-inst/contrib/arfile.h index 8124208c9..cf454941e 100644 --- a/apt-inst/contrib/arfile.h +++ b/apt-inst/contrib/arfile.h @@ -44,7 +44,7 @@ class ARArchive const Member *FindMember(const char *Name) const; inline Member *Members() { return List; } - ARArchive(FileFd &File); + explicit ARArchive(FileFd &File); ~ARArchive(); }; diff --git a/apt-inst/deb/debfile.h b/apt-inst/deb/debfile.h index 23a76bfdf..21c59a567 100644 --- a/apt-inst/deb/debfile.h +++ b/apt-inst/deb/debfile.h @@ -56,7 +56,7 @@ class debDebFile const ARArchive::Member *GotoMember(const char *Name); inline FileFd &GetFile() {return File;}; - debDebFile(FileFd &File); + explicit debDebFile(FileFd &File); }; class debDebFile::ControlExtract : public pkgDirStream @@ -87,7 +87,7 @@ class debDebFile::MemControlExtract : public pkgDirStream bool TakeControl(const void *Data,unsigned long long Size); MemControlExtract() : IsControl(false), Control(0), Length(0), Member("control") {}; - MemControlExtract(std::string Member) : IsControl(false), Control(0), Length(0), Member(Member) {}; + explicit MemControlExtract(std::string Member) : IsControl(false), Control(0), Length(0), Member(Member) {}; ~MemControlExtract() {delete [] Control;}; }; /*}}}*/ diff --git a/apt-inst/filelist.h b/apt-inst/filelist.h index 7fe43de63..c5f103d87 100644 --- a/apt-inst/filelist.h +++ b/apt-inst/filelist.h @@ -97,7 +97,7 @@ class pkgFLCache bool AddConfFile(const char *Name,const char *NameEnd, PkgIterator const &Owner,const unsigned char *Sum); - pkgFLCache(DynamicMMap &Map); + explicit pkgFLCache(DynamicMMap &Map); // ~pkgFLCache(); }; @@ -288,7 +288,7 @@ class pkgFLCache::NodeIterator Package *RealPackage() const; NodeIterator() : Nde(0), Type(NdeHash), Owner(0) {}; - NodeIterator(pkgFLCache &Owner) : Nde(Owner.NodeP), Type(NdeHash), Owner(&Owner) {} + explicit NodeIterator(pkgFLCache &Owner) : Nde(Owner.NodeP), Type(NdeHash), Owner(&Owner) {} NodeIterator(pkgFLCache &Owner,Node *Trg) : Nde(Trg), Type(NdeHash), Owner(&Owner) {} NodeIterator(pkgFLCache &Owner,Node *Trg,Package *) : Nde(Trg), Type(NdePkg), Owner(&Owner) {} }; |