summaryrefslogtreecommitdiff
path: root/apt-pkg
diff options
context:
space:
mode:
authorJulian Andres Klode <jak@debian.org>2026-05-01 16:27:19 +0000
committerJulian Andres Klode <jak@debian.org>2026-05-01 16:27:19 +0000
commit6a59fb95cf6fbe52c714e7f7caa3fc85bb919b07 (patch)
tree467777a1a76219fe40e7dc247039773e24771951 /apt-pkg
parent8915e23a8f8c44bfba4dd42f77b9695120216820 (diff)
parente79f9bb22375fd72330b534e17dcd3ceace432e8 (diff)
Merge branch 'fix-memleak' into 'main'
apt-pkg: methods: fixed many minor memleaks See merge request apt-team/apt!568
Diffstat (limited to 'apt-pkg')
-rw-r--r--apt-pkg/contrib/cdromutl.cc1
-rw-r--r--apt-pkg/dirstream.cc1
-rw-r--r--apt-pkg/indexcopy.cc1
-rw-r--r--apt-pkg/pkgsystem.cc5
4 files changed, 7 insertions, 1 deletions
diff --git a/apt-pkg/contrib/cdromutl.cc b/apt-pkg/contrib/cdromutl.cc
index ff8fb4835..60d137930 100644
--- a/apt-pkg/contrib/cdromutl.cc
+++ b/apt-pkg/contrib/cdromutl.cc
@@ -255,6 +255,7 @@ bool IdentCdrom(string CD,string &Res,unsigned int Version)
closedir(D);
Res = Hash.GetHashString(Hashes::MD5SUM).HashValue().append(std::move(S));
+ close(dirfd);
return true;
}
/*}}}*/
diff --git a/apt-pkg/dirstream.cc b/apt-pkg/dirstream.cc
index ef9f08ebc..b71a34d3e 100644
--- a/apt-pkg/dirstream.cc
+++ b/apt-pkg/dirstream.cc
@@ -53,6 +53,7 @@ bool pkgDirStream::DoItem(Item &Itm,int &Fd)
return _error->Errno("fchown",_("Failed to write file %s"), Itm.Name);
}
Fd = iFd;
+ close(iFd);
return true;
}
diff --git a/apt-pkg/indexcopy.cc b/apt-pkg/indexcopy.cc
index 089bfd2ce..636393dd6 100644
--- a/apt-pkg/indexcopy.cc
+++ b/apt-pkg/indexcopy.cc
@@ -573,6 +573,7 @@ bool SigVerify::CopyAndVerify(string CDROM,string Name,vector<string> &SigList,
pid_t pid = ExecFork();
if(pid < 0) {
_error->Error("Fork failed");
+ delete MetaIndex;
return false;
}
if(pid == 0)
diff --git a/apt-pkg/pkgsystem.cc b/apt-pkg/pkgsystem.cc
index 7e48a68c7..4bc05d19b 100644
--- a/apt-pkg/pkgsystem.cc
+++ b/apt-pkg/pkgsystem.cc
@@ -69,4 +69,7 @@ map_id_t pkgSystem::GetVersionMapping(map_id_t const in) const
return (o == d->idmap.end()) ? in : o->second;
}
/*}}}*/
-pkgSystem::~pkgSystem() {}
+pkgSystem::~pkgSystem()
+{
+ delete d;
+}