solver3: Upgrade by source package

Implement the "APT::Get::Upgrade-By-Source-Package" option as
the classic solver does.

Here this is equally straight forward now: We enqueue optional, but
eager, clauses of the form

    foo=2 -> foo-data=2

for each sibling in the source version, assuming they are currently
installed, and the selection is not the current version.

This softly enforces upgrades of already installed siblings, but
in non-strict-pinning mode it will not affect the selection of
new packages to be installed.

A more complete solution to version selection by source package
also seems feasible, where we change the "priority" of versions
in the solver dynamically - currently they are statically evaluated.
Such that, when you select foo=2, and something installs foo-data,
foo-data would be installed in version 2 even if version 3 were its
candidate.

1 files changed, 0 insertions, 31 deletions

diff --git a/test/integration/test-solver3-evaluation b/test/integration/test-solver3-evaluation
index 06edb4962..b750b9245 100755
--- a/test/integration/test-solver3-evaluation
+++ b/test/integration/test-solver3-evaluation
@@ -185,34 +185,3 @@ ErrorMessage:
 AptSolverDump:
 $(cat rootdir/var/log/apt/edsp.log.zst | base64 | sed 's#^# #')" cat rootdir/var/crash/apt-edsp.$(id -u).crash
 
-msgmsg "Test that more upgrades are not better in installs"
-# FIXME: This will fail once 3.0 solver tries upgrading by source package.
-insertinstalledpackage 'b' 'all' '2' 'Source: src'
-insertinstalledpackage  'c' 'all' '2' 'Source: src'
-
-# No "Writing error report..."
-testsuccess rm rootdir/var/crash/apt-edsp.$(id -u).crash
-testsuccessequal "Reading package lists...
-Building dependency tree...
-Solving dependencies...
-The following additional packages will be installed:
-  c
-The following packages will be upgraded:
-  b c
-2 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
-Inst b [2] (3 unstable [all])
-Inst c [2] (3 unstable [all])
-Conf b (3 unstable [all])
-Conf c (3 unstable [all])"  apt install --solver internal b  -s
-
-testfailure test -e rootdir/var/crash/apt-edsp.$(id -u).crash
-
-# Safety check to check that the 3.0 result actually looks worse
-testsuccessequal "Reading package lists...
-Building dependency tree...
-Solving dependencies...
-The following packages will be upgraded:
-  b
-1 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.
-Inst b [2] (3 unstable [all])
-Conf b (3 unstable [all])"  apt install --solver 3.0 b  -s