diff options
| author | David Kalnischkies <david@kalnischkies.de> | 2014-01-16 22:19:49 +0100 |
|---|---|---|
| committer | David Kalnischkies <david@kalnischkies.de> | 2014-01-16 22:19:49 +0100 |
| commit | 9ce3cfc9309c55cc01018c88c1ca82779fd74431 (patch) | |
| tree | e113a963a732f497d0362d3fff9e5b3834d5a175 /test/interactive-helper/rpmver.cc | |
| parent | 62d8a765b9b37354efab6ca838cbdb7f347f7cac (diff) | |
correct some style/performance/warnings from cppcheck
The most "visible" change is from utime to utimensat/futimens
as the first one isn't part of POSIX anymore.
Reported-By: cppcheck
Git-Dch: Ignore
Diffstat (limited to 'test/interactive-helper/rpmver.cc')
| -rw-r--r-- | test/interactive-helper/rpmver.cc | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/test/interactive-helper/rpmver.cc b/test/interactive-helper/rpmver.cc index 9fc807de8..15c96cbbe 100644 --- a/test/interactive-helper/rpmver.cc +++ b/test/interactive-helper/rpmver.cc @@ -2,6 +2,7 @@ #include <rpm/rpmio.h> #include <rpm/misc.h> #include <stdlib.h> +#include <stdio.h> #include <ctype.h> #define xisdigit(x) isdigit(x) @@ -12,10 +13,8 @@ using namespace std; int rpmvercmp(const char * a, const char * b) { - char oldch1, oldch2; char * str1, * str2; char * one, * two; - int rc; int isnum; /* easy comparison to see if versions are identical */ @@ -53,9 +52,9 @@ int rpmvercmp(const char * a, const char * b) /* save character at the end of the alpha or numeric segment */ /* so that they can be restored after the comparison */ - oldch1 = *str1; + char oldch1 = *str1; *str1 = '\0'; - oldch2 = *str2; + char oldch2 = *str2; *str2 = '\0'; /* take care of the case where the two version segments are */ @@ -81,7 +80,7 @@ int rpmvercmp(const char * a, const char * b) /* segments are alpha or if they are numeric. don't return */ /* if they are equal because there might be more segments to */ /* compare */ - rc = strcmp(one, two); + int rc = strcmp(one, two); if (rc) return rc; /* restore character that was replaced by null above */ |