solver3: Refactor (rewrite) FromDepCache()

Refactor the various Install requests into a single one and move
some stuff around, this should be a bit easier to maintain and
we don't repeat ourselves all the time.

This accidentally uncovered some bugs in the code, that get fixed
by this:

- The UpgradeManual and InstallManual groups did not work correctly,
  Essential packages were Install and others were Upgrade.

- Automatically installed packages falsely got promoted to the
  manual groups as they got promoted into the manual code path,
  whenever we ran without allowing their removal.

- The combination of --mark-auto --auto-remove now works correctly

  We previously skipped the installation of automatically installed
  packages when we did autoremoval, but we did not consider if the
  action was protected, that is specified on the command-line.

  Now we do not autoremove protected actions, and have added a test
  case for it.

- The AllowRemoveManual option no longer is applied if removals are
  generally denied.

Closes: #1071519

0 files changed, 0 insertions, 0 deletions