summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Release 1.7.0~alpha31.7.0_alpha3Julian Andres Klode2018-08-2052-239/+913
|
* clear alternative URIs for mirror:// between steps (CVE-2018-0501)David Kalnischkies2018-08-203-21/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | APT in 1.6 saw me rewriting the mirror:// transport method, which works comparable to the decommissioned httpredir.d.o "just" that apt requests a mirror list and performs all the redirections internally with all the bells like parallel download and automatic fallback (more details in the apt-transport-mirror manpage included in the 1.6 release). The automatic fallback is the problem here: The intend is that if a file fails to be downloaded (e.g. because the mirror is offline, broken, out-of-sync, …) instead of erroring out the next mirror in the list is contacted for a retry of the download. Internally the acquire process of an InRelease file (works with the Release/Release.gpg pair, too) happens in steps: 1) download file and 2) verify file, both handled as URL requests passed around. Due to an oversight the fallbacks for the first step are still active for the second step, so that the successful download from another mirror stands in for the failed verification… *facepalm* Note that the attacker can not judge by the request arriving for the InRelease file if the user is using the mirror method or not. If entire traffic is observed Eve might be able to observe the request for a mirror list, but that might or might not be telling if following requests for InRelease files will be based on that list or for another sources.list entry not using mirror (Users have also the option to have the mirror list locally (via e.g. mirror+file://) instead of on a remote host). If the user isn't using mirror:// for this InRelease file apt will fail very visibly as intended. (The mirror list needs to include at least two mirrors and to work reliably the attacker needs to be able to MITM all mirrors in the list. For remotely accessed mirror lists this is no limitation as the attacker is in full control of the file in that case) Fixed by clearing the alternatives after a step completes (and moving a pimpl class further to the top to make that valid compilable code). mirror:// is at the moment the only method using this code infrastructure (for all others this set is already empty) and the only method-independent user so far is the download of deb files, but those are downloaded and verified in a single step; so there shouldn't be much opportunity for regression here even through a central code area is changed. Upgrade instructions: Given all apt-based frontends are affected, even additional restrictions like signed-by are bypassed and the attack in progress is hardly visible in the progress reporting of an update operation (the InRelease file is marked "Ign", but no fallback to "Release/Release.gpg" is happening) and leaves no trace (expect files downloaded from the attackers repository of course) the best course of action might be to change the sources.list to not use the mirror family of transports ({tor+,…}mirror{,+{http{,s},file,…}}) until a fixed version of the src:apt packages are installed. Regression-Of: 355e1aceac1dd05c4c7daf3420b09bd860fd169d, 57fa854e4cdb060e87ca265abd5a83364f9fa681 LP: #1787752
* Update symbolsJulian Andres Klode2018-08-202-0/+19
|
* Report (soon) worthless keys if gpg uses fpr for GOODSIGDavid Kalnischkies2018-08-192-35/+49
| | | | | | | | | | gpgs DETAILS documentation file declares that GOODSIG could report keyid or fingerprint since gpg2, but for the time being it is still keyid only. Who knows if that will ever change as that feels like an interface break with dangerous security implications, but lets be better safe than sorry especially as the code dealing with signed-by keyids is prepared for this already. This code is rewritten still to have them all use the same code for this type of problem.
* test: Supports records larger than 32kb in 'apt show'David Kalnischkies2018-08-191-0/+33
| | | | | | | | | | The 1.7 series rework of show started in bf53f39c9a0221b670ffff74053ed36fc502d5a0 resolved the issue already, but its always a good idea to at least bring the tests along so that we hopeful do not regress in the future with another rewrite. Tests: #905527 Gbp-Dch: Ignore
* Simplified Chinese program translation updateBoyuan Yang2018-08-191-34/+31
| | | | | Reviewed-by: Mo Zhou <cdluminate@gmail.com> Closes: #903695
* aptwebserver: Prefetch compressors to avoid thread crashesDavid Kalnischkies2018-08-191-0/+1
| | | | | | | | | | | | | If multiple threads act on requests (like if connection comes from a webbrowser) a thread might request the supported compressors while another thread is still working on creating the list to be stored in the static cache variable. As the price to pay for atomic and co seems to high for the fringe usecase of manual usage of aptwebserver the patch just makes a call to generate the list while still single threaded. Gbp-Dch: Ignore
* CMake: Use ${PROJECT_NAME} instead of hardcoding aptDavid Kalnischkies2018-08-141-6/+7
| | | | | | | Completely pointless as it makes no difference for apt, but copying the file to other projects becomes a lot easier. Gbp-Dch: Ignore
* Set DPKG_FRONTEND_LOCKED as needed when doing selection changesJulian Andres Klode2018-08-081-0/+5
| | | | | | | We forgot to set the variable for the selection changes. Let's set it for that and some other dpkg calls. Regression-Of: c2c8b4787b0882234ba2772ec7513afbf97b563a
* Merge branch 'bugfix/big-lock' into 'master'Julian Andres Klode2018-08-076-9/+93
|\ | | | | | | | | Add support for dpkg frontend lock See merge request apt-team/apt!11
| * Add support for dpkg frontend lockJulian Andres Klode2018-08-076-9/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The dpkg frontend lock is a lock dpkg tries to acquire except if the frontend already acquires it. This fixes a race condition in the install command where the dpkg lock is not held for a short period of time between different dpkg invocations. For this reason we also define an environment variable DPKG_FRONTEND_LOCKED for dpkg invocations so dpkg knows not to try to acquire the frontend lock because it's held by a parent process. We can set DPKG_FRONTEND_LOCKED only if the frontend lock really is held; that is, if our lock count is greater than 0 - otherwise an apt client not using the LockInner family of functions would run dpkg without the frontend lock set, but with DPKG_FRONTEND_LOCKED set. Such a process has a weaker guarantee: Because dpkg would not lock the frontend lock either, the process is prone to the existing races, and, more importantly, so is a new style process. Closes: #869546 [fixups: fix error messages, add public IsLocked() method, and make {Un,}LockInner return an error on !debSystem]
* | Merge branch 'master' into 'master'Julian Andres Klode2018-08-0745-62/+62
|\ \ | |/ |/| | | | | Add trailing newline to output of edit-sources. See merge request apt-team/apt!22
| * Add trailing newline to output of edit-sources.Jean-Ralph Aviles2018-06-3045-62/+62
| | | | | | | | Makes the console output cleaner.
* | Release 1.7.0~alpha21.7.0_alpha2Julian Andres Klode2018-07-099-28/+34
| |
* | Use cheaper entropy source for randomizing items to fetchJulian Andres Klode2018-07-061-2/+3
|/ | | | | | The random_device fails if not enough entropy is available. We do not need high-quality entropy here, though, so let's switch to a seed based on the current time in nanoseconds, XORed with the PID.
* Merge branch 'pu/lp1776218-allow-hooks-to-not-handshake' into 'master'Julian Andres Klode2018-06-282-2/+95
|\ | | | | | | | | Handle JSON hooks that just close the file/exit and fix some other errors See merge request apt-team/apt!21
| * Handle JSON hooks that just close the file/exit and fix some other errorsJulian Andres Klode2018-06-272-2/+95
|/ | | | | | | | | | | | | | JSON hooks might disappear and the common idiom to work around hooks disappearing is to check for the hook in the shell snippet that is in the apt.conf file and if it does not exist, do nothing. This caused APT to fail however, expecting it to acknowledge the handshake. Ignoring ECONNRESET on handshakes solves the problem. The error case, and the other error cases also did not stop execution of the hook, causing more errors to pile up. Fix this by directly going to the closing part of the code. LP: #1776218
* Release 1.7.0~alpha11.7.0_alpha1Julian Andres Klode2018-06-2551-610/+485
|
* gitlab-ci: chmod 755 /rootJulian Andres Klode2018-06-251-0/+1
| | | | This should avoid test failures on ubuntu:bionic
* Ensure that we are online in apt-daily-upgrade.serviceJulian Andres Klode2018-06-251-1/+2
| | | | | | | Installer packages need us to be online, or they are blocking shutdowns in the worst case :( LP: #1723761
* CI: Export DEBIAN_FRONTEND=noninteractive in all CI environmentsJulian Andres Klode2018-06-253-2/+9
| | | | This ensures that we don't hang waiting for debconf.
* Fix lock counting in debSystemJulian Andres Klode2018-06-131-1/+1
| | | | | | | | | | | | | | | debSystem uses a reference counted lock, so you can acquire it multiple times in your applications, possibly nested. Nesting locks causes a fd leak, though, as we only increment the lock count when we already have locked twice, rather than once, and hence when we call lock the second time, instead of increasing the lock count, we open another lock fd. This fixes the code to check if we have locked at all (> 0). There is no practical problem here aside from the fd leak, as closing the new fd releases the lock on the old one due to the weird semantics of fcntl locks.
* Dutch manpage translation updateFrans Spiesschaert2018-06-021-232/+467
| | | | Closes: #900602
* Dutch program translation updateFrans Spiesschaert2018-06-021-31/+24
| | | | Closes: #900589
* Merge branch 'fix/usesteadyclockforprogress' into 'master'Julian Andres Klode2018-05-305-94/+96
|\ | | | | | | | | Fix/usesteadyclockforprogress See merge request apt-team/apt!19
| * Use steady clock source for bandwidth limitationDavid Kalnischkies2018-05-292-10/+11
| | | | | | | | | | Using the time of day for this is slightly wrong just like it is for progress, just less visible.
| * Remove unused time-tracking from http methodDavid Kalnischkies2018-05-282-20/+0
| | | | | | | | | | | | | | The Stats method isn't called anywhere, was partly commented out before, but we keep updating the time for it – lets avoid this pointless busywork. Gbp-Dch: Ignore
| * Use a steady clock source for progress reportingDavid Kalnischkies2018-05-283-64/+85
| | | | | | | | | | | | Clock changes while apt is running can result in strange reports confusing (and amusing) users. Sadly, to keep the ABI for now the code is a bit more ugly than it would need to be.
* | apt-key: Pass all instead of gpg-agent to gpgconf --killJulian Andres Klode2018-05-291-1/+1
|/ | | | | | We want to kill everything using our temporary directory. LP: #1773992
* Don't show acquire warning for "hidden" componentsDavid Kalnischkies2018-05-283-10/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit d7c92411dc1f4c6be098d1425f9c1c075e0c2154 introduced a warning for non-existent files from components not mentioned in Components to hint users at a mispelling or the disappearance of a component. The debian-installer subcomponent isn't actively advertised in the Release file through, so if apt ends up in acquiring a file which doesn't exist for this component (like Translation files) apt would produce a warning: W: Skipping acquire of configured file 'main/debian-installer/i18n/Translation-en' as repository 'http://deb.debian.org/debian buster InRelease' doesn't have the component 'main/debian-installer' (component misspelt in sources.list?) We prevent this in the future by checking if any file exists from this component which results in the warning to be produced still for the intended cases and silence it on the d-i case. This could potentially cause the warning not to be produced in cases it should be if some marginal file remains, but as this message is just a hint and the setup a bit pathological lets ignore it for now. There is also the possibility of having no file present as they would all be 0-length files and being a "hidden" component, but that would be easy to workaround from the repository side and isn't really actively used at the moment in the wild. Closes: #879591
* tests: Prevent stunnel4 from binding on IPv6David Kalnischkies2018-05-281-1/+1
| | | | | | | | Hardcoding the IPv4 address 127.0.0.1 stops stunnel4 from also binding on IPv6 as well which not only binds on another port but confuses our crude port extraction by splitting on ':' with ::1. Gbp-Dch: Ignore
* Merge branch 'pu/timeout-bad-addr-fixes' into 'master'Julian Andres Klode2018-05-246-8/+9
|\ | | | | | | | | Pu/timeout bad addr fixes See merge request apt-team/apt!18
| * Lower default timeout from 120s to 30sJulian Andres Klode2018-05-245-8/+8
| | | | | | | | | | 120s is an insanely high default time out, lower it to 30s to make things a bit nicer.
| * Handle a missed case of timed out ip addressesJulian Andres Klode2018-05-241-0/+1
| | | | | | | | | | | | | | Correctly register timed out IP addresses from a timed out select() call as a bad address so we do not try it again. LP: #1766542
* | Merge branch 'feature/morevolatilesupport' into 'master'Julian Andres Klode2018-05-2414-186/+557
|\ \ | | | | | | | | | | | | more volatile: build-dep foo.deb/release & show foo.deb See merge request apt-team/apt!14
| * | Support local files as arguments in show commandDavid Kalnischkies2018-05-114-32/+127
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that --with-source is supported in show we can go a little further and add the "syntactic sugar" of supporting deb-files on the commandline directly to give users an alternative to remembering dpkg -I for deb files & as a bonus apt also works on changes files. Most of the code churn is actually to deal with cases probably not too common in reality like mixing packages and deb-files on the commandline and getting the right order for these multiple records. Closes: 883206
| * | Support --with-source in show & search commandsDavid Kalnischkies2018-05-115-104/+141
| | |
| * | Deprectate buggy/incorrect Rls/PkgFile::IsOk methodsDavid Kalnischkies2018-05-112-14/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | With the advent of compressed files and especially with in-memory post-processed files the simple assumptions made in IsOk are no longer true. Worse, they are at best duplicates of checks performed by the cache generation (and validation) earlier and isn't used in too many places. It is hence best to simply get right of these calls instead of trying to fix them.
| * | Start pkg records for deb files with dpkg outputDavid Kalnischkies2018-05-111-16/+10
| | | | | | | | | | | | | | | | | | | | | | | | It is easier to prepend our fields, but that results in confusion for things working on the so generated records as they don't start with the usual "Package" – that shouldn't be a problem in theory, but in practice e.g. "apt-cache show" shows these records directly to the user who will probably be more confused by it than tools.
| * | Support release selector for volatile files as wellDavid Kalnischkies2018-05-115-50/+214
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The syntax is a bit awkward, but it is the same as for a package name and introducing another syntax wouldn't really help usability, so with apt install ./foo.deb/experimental you will get the dependencies of foo satisfied by your default release, but if this wouldn't satisfy the version requirements the candidate for this dependency is switched to the version from the experimental release. The same applies for apt build-dep ./foo.dsc/stable-backports which was the initial request.
| * | Extend apt build-dep pkg/release to switch dep as neededDavid Kalnischkies2018-05-113-8/+101
| | | | | | | | | | | | | | | | | | apt install pkg/release follows versioned dependencies in the candidate switching if the current candidate does not satisfy the dependency, so for uniformity the same should be supported in build-dep.
* | | Merge branch 'feature/byhashviaalturl' into 'master'Julian Andres Klode2018-05-245-199/+194
|\ \ \ | |_|/ |/| | | | | | | | Don't force the same mirror for by-hash URIs See merge request apt-team/apt!15
| * | Don't force the same mirror for by-hash URIsDavid Kalnischkies2018-05-111-19/+40
| | | | | | | | | | | | | | | | | | | | | | | | Downloading from the same mirror we got a Release file from makes sense for non-unique URIs as their content changes between mirror states, but if we ask for an index via by-hash we can be sure that we either get the file we wanted or a 404 for which we can perform a fallback for which allows us to pull indexes from different mirror in parallel.
| * | Handle by-hash URI construction more centrallyDavid Kalnischkies2018-05-113-115/+76
| | | | | | | | | | | | | | | | | | | | | Individual items shouldn't concern themselves with these alternative locations, we can deal with this more efficiently within the infrastructure created for other alternative URIs now avoiding the need to implement this in each item.
| * | Drop alternative URIs we got a hash-based fail fromDavid Kalnischkies2018-05-115-104/+117
| |/ | | | | | | | | | | | | | | | | | | | | If we got a file but it produced a hash error, mismatched size or similar we shouldn't fallback to alternative URIs as they likely result in the same error. If we can we should instead use another mirror. We used to be a lot stricter by stopping all trys for this file if we got a non-404 (or a hash-based) failure, but that is too hard as we really want to try other mirrors (if we have them) in the hope that they have the expected and correct files.
* | Merge branch 'debugautoremove' into 'master'David Kalnischkies2018-05-213-16/+48
|\ \ | | | | | | | | | | | | Increase debug verbosity in `apt-get autoremove` See merge request apt-team/apt!9
| * | Extend test-apt-get-autoremove to check debug outputFilipe Brandenburger2018-05-211-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | Run `apt-get autoremove -o Debug::pkgAutoRemove=yes` and confirm the logged reason for packages to be kept is correct. Only check for specific debug lines containing 'MarkPackage:' in order to prevent new debug logging to break the test case.
| * | Increase debug verbosity in `apt-get autoremove`Filipe Brandenburger2018-05-212-16/+23
|/ / | | | | | | | | | | | | | | | | | | | | When running with Debug::pkgAutoRemove=yes, explain why certain packages are being marked, either because they're marked essential/important or because they match the blacklist from APT::NeverAutoRemove. This should help troubleshoot cases where autoremove is not proposing removal of packages expected to be up for removal. Tested manually with `apt-get autoremove -o Debug::pkgAutoRemove=yes`.
* | Fix hidden test failure if not called via sudoDavid Kalnischkies2018-05-192-2/+2
| | | | | | | | | | | | | | | | id: '': no such user ./test-bug-611729-mark-as-manual: 59: [: Illegal number: Regression-of: 68842e1741a5005b1e3f0a07deffd737c65e3294 Gbp-Dch: Ignore
* | Reword error for timed out read/write on SOCKS proxyDavid Kalnischkies2018-05-191-1/+6
| | | | | | | | Closes: #898886
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2024-11-02 01:31:11 +0000