summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Russian program translation updateАлексей Шилин2019-02-101-21/+21
| | | | | Closes: #921830 Thanks: Vladimir Zhbanov <vzhbanov@gmail.com>
* json-hooks-protocol: The "pin" field is optionalJulian Andres Klode2019-02-071-1/+1
|
* Fix issues in previous two debian/changelog entriesJulian Andres Klode2019-02-071-2/+1
| | | | | | Last entry included an item that was not in the release, and the one before that was signed with the wrong email address.
* aptmethod.h: Do not have gcc warning about ignoring write() resultJulian Andres Klode2019-02-051-0/+7
| | | | | This is a special case here, a best effort write, so there's no point in having warnings about it for every method.
* Release 1.8.0~rc21.8.0_rc2Julian Andres Klode2019-02-043-2/+9
|
* Correctly handle feature detection for sse4.2 and crc32Julian Andres Klode2019-02-041-4/+4
| | | | Mistakingly used #define instead of #cmakedefine
* Release 1.8.0~rc11.8.0_rc1Julian Andres Klode2019-02-0459-186/+1373
|
* Use std::to_string() for HashStringList::FileSize() getterJulian Andres Klode2019-02-041-3/+1
| | | | | | | | This slightly improves performance, as std::to_string() (as in gcc's libstdc++) avoids a heap allocation. This is surprisingly performance critical code, so we might want to improve things further in 1.9 by manually calculating the string - that would also get rid of issues with locales changing string formatting, if any.
* Detect function multiversioning and sse4.2/crc32, enables i386Julian Andres Klode2019-02-044-2/+50
| | | | | This fixes the build on kfreebsd-amd64, and due to the detection of sse4.2, should also enable the sse4.2 on i386.
* gpgv: Use buffered writes for splitting clearsigned filesJulian Andres Klode2019-02-043-2/+13
| | | | | | This is safe here, as the code ensures that the file is flushed before it is being used. The next series should probably make GetTempFile() buffer writes by default.
* Merge branch 'pu/dead-pin' into 'master'Julian Andres Klode2019-02-048-10/+206
|\ | | | | | | | | A pin of -32768 overrides any other, disables repo See merge request apt-team/apt!40
| * Add a Packages-Require-Authorization Release file fieldJulian Andres Klode2019-02-017-4/+124
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This new field allows a repository to declare that access to packages requires authorization. The current implementation will set the pin to -32768 if no authorization has been provided in the auth.conf(.d) files. This implementation is suboptimal in two aspects: (1) A repository should behave more like NotSource repositories (2) We only have the host name for the repository, we cannot use paths yet. - We can fix those after an ABI break. The code also adds a check to acquire-item.cc to not use the specified repository as a download source, mimicking NotSource.
| * Introduce experimental 'never' pinning for sourcesJulian Andres Klode2019-02-012-6/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows disabling a repository by pinning it to 'never', which is internally translated to a value of -32768 (or whatever the minimum of short is). This overrides any other pin for that repository. It can be used to make sure certain sources are never used; for example, in unattended-upgrades. To prevent semantic changes to existing files, we substitute min + 1 for every pin-priority: <min>. This is a temporary solution, as we are waiting for an ABI break. To add pins with that value, the special Pin-Priority "never" may be used for now. It's unclear if that will persist, or if the interface will change eventually.
* | Merge branch 'pu/refuseunsignedlines' into 'master'Julian Andres Klode2019-02-019-249/+515
|\ \ | | | | | | | | | | | | Fail if InRelease or Release.gpg contain unsigned lines See merge request apt-team/apt!45
| * | Drop buffered writing from clearsigned message extractionDavid Kalnischkies2019-02-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is dropped in the merged code, but the extraction of the clearsigned message code was the only one who had it previously, so the short-desc explains the change from a before-after merge of the branch PoV. It would make sense to enable it, but as we aren't in a time critical paths here we can delay this for after buster to avoid problems. References: 73e3459689c05cd62f15c29d2faddb0fc215ef5e Suggested-By: Julian Andres Klode
| * | Avoid boolean flags by splitting writeTo functionsDavid Kalnischkies2019-02-011-14/+20
| | | | | | | | | | | | | | | Suggested-By: Julian Andres Klode Gbp-Dch: Ignore
| * | Reuse APT::StringView more in LineBufferDavid Kalnischkies2019-01-291-32/+9
| | | | | | | | | | | | | | | | | | | | | No effective change in behaviour, just simplifying and reusing code. Suggested-By: Julian Andres Klode Gbp-Dch: Ignore
| * | Rework ifs to use not instead of == false/trueDavid Kalnischkies2019-01-291-54/+66
| | | | | | | | | | | | | | | | | | | | | | | | No change in the logic itself, just dropping "== true", replacing "== false" with not and moving lines around to make branches more obvious. Suggested-By: Julian Andres Klode Gbp-Dch: Ignore
| * | Refuse files with lines unexpectedly starting with a dashDavid Kalnischkies2019-01-282-10/+161
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We support dash-encoding even if we don't really work with files who would need it as implementations are free to encode every line, but otherwise a line starting with a dash must either be a header we parse explicitly or the file is refused. This is against the RFC which says clients should warn on such files, but given that we aren't expecting any files with dash-started lines to begin with this looks a lot like a we should not continue to touch the file as it smells like an attempt to confuse different parsers by "hiding" headers in-between others. The other slightly more reasonable explanation would be an armor header key starting with a dash, but no existing key does that and it seems unlikely that this could ever happen. Also, it is recommended that clients warn about unknown keys, so new appearance is limited.
| * | Use more abstraction to handle the current line bufferDavid Kalnischkies2019-01-281-83/+133
| | | | | | | | | | | | | | | | | | | | | This is C++, so we can use a bit more abstraction to let the code look a tiny bit nicer hopefully improving readability a bit. Gbp-Dch: Ignore
| * | Explicitly remove the whitespaces defined by RFCDavid Kalnischkies2019-01-281-4/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | RFC 4880 section 7.1 "Dash-Escaped Text" at the end defines that only space and tab are allowed, so we should remove only these even if due to use complaining (or now failing) you can't really make use of it. Note that strrstrip was removing '\r\n\t ', not other whitespaces like \v or \f and another big reason to do it explicitly here now is to avoid that a future change adding those could have unintended consequences.
| * | Merge and reuse tmp file handling across the boardDavid Kalnischkies2019-01-245-85/+51
| | | | | | | | | | | | | | | | | | Having many rather similar implementations especially if one is exported while others aren't (and the rest of it not factored out at all) seems suboptimal.
| * | Fail on non-signature lines in Release.gpgDavid Kalnischkies2019-01-233-36/+139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The exploit for CVE-2019-3462 uses the fact that a Release.gpg file can contain additional content beside the expected detached signature(s). We were passing the file unchecked to gpgv which ignores these extras without complains, so we reuse the same line-reading implementation we use for InRelease splitting to detect if a Release.gpg file contains unexpected data and fail in this case given that we in the previous commit we established that we fail in the similar InRelease case now.
| * | Fail instead of warn for unsigned lines in InReleaseDavid Kalnischkies2019-01-233-133/+118
| |/ | | | | | | | | | | | | | | | | | | | | | | The warnings were introduced 2 years ago without any reports from the wild about them actually appearing for anyone, so now seems to be an as good time as any to switch them to errors. This allows rewritting the code by failing earlier instead of trying to keep going which makes the diff a bit hard to follow but should help simplifying reasoning about it. References: 6376dfb8dfb99b9d182c2fb13aa34b2ac89805e3
* | French program translation updateBaptiste Jammet2019-02-011-74/+58
| | | | | | | | | | Closes: #921008 Reviewed-By: Debian L10n French <debian-l10n-french@lists.debian.org>
* | Russian program translation updateАлексей Шилин2019-02-011-9/+5
| | | | | | | | Closes: #921011
* | Step over empty sections in TagFiles with commentsDavid Kalnischkies2019-02-013-2/+76
| | | | | | | | | | | | | | | | Implementing a parser with recursion isn't the best idea, but in practice we should get away with it for the time being to avoid needless codechurn. Closes: #920317 #921037
* | Merge branch 'pu/verify-method-messages-2' into 'master'Julian Andres Klode2019-01-311-0/+31
|\ \ | | | | | | | | | | | | Verify data being sent by methods in SendMessage() See merge request apt-team/apt!48
| * | Verify data being sent by methods in SendMessage()Julian Andres Klode2019-01-301-0/+31
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As a follow-up for CVE-2019-3462, add checks similar to those for redirect to the central SendMessage() function. The checks are a bit more relaxed for values - they may include newlines and unicode characters (newlines get rewritten, so are safe). For keys and the message header, the checks are far more strict: They may only contain alphanumerical characters, the hyphen-minus, and the horizontal space. In case the method tries to send anything else, we construct a legal 400 URI Failed response, and send that. We specifically do not include the item URI, in case it has been compromised (that would cause infinite recursion).
* | Disable deprecated methods (ftp, rsh, ssh) by defaultJulian Andres Klode2019-01-311-0/+2
| | | | | | | | | | | | | | These methods are not supposed to be used anymore, they are not actively maintained and may hence contain odd bugs. Fixes !49
* | Merge branch 'trivial-epipe-fix' into 'master'Julian Andres Klode2019-01-291-1/+1
|\ \ | | | | | | | | | | | | private-json-hooks.cc: deal with EPIPE See merge request apt-team/apt!47
| * | private-json-hooks.cc: deal with EPIPEMichael Vogt2019-01-291-1/+1
|/ / | | | | | | | | | | | | | | | | | | | | While running our CI we noticed that sometimes we see an error from the new json hooks code. The error message is: ``` E: Could not read response to hello message from hook [ ! -f /usr/bin/snap ] || /usr/bin/snap advise-snap --from-apt 2>/dev/null || true: Broken pipe ``` when purging the snapd package which provides the hook. This indicates that we should probably also consider EPIPE not an error (just like we do for ECONNRESET). This PR does exactly this.
* | Merge branch 'apt-reinstall' into 'master'Julian Andres Klode2019-01-276-5/+13
|\ \ | |/ |/| | | | | Add a "reinstall" command as an alias for "install --reinstall". See merge request apt-team/apt!46
| * Add a "reinstall" command as an alias for "install --reinstall".Josh Triplett2019-01-276-5/+13
|/ | | | aptitude has a similar "reinstall" command for precedent.
* Release 1.8.0~beta11.8.0_beta1Julian Andres Klode2019-01-2358-184/+1123
|
* Merge tag '1.8.0_alpha3.1'Julian Andres Klode2019-01-225-6/+13
|\ | | | | | | apt Debian release 1.8.0~alpha3.1
| * Release 1.8.0~alpha3.11.8.0_alpha3.1Julian Andres Klode2019-01-225-6/+13
| |
| * SECURITY UPDATE: content injection in http method (CVE-2019-3462)Julian Andres Klode2019-01-222-0/+72
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a security issue that can be exploited to inject arbritrary debs or other files into a signed repository as followed: (1) Server sends a redirect to somewhere%0a<headers for the apt method> (where %0a is \n encoded) (2) apt method decodes the redirect (because the method encodes the URLs before sending them out), writting something like somewhere\n <headers> into its output (3) apt then uses the headers injected for validation purposes. Regression-Of: c34ea12ad509cb34c954ed574a301c3cbede55ec LP: #1812353 (cherry picked from commit 5eb01ec13f3ede4bae5e60eb16bd8cffb7c03e1b)
* | Merge branch 'pu/release-preparations'Julian Andres Klode2019-01-223-8/+8
|\ \
| * | doc/apt-verbatim.ent: Debian buster is stableJulian Andres Klode2019-01-221-4/+4
| | | | | | | | | | | | | | | Move everything up one "old", and change testing to be bullseye.
| * | CI: Use debian:buster as test base imageJulian Andres Klode2019-01-222-3/+3
| | | | | | | | | | | | | | | | | | This prepares us for the upcoming buster release, as buster is the main release series for this series (the other being Ubuntu disco).
| * | doc/apt-verbatim.ent: Point ubuntu-codename to discoJulian Andres Klode2019-01-221-1/+1
| | | | | | | | | | | | LP: #1812696
* | | debian/control: Drop libcurl4-gnutls-dev build dependencyJulian Andres Klode2019-01-221-1/+0
| | | | | | | | | | | | Not needed since quite some time.
* | | Merge branch 'pu/gpgvsignedby' into 'master'Julian Andres Klode2019-01-224-112/+182
|\ \ \ | | | | | | | | | | | | | | | | Report keys used to sign file from gpgv method to acquire system See merge request apt-team/apt!44
| * | | Communicate back which key(s) were used for signingDavid Kalnischkies2019-01-224-43/+119
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Telling the acquire system which keys caused the gpgv method to succeed allows us for now just a casual check if the gpgv method really executed catching bugs like CVE-2018-0501, but we will make use of the information for better features in the following commits.
| * | | Refactor internal Signers information storage in gpgvDavid Kalnischkies2019-01-222-92/+86
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Having a method take a bunch of string vectors is bad style, so we change this to a wrapping struct and adapt the rest of the code brushing it up slightly in the process, which results even in a slightly "better" debug output, no practical change otherwise. Gbp-Dch: Ignore
* / / SECURITY UPDATE: content injection in http method (CVE-2019-3462)Julian Andres Klode2019-01-222-0/+72
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a security issue that can be exploited to inject arbritrary debs or other files into a signed repository as followed: (1) Server sends a redirect to somewhere%0a<headers for the apt method> (where %0a is \n encoded) (2) apt method decodes the redirect (because the method encodes the URLs before sending them out), writting something like somewhere\n <headers> into its output (3) apt then uses the headers injected for validation purposes. Regression-Of: c34ea12ad509cb34c954ed574a301c3cbede55ec LP: #1812353
* | bash completion: add keysVasya Novikov2019-01-221-0/+2
| |
* | Merge branch 'patch-1' of github.com:techtonik/aptJulian Andres Klode2019-01-221-9/+10
|\ \
| * | README.md: Document that apt is also includedanatoly techtonik2018-11-211-9/+10
| | |
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2024-11-01 15:28:56 +0000