summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Release 2.3.32.3.3Julian Andres Klode2021-04-295-6/+24
|
* Temporarily Revert "2.3-only: Warn that the 0.1 protocol is deprecated"Julian Andres Klode2021-04-292-12/+7
| | | | This reverts commit 64127478630b676838735b509fec5cdfa36874c8.
* Merge branch 'BrianMurray-main-patch-26842' into 'main'Julian Andres Klode2021-04-291-1/+1
|\ | | | | | | | | Fix a typo in json-hooks-protocol.md See merge request apt-team/apt!173
| * Fix a typo in json-hooks-protocol.mdBrian Murray2021-04-281-1/+1
| |
* | Merge branch 'pu/upgradecounter' into 'main'Julian Andres Klode2021-04-299-42/+108
|\ \ | | | | | | | | | | | | Count uninstallable packages in "not upgraded" See merge request apt-team/apt!169
| * | Count uninstallable packages in "not upgraded"David Kalnischkies2021-04-259-42/+108
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a first step of the solver can figure out that a package is uninstallable it might reset the candidate so that later steps are prevented from exploring this dead end. While that helps the resolver it can confuse the display of the found solution as this will include an incorrect count of packages not upgraded in this solution. It was possible before, but happens a fair bit more with the April/May resolver changes last year so finally doing proper counting is a good idea. Sadly this is a bit harder than just getting the number first and than subtracting the packages we upgraded from it as the user can influence candidates via the command line and a package which could be upgraded, but is removed instead shouldn't count as not upgraded as we clearly did something with it. So we keep a list of packages instead of a number which also help in the upgrade cmds as those want to show the list. Closes: #981535
* | Merge branch 'pu/autoremove' into 'main'Julian Andres Klode2021-04-2914-94/+288
|\ \ | | | | | | | | | | | | Mark only provides from protected versioned kernel packages See merge request apt-team/apt!168
| * | Store versioned kernel package detectors in d-pointerDavid Kalnischkies2021-04-261-8/+8
| | | | | | | | | | | | | | | | | | | | | They are kinda costly, so it makes more sense to keep them around in private storage rather than generate them all the time in the MarkPackage method. We do keep them lazy through as we have that implemented already.
| * | Call MarkAndSweep only manually in apt-get for autoremoveDavid Kalnischkies2021-04-2612-45/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An interactive tool like aptitude needs these flags current far more often than we do as a user can see them in apt only in one very well defined place – the autoremove display block – so we don't need to run it up to four times while a normal "apt install" is processed as that is just busywork. The effect on runtime is minimal, as a single run doesn't take too long anyhow, but it cuts down tremendously on debug output at the expense of requiring some manual handholding. This is opt-in so that aptitude doesn't need to change nor do we need to change our own tools like "apt list" where it is working correctly as intended. A special flag and co is needed as we want to prevent the ActionGroup inside pkgDepCache::Init to be inhibited already so we need to insert ourselves while the DepCache is still in the process of being built. This is also the reason why the debug output in some tests changed to all unmarked, but that is fine as the marking could have been already obsoleted by the actions taken, just inhibited by a proper action group.
| * | Reexplore providers of marked packages if some didn't satisfy beforeDavid Kalnischkies2021-04-264-81/+117
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The autoremove algorithm would mark a package previously after exploring it once, but it could have been that it ignored some providers due to them not satisfying the (versioned) dependency. A later dependency which they might satisfy would encounter the package as already marked and hence doesn't explore the providers anymore leaving us with internal errors (as in the contrived new testcase). This is resolved by introducing a new flag denoting if we explored every provider already and only skip exploring if that is true, which sounds bad but is really not such a common occurrence that it seems noticeable in practice. It also helps us marking virtual packages as explored now which would previously be tried each time they are encountered mostly hiding this problem for the (far more common) fully virtual package.
| * | Mark only provides from protected versioned kernel packagesDavid Kalnischkies2021-04-252-26/+161
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An out-of-tree kernel module which doesn't see many new versions can pile up a considerable amount of packages if it is depended on via another packages (e.g.: v4l2loopback-utils recommends v4l2loopback-modules) which in turn can prevent the old kernels from being removed if they happen to have a dependency on the images. To prevent this we check if a provider is a versioned kernel package (like an out-of-tree module) and if so check if that module package is part of the protected kernel set – if not it is probably good to go. We only do this if at least one provider is from a protected kernel though so that the dependency remains satisfied (this can happen e.g. if the module is currently not buildable against a protected kernel).
* | Merge branch 'pu/commasallover' into 'main'Julian Andres Klode2021-04-292-11/+13
|\ \ | |/ |/| | | | | Allow superfluous commas in build-dependency lines See merge request apt-team/apt!167
| * Allow superfluous commas in build-dependency linesDavid Kalnischkies2021-04-252-4/+10
| | | | | | | | | | | | | | | | This code can interact with handwritten files who can have unneeded commas for writing easy. As dpkg allows it, we should do as well. Reported-By: Arnaud Ferraris <arnaud.ferraris@gmail.com> References: https://lists.debian.org/debian-devel/2021/03/msg00101.html
| * Streamline or-group closing after other arch-specific packageDavid Kalnischkies2021-04-251-7/+3
|/ | | | | | | | The comment and code are a bit too roundabout about what they actually try to do, so lets just set that straight as this is really just about a very specific case and doesn't deserve a general resetting. Gbp-Dch: Ignore
* Release 2.3.22.3.2Julian Andres Klode2021-04-235-6/+33
|
* doc: Single-line JSON encoding is still mandatoryJulian Andres Klode2021-04-231-2/+2
| | | | Gbp-Dch: ignore
* Support deconfiguring Essential packagesJulian Andres Klode2021-04-232-27/+34
| | | | | | | | | dpkg 1.20.8 also made --force-remove-essential optional for deconfiguring essential packages, so let's do this. Also extend the test case to make sure we actuall pass auto-deconfigure and do not make any --remove calls, or pass --force-remove to dpkg.
* test/json: Make the test hook more reliableJulian Andres Klode2021-04-231-4/+11
| | | | | | Ugh, this was super flaky under -j 16 and -j 4, each behaving in slightly different ways. This seems to be stable now. No real bug though, all behaviors were OK.
* Avoid infinite loop on EOF on media change promptJulian Andres Klode2021-04-231-1/+3
| | | | | | The code missed a break, so it was looping infinitely because the while loop condition only checked for '\n' and '\r', but not end of file.
* Merge branch 'pu/json-hooks-21.04' into 'main'Julian Andres Klode2021-04-236-57/+301
|\ | | | | | | | | JSON Hooks 0.2 See merge request apt-team/apt!166
| * 2.3-only: Warn that the 0.1 protocol is deprecatedJulian Andres Klode2021-04-232-7/+12
| |
| * json: Hook protocol 0.2 (added upgrade,downgrade,reinstall modes)Julian Andres Klode2021-04-233-41/+144
| | | | | | | | | | | | | | | | | | Hook protocol 0.2 makes the new fields we added mandatory, and replaces `install` mode with `upgrade`, `downgrade`, `reinstall` where appropriate. Hook negotiation is hacky, but it's the best we can do for now. Users are advised to upgrade to 0.2
| * json: Add `package-list` and `statistics` install hooksJulian Andres Klode2021-04-236-12/+52
| | | | | | | | This enables hooks to output additional information.
| * upgrade: Add JSON hook support (AptCli::Hooks::Upgrade)Julian Andres Klode2021-04-232-7/+54
| |
| * json: Add origins fields to versionJulian Andres Klode2021-04-233-6/+55
| | | | | | | | | | | | Provide access to the origins of a package, such that tools can display information about them; for example, you can write a hook counting security upgrades.
* | Merge branch 'pu/json-hooks-21.04-bugfixes' into 'main'Julian Andres Klode2021-04-233-4/+102
|\| | | | | | | | | Bug fixes for JSON hooks See merge request apt-team/apt!165
| * test: Set -e in our test hookJulian Andres Klode2021-04-231-0/+1
| | | | | | | | Gbp-Dch: ignore
| * json: Flush standard file descriptors before calling hooksJulian Andres Klode2021-04-231-0/+8
| | | | | | | | This ensures messages are displayed in the correct order.
| * json: Encode NULL strings as nullJulian Andres Klode2021-04-232-1/+12
| | | | | | | | This is the only nullable thing we have here.
| * json: Actually pop statesJulian Andres Klode2021-04-232-0/+17
| | | | | | | | | | | | | | | | | | | | | | The JSON encoder only looked at the top state, but did not pop it, so if we nested objects, we got stuck in whatever the last state we pushed aside was, so in our example, we wrongly get a comma inserted _after_ key "b": {"a":[{}], "b":,[{}] }
| * json: Escape strings using \u escape sequences, add testJulian Andres Klode2021-04-232-4/+65
|/ | | | | | | | This allows us to correctly encode strings containing quotation marks, escape characters and control characters. The test case is a bit nasty because it embeds private-cachefile.cc for linkage reasons.
* Do not pass --force-remove-protected with --auto-deconfigureJulian Andres Klode2021-04-211-3/+0
| | | | dpkg 1.20.8 no longer requires this.
* Require dpkg >= 1.20.8Julian Andres Klode2021-04-212-3/+3
| | | | | | We use a Breaks for the binary package instead of adding a versioned depends, as Breaks will cause apt solver to upgrade dpkg, while depends would make apt try to remove apt as first choice.
* Merge branch 'pu/retry-3-times' into 'main'Julian Andres Klode2021-04-152-1/+10
|\ | | | | | | | | Automatically retry failed downloads 3 times See merge request apt-team/apt!164
| * Automatically retry failed downloads 3 timesJulian Andres Klode2021-04-152-1/+10
|/ | | | | | | | | Enable the Acquire::Retries option by default, set to 3. This will help with slightly unreliable networking; future work is needed for adding backoff and SRV/IP rotation. LP: #1876035 Gbp-Dch: full
* Remove inversed comment for AllowUnsizedPackagesJulian Andres Klode2021-04-131-1/+1
| | | | It defaults to false, like the other options there do.
* Release 2.3.12.3.1Julian Andres Klode2021-04-135-6/+27
|
* debian/gbp.conf: HEAD branch is main nowJulian Andres Klode2021-04-131-1/+1
|
* Merge branch 'pu/unsized-packages' into 'main'Julian Andres Klode2021-04-135-0/+59
|\ | | | | | | | | Fix downloads of unsized files that are largest in pipeline See merge request apt-team/apt!161
| * Error on packages without a Size field (option Acquire::AllowUnsizedPackages)Julian Andres Klode2021-04-134-0/+17
| | | | | | | | | | | | | | | | | | Repositories without Size information for packages are not proper and need fixing. This ensures people see an error in CI, and get notifications and hence the ability to fix it. It can be turned off by setting Acquire::AllowUnsizedPackages to true.
| * Fix downloads of unsized files that are largest in pipelineJulian Andres Klode2021-04-132-0/+42
| | | | | | | | | | | | | | | | | | The maximum request size is accidentally set to any sized file, so if an unsized file is present, and it turns out to be larger than the maximum size we set, we'd error out when checking if its size is smaller than the maximum request size. LP: #1921626
* | Merge branch 'main' into 'main'Julian Andres Klode2021-04-132-0/+18
|\ \ | |/ |/| | | | | | | | | add vendor information for Procursus. https://github.com/ProcursusTeam/Procursus is a project to get an updated \*nix environment on Darwin platforms such as iOS and x86_64/arm64 macOS. See merge request apt-team/apt!163
| * add vendor information for ProcursusCameron Katri2021-04-132-0/+18
| |
* | Merge branch 'cleanup/dpkgcallbuild' into 'main'Julian Andres Klode2021-04-131-115/+114
|\ \ | |/ |/| | | | | Replace macro and manual management with lambda and RAII See merge request apt-team/apt!160
| * Merge the three RAII vectors managing args lifetimeDavid Kalnischkies2021-03-091-90/+108
| | | | | | | | | | | | | | | | Having three different vectors littered over the method to manage various parts of the lifetime of the argument vector we are creating is a bit dangerous as it means a simple code change could result in a desync of these three, so by moving the functionality of them all into a wrapper class should prevent us from making such mistakes.
| * Handle multi-arch pkgnames for dpkg call via RAIIDavid Kalnischkies2021-03-091-11/+5
| |
| * Use RAII to clean up tmp dir for dpkg recursive installDavid Kalnischkies2021-03-091-10/+7
| | | | | | | | One less thing to remember to do in all branches.
| * Replace multi-statement macro with lambdaDavid Kalnischkies2021-03-091-42/+32
| | | | | | | | | | | | It is easy to make mistakes while dealing with such macros regardless of how much you guard them, so just using a lambda removes a lot of concerns here basically for free.
* | Check for and discard expected warning from MaybeAddAuthJulian Andres Klode2021-03-311-0/+5
| | | | | | | | | | | | | | | | | | MaybeAddAuth() here tells us that it refused to use the credentials for an http source; but that caused the test suite to fail at a later stage because we checked if there were any errors/warning. Strangely, this is only triggered with LTO enabled. Actually check that the warning is being set and then reject it.
* | Harden test for no new acquires after transaction abortHEADmasterDavid Kalnischkies2021-03-111-9/+3
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | If a transaction is doomed we want to gracefully shutdown our zoo of worker processes. As explained in the referenced commit we do this by stopping the main process from handing out new work and ignoring the replies it gets from the workers, so that they eventually run out of work. We tested this previously by checking if a rred worker was given work items at all, but depending on how lucky the stars of the machine working on this are the worker would have already gotten work before the transaction was aborted – so we tried this 25 times a row (f35601e5d2). No machine can be this lucky, right? Turns out the autopkgtest armhf machine is very lucky. I feel a bit sorry for feeding grep such a long "line" to work with, but it seems to work out. Porterbox amdahl (who is considerably less lucky; had to turn down to 1 try to get it to fail sometimes) is now happily running the test in an endless loop. Of course, I could have broken the test now, but its still a rather generic grep (in some ways more generic even) and the main part of the testcase – the update process finishes and fails – is untouched. References: 38f8704e419ed93f433129e20df5611df6652620 Closes: #984966