summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Release 2.9.162.9.16Julian Andres Klode2024-11-295-6/+14
|
* Avoid extension check for .gpgJulian Andres Klode2024-11-291-12/+12
| | | | | | | | | | | | We only ever documented .gpg and .asc and have ensured that only such files exist in the keyring, but people can set the Signed-By option to keys with any random extension, as that was not validated before by apt-key. This doesn't change the behavior for trusted.gpg.d: We filter the directory listing and only look at .gpg and .asc files. Closes: #1088656
* Release 2.9.152.9.15Julian Andres Klode2024-11-286-6/+38
|
* Merge branch 'prep-bye-apt-key' into 'main'Julian Andres Klode2024-11-2811-90/+313
|\ | | | | | | | | Stop using apt-key See merge request apt-team/apt!407
| * Detect working gpgv using gpgv --dump-optionsJulian Andres Klode2024-11-283-43/+71
| | | | | | | | | | | | | | | | | | | | | | | | This gains us support for not using an absolute path, which is nice, and we can now cache the invocation across fork() in the method. Still keep preferring absolute paths, this avoids execvp() having to iterate the path and reduces bug potential with custom gpgv in /usr/local. Fix the last entry in the list of gpgvs to say gpgv1
| * fileutl: Use execvp() in Popen() instead of execv()Julian Andres Klode2024-11-282-2/+2
| |
| * gpgv: Add direct support for --assert-pubkey-algoJulian Andres Klode2024-11-281-0/+23
| |
| * Directly call gpgv instead of apt-keyJulian Andres Klode2024-11-283-46/+40
| |
| * gpgv: Verify keyrings and dearmor outside apt-keyJulian Andres Klode2024-11-281-5/+54
| |
| * strutl: Add Base64DecodeJulian Andres Klode2024-11-283-1/+88
| | | | | | | | | | | | | | | | Lifted from the dpkg mtree code that mjg59 submitted in https://lists.debian.org/debian-dpkg/2018/05/msg00005.html Which as dpkg is GPL-2.0+ also is GPL-2.0+
| * gpgv: Use std::string instead of const char *Julian Andres Klode2024-11-281-39/+33
| | | | | | | | | | This is a bit more overhead here, but if we need to build temporary strings this is a lot cleaner.
| * gpgv: Explictly pass all the keyrings to gpgv from aptJulian Andres Klode2024-11-281-3/+40
| |
| * apt-key: Temporarily accept 'pub' as an extension for binary gpg keysJulian Andres Klode2024-11-281-1/+1
| |
| * apt-key: Only cat supported keyrings into the merged oneJulian Andres Klode2024-11-281-1/+3
| |
| * Do not implode key file name vector for calling gpgvJulian Andres Klode2024-11-283-4/+11
| | | | | | | | Converting it to a comma-separated string and back loses precision.
| * gpgv: Generalize apt_error to apt_msg(), add apt_warning()Julian Andres Klode2024-11-281-3/+5
|/ | | | This allows printing warnings and errors,
* tagfile: Avoid uninitialized variable warningsJulian Andres Klode2024-11-281-9/+9
|
* Fix accidental ABI break in debListParser::ParseDependsJulian Andres Klode2024-11-282-0/+25
| | | | | The version that accepted APT::StringView was marked public.
* test-apt-cdrom: Hande assert-pubkey-algo like other gpgv messagesJulian Andres Klode2024-11-241-18/+2
| | | | | | Not all gpgv implementations support that flag and we no longer default to gpgv; so we may not have support for it, so let's just handle it like other gpgv messages.
* Merge branch 'fix/collect-ignored-errors' into 'main'Julian Andres Klode2024-11-224-19/+86
|\ | | | | | | | | Collect unprinted Ign errors for display in Err output See merge request apt-team/apt!405
| * Collect unprinted Ign errors for display in Err outputDavid Kalnischkies2024-11-224-19/+86
|/ | | | | | | | | | | | | | | | Instead of deciding if the first or the last error in a retry chain is the best one to display if the entire chain fails in the end we teach our progress reporting to collect the ignored errors (if it hasn't shown them) and print them all together in the Err line. We de-duplicate the collection which makes it harder to match the Ign line with the error messages, but for these cases its probably better to enable direct display of the text anyhow – and repeating the same message multiple times is boring and probably not that helpful for a user wanting to know why all the downloads failed even they asked apt to retry 429 times… References: 841243df877b39dfcb907a7fab9c4e8b4f65d715
* Release 2.9.142.9.14Julian Andres Klode2024-11-225-6/+45
| | | | | Oh well I accidentally committed everything from my work email today but I'm off today ...
* apt-key: Prefer gpgv-sq if it existsJulian Andres Klode2024-11-221-0/+1
| | | | | This allows you to test out gpgv-sq by just installing it, which is nice.
* Merge branch 'fix/partialfilemirror' into 'main'Julian Andres Klode2024-11-2217-286/+602
|\ | | | | | | | | Support uncompressed indexes from partial file:/ mirrors See merge request apt-team/apt!235
| * Look at non by-hash paths in copy and file methodsDavid Kalnischkies2024-11-228-102/+143
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ideally copy and file mirrors would support by-hash as well, but its harder to setup and maintain especially if you want to cache an online mirror who has by-hash enabled. We can avoid unneeded roundtrips (in the best case) and entire cache misses (in the usual worst case) by "just" telling methods that the URI we passed it has the requested file perhaps also in other paths. This is done in pseudo-relative paths as we would otherwise need to teach redirection code to rewrite those URIs as well. A method like http can easily ignore this value and await explicit instructions to look at that file, but inspecting the path in local sources via file or copy is (comparatively) free, so we just do it immediately. If that ends up being the wrong version of the file as by-hash would have protected us from we are in this feature branch now falling back to other mirrors which are like the ones online and in support of by-hash.
| * Allow HashSum mismatches to fallback to other mirrorsDavid Kalnischkies2024-11-223-48/+94
| | | | | | | | | | | | | | | | | | | | | | Perhaps a common error in the past nowadays thanks to by-hash we rarely get mismatches due to our calling behaviour and more because the mirror is genuinely bad especially if this mirror didn't work with by-hash. Using our "normal" error handling allows falling back to other mirrors which hopefully do support by-hash and/or are not broken on a filesystem level making us more resistent to the occasional bad apple in a wild mirror forest.
| * Never consider file/copy/cdrom sources bad sites due to errorsDavid Kalnischkies2024-11-223-3/+14
| | | | | | | | | | | | | | | | | | | | | | As the hostname for them is likely empty (for absolute or . or .. for relative paths) considering one a bad site causes all of the sites from this scheme to be considered bad. In a perfect world, we would figure out a good site-path to use for these sources, but as they are local sources which means we don't have to perform costly requests to the internet we just let them happen instead for now.
| * Clear previous ignored errors before processing acquire item againDavid Kalnischkies2024-11-221-0/+4
| | | | | | | | | | | | | | | | If an item failed previously, but that failure is ignored and a retry is triggered we might end up in a situation in which it is failing yet again for perhaps totally different reasons, but the error message displayed is the one we have shown (or, because it was ignored likely hidden) before which can be rather confusing in debugging.
| * Do not change UsedMirror on local copy of InReleaseDavid Kalnischkies2024-11-221-1/+1
| | | | | | | | | | | | | | | | While we pick most files from the file:/ mirror directly, we explicitly bring in the InRelease file with a copy one if-clause later, which causes this code to be run again and ends up considering the copy:/ the mirror the file was picked up from, which works, but isn't what we had signed up for.
| * Do not assume mirror-URIs end in a filename causing a hangDavid Kalnischkies2024-11-222-3/+23
| | | | | | | | | | | | | | In practice most of them will, but making the acquire process hang in response if they don't seems like an overly excessive response if we can just support it gracefully to reply with an error (or actually succeed in the unlikely event this URI is actually correct).
| * Allow AutoDetectProxy to work with more than just http(s)David Kalnischkies2024-11-225-39/+93
| | | | | | | | | | | | | | | | It is a bit unfair for third-party methods wrapping e.g. http to not have access to such tools, same for our old ftp and e.g. our tor even if in practice this isn't used much even for http. At least that is one less FIXME in the code.
| * Rewrite hidden config option checker for more patternsDavid Kalnischkies2024-11-223-54/+112
| | | | | | | | | | | | | | | | | | | | | | | | | | The previous version allowed only foo::*::bar as a pattern, now you can have as many starred parts as you want allowing for a finer control instead of hardcoding specific common star-values or giving up with **. It also adds a new INVALID type for an option to mark options which should not be used, but are covered by a pattern which would normally allow it. Our tests are more or less the only users of this hidden feature making this change not very risky even through it has no dedicated test itself.
| * Alternatively calculate alternative file hashes in file methodDavid Kalnischkies2024-11-222-1/+4
| | | | | | | | | | | | | | If we do not have the requested file we haven't calculated the hashes for it either and it is likely that the alternative file will be used, so to save the main thread from being busy with calculating hashes we do the calculation here in the method.
| * Show hashes calculated by main thread in error messagesDavid Kalnischkies2024-11-223-1/+26
| | | | | | | | | | | | | | | | | | | | | | The main thread calculates the hash sums if the method hasn't to be able to verify the files, but while a failure is detected and reported, the error messages did not include the hash sums which looks at least puzzling. So to have a complete error message we ensure that the hashes we calculated are appended to the message from the method so that it looks for the higher level code as if the method had calculated the hashes.
| * Support uncompressed indexes from partial file:/ mirrorsDavid Kalnischkies2024-11-224-38/+92
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a file:/ mirror does not contain the requested compressed file, but the uncompressed variant of that file the method will sent us a fitting Done message with data only about the Alt-Filename, but the central hash verification code in the acquire system does not expect that looking for the non-existent compressed file to compare its hashes with the expected result – which fails (if we are verifying at least). That file:/ as well as the item code deals with this suggests that this feature was broken by 448c38bdcd72b52f11ec5f326f822cf57653f81c, but I couldn't (easily) compile that to verify, so this is only a guess. Supporting this allows using index files from /var/lib/apt/lists – which are likely uncompressed or can at least made so easily – to construct a file:/ mirror.
* | Merge branch 'test-gpgv-sq' into 'main'Julian Andres Klode2024-11-224-8/+44
|\ \ | | | | | | | | | | | | Test gpgv-sq See merge request apt-team/apt!403
| * | test: Ensure we test both gpgv-g10code and gpgv-sqJulian Andres Klode2024-11-223-6/+17
| | |
| * | test: Accept empty output from gpgv/apt-keyJulian Andres Klode2024-11-221-0/+3
| | | | | | | | | | | | | | | Our internal code always generates ENODATA for empty output and this is checked by the previous commit, so this is entirely safe.
| * | test-releasefile-verification: Test empty/invalid signaturesJulian Andres Klode2024-11-221-0/+22
| | |
| * | Accept BADSIG instead of EXPSIG for expired signaturesJulian Andres Klode2024-11-221-1/+1
| | | | | | | | | | | | Sequioa emits KEYEXPIRED + BADSIG instead of EXPSIG + VALIDSIG
| * | test-releasefile-verification: Fix signature timeJulian Andres Klode2024-11-221-1/+1
| | | | | | | | | | | | | | | | | | The key was only generated in 2010 and only bound in 2016, so we cannot have signatures from before then, so update the key accordingly, and change the default expiry to 2017.
* | | Merge branch 'fix/warnings' into 'main'Julian Andres Klode2024-11-2216-25/+30
|\ \ \ | |_|/ |/| | | | | | | | Fix a small bunch of compile-time warnings See merge request apt-team/apt!404
| * | Tag hidden acquire classes as final for devirtualizationDavid Kalnischkies2024-11-229-17/+17
| | | | | | | | | | | | | | | | | | | | | gcc reports `warning: Declaring type ‘class X’ final would enable devirtualization of Y calls [-Wsuggest-final-types]`. Not that this would massively improve performance, but it shouldn't hurt telling the compiler what is obvious for a human.
| * | Avoid unnormalized paths for CMake install destinationsDavid Kalnischkies2024-11-223-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CMake 3.31 is very noisy about our manpage (and to a lesser extend documentation in general) building as we used "//" and "/../" there. `cmake --help-policy CMP0177` documents the warning, so we could just decide on a value and deal with it, but given our usage is not really needed and rather trivial to change lets not pick a value and instead use a normalized path so we don't use different code paths in CMake depending on which CMake version we happen to be build with.
| * | Add a virtual destructor to private CacheSet MatcherDavid Kalnischkies2024-11-221-0/+1
| | | | | | | | | | | | | | | This silences the warning: | warning: ‘class Matcher’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
| * | Fix expired std::string usage in APT::StringView testcaseDavid Kalnischkies2024-11-221-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | The anonymous std::string we were using here to create the view expires after the construction of the view and so the gcc warning | warning: ‘<anonymous>’ may be used uninitialized [-Wmaybe-uninitialized] is correct in that the memory we are pointing to is potentially overridden/reused already, if a bit roundabout in saying so.
| * | Acknowledge non-erase usage of remove_if for volatile sourcesDavid Kalnischkies2024-11-222-2/+2
|/ / | | | | | | | | | | | | | | | | | | | | | | | | gcc produces a length warning starting with: | warning: ignoring return value of ‘_FIter std::remove_if(_FIter, _FIter, _Predicate) [with …]’, declared with attribute ‘nodiscard’ [-Wunused-result] which is usually correct, but in the usage here we don't want to call an erase as we operate on a c-style new[] array here which contains pointers into argv and has an explicit sentinel (nullptr) – FileSize() is based on this sentinel. Casting to void silences the warning as is standard practice and hopefully indicates better that this is intended than ignoring the warning for the casual on-looker.
* | Italian program translation updateLuca Vercelli2024-11-221-312/+301
| | | | | | | | Closes: #1081992
* | Russian program translation updateАлексей Шилин2024-11-221-74/+64
| | | | | | | | Closes: #1087804
* | Dutch manpages translation updateFrans Spiesschaert2024-11-221-23/+10
| | | | | | | | Closes: #1087461
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2026-10-14 10:16:04 +0000