summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix typos encountered while updating de translationChris Leick2018-10-3016-49/+46
|
* German manpage translation updateChris Leick2018-10-302-900/+965
| | | | Reviewed-By: Helge Kreutzmann <debian@helgefjell.de>
* Dutch manpage translation updateFrans Spiesschaert2018-10-302-31/+93
| | | | Closes: #912022
* Dutch program translation updateFrans Spiesschaert2018-10-302-13/+11
| | | | Closes: #912021
* Break pre-gcc8 aptitude and aptJulian Andres Klode2018-10-221-1/+1
| | | | | | | | | | | | | gcc 8 broke the ABI again. After they decided to switch mangling of ABI tags in return values from: U URI::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >[abi:cxx11]() to: U URI::operator std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >() in gcc 7, they now removed the legacy symbol in gcc 8, causing us to break our ABI in turn for that one operator. We need more responsible gcc developers. Closes: #911090
* NeverAutoRemove kernel meta packagesJulian Andres Klode2018-10-221-0/+2
| | | | | | | This gives more protection for people where kernel metapackages are accidentally removed. LP: #1787460
* Merge branch 'feature/subkeys' into 'master'Julian Andres Klode2018-10-1413-166/+383
|\ | | | | | | | | Support subkeys and multiple keyrings in Signed-By options See merge request apt-team/apt!27
| * Support multiple keyrings in sources.list Signed-ByDavid Kalnischkies2018-09-117-106/+194
| | | | | | | | | | | | | | A user can specify multiple fingerprints for a while now, so its seems counter-intuitive to support only one keyring, especially if this isn't really checked or enforced and while unlikely mixtures of both should work properly, too, instead of a kinda random behaviour.
| * Support subkeys properly in Signed-By optionsDavid Kalnischkies2018-09-119-61/+190
| | | | | | | | | | | | | | | | If we limit a file to be signed by a certain key it should usually accept also being signed by any of this keys subkeys instead of requiring each subkey to be listed explicitly. If the later is really wanted we support now also the same syntax as gpg does with appending an exclamation mark at the end of the fingerprint to force no mapping.
* | Merge branch 'master' into 'master'Julian Andres Klode2018-10-141-1/+6
|\ \ | | | | | | | | | | | | apt-get.8: mention --only-source in 'source' and 'build-dep' description See merge request apt-team/apt!24
| * | clarificationDamyan Ivanov2018-09-121-3/+4
| | | | | | | | | | | | | | | do not suggest that 'source' and 'build-dep' arguments are binary package names only
| * | apt-get.8: mention --only-source in 'source' and 'build-dep' descriptionDamyan Ivanov2018-08-091-1/+5
| | |
* | | Merge branch 'master' into 'master'Julian Andres Klode2018-10-144-5/+5
|\ \ \ | | | | | | | | | | | | | | | | Default to https: scheme for fetching Debian changelogs See merge request apt-team/apt!30
| * | | Default to https: scheme for fetching Debian changelogsBen Hutchings2018-10-134-5/+5
|/ / / | | | | | | | | | Closes: #910941
* | | Release 1.7.01.7.0Julian Andres Klode2018-10-0723-38/+58
| | |
* | | prepare-release: Fix last-modification detection for manpagesJulian Andres Klode2018-10-071-2/+3
| | | | | | | | | | | | | | | Pass -i to git log, so "Release foo" is detected as well, not just "release foo", and also handle the rename of Git-Dch to Gbp-Dch.
* | | Set DPKG_FRONTEND_LOCKED when running {pre,post}-invoke scriptsJulian Andres Klode2018-10-053-0/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | Some post-invoke scripts install packages, which fails because the environment variable is not set. This sets the variable for all three kinds of scripts {pre,post-}invoke and pre-install-pkgs, but we will only allow post-invoke at a later time. Gbp-Dch: full
* | | apt-mark: showhold: typo-fix (package -> packages)Muhamed Huseinbašić2018-10-0245-45/+45
| | | | | | | | | | | | | | | | | | See merge request apt-team/apt!29 [jak@d.o: Also adjust translations, provide better subject]
* | | Show APT::Compressor example in apt.conf(5)David Kalnischkies2018-09-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Including a block-element like informalexample in a para is legal, but the documentation of the para tag hints that some processing systems may have difficulties handling this – so lets just move it out of the block and be happy as it is (again?) displayed. Closes: #909712
* | | pkgCacheFile: Only unlock in destructor if locked beforeJulian Andres Klode2018-09-242-5/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | pkgCacheFile's destructor unlocks the system, which is confusing if you did not open the cachefile with WithLock set. Create a private data instance that holds the value of WithLock. This regression was introduced in commit b2e465d6d32d2dc884f58b94acb7e35f671a87fe: Join with aliencode Author: jgg Date: 2001-02-20 07:03:16 GMT Join with aliencode by replacing a "Lock" member that was only initialized when the lock was taken by calls to Lock, UnLock; with the latter also taking place if the former did not occur. Regression-Of: b2e465d6d32d2dc884f58b94acb7e35f671a87fe LP: #1794053
* | | Fix calculation of elapsed usec in downloadsJulian Andres Klode2018-09-241-2/+2
| | | | | | | | | | | | | | | | | | A recent change to use chronos inadvertently replaced the difference of new usec - old usec with new sec - old usec, which is obviously wrong.
* | | Release 1.7.0~rc21.7.0_rc2Julian Andres Klode2018-09-209-10/+18
| | |
* | | Deal with descriptions embedded in displayed record correctlyDavid Kalnischkies2018-09-202-13/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The implementation of "apt-cache show" (not "apt show") incorrectly resets the currently used parser if the record itself and the description to show come from the same file (as it is the case if no Translation-* files are available e.g. after debootstrap). The code is more complex than you would hope to support some rather unusual setups involving Descriptions and their translations as tested for by ./test-bug-712435-missing-descriptions as otherwise this could be a one-line change. Regression-Of: bf53f39c9a0221b670ffff74053ed36fc502d5a0 Closes: #909155
* | | Release 1.7.0~rc1 to unstable1.7.0_rc1Julian Andres Klode2018-09-1852-1151/+1081
| | |
* | | Merge branch 'pu/keep-pipelining-after-close' into 'master'Julian Andres Klode2018-09-182-6/+21
|\ \ \ | | | | | | | | | | | | | | | | http: Stop pipeline after close only if it was not filled before See merge request apt-team/apt!25
| * | | http: Stop pipeline after close only if it was not filled beforeJulian Andres Klode2018-09-182-6/+21
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is perfectly valid behavior for a server to respond with Connection: close eventually, even when pipelining. Turning off pipelining due to that is wrong. For example, some Ubuntu mirrors close the connection after 101 requests. If I have more packages to install, only the first 101 would benefit from pipelining. This commit introduces a new check to only turn of pipelining for future connections if the pipeline for this connection did not have 3 successful fetches before, that should work quite well to detect broken server/proxy combinations like in bug 832113.
* | | Merge branch 'bugfix/statusfd' into 'master'Julian Andres Klode2018-09-185-102/+135
|\ \ \ | | | | | | | | | | | | | | | | Process all of --status-fd and don't expect duplicate status msg See merge request apt-team/apt!26
| * | | Reorder progress report messagesDavid Kalnischkies2018-09-113-31/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are seeing 'processing' messages from dpkg first, so it makes sense to translate them to "Preparing" messages instead of using "Installing" and co to override these shortly after with the "Preparing" messages. The difference isn't all to visible as later messages tend to linger far longer in the display than the ealier ones, but at least in a listing it seems more logical.
| * | | Don't expect duplicated dpkg status-fd messagesDavid Kalnischkies2018-09-115-71/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The progress reporting relies on parsing the status reports of dpkg which used to repeat being in the same state multiple times in the same run, but by fixing #365921 it will stop doing so. The problem is in theory just with 'config-files' in case we do purge as this (can) do remove + purge in one step, but we remove this also for the unpack + configure combination althrough we handle these currently in two independent dpkg calls.
| * | | Process status-fd completely before finishing dpkg callDavid Kalnischkies2018-09-111-15/+36
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Exiting the processing loop as soon as the dpkg process finishes might leave status-fd lines unprocessed which wasn't much of a problem in the past as the progress would just be slightly off, but now that we us the information also for skipping already done tasks and generate warnings if we didn't see all expected messages we should make sure we seem them all. We still need to exit "early" if dpkg exited unsuccessfully/crashed through as the (remaining) status lines we get could be incomplete.
* / | Show all architectures in 'apt list' outputDavid Kalnischkies2018-09-153-10/+34
|/ / | | | | | | | | | | | | | | | | The uniqueness in std::set containers is ensured by the ordering operator we provide, but it was not considering that different versions can have the same description like the different architectures for a version of a package. Closes: #908218
* | Unset more environment variables in test frameworkDavid Kalnischkies2018-09-111-2/+5
| | | | | | | | | | | | | | | | | | It is an uphill battle to "reset" the environment to a clean state without making it needlessly hard to use 'good' environment variables, so we just try a little harder here without really trying for completeness. Gbp-Dch: Ignore
* | Don't use gpg directly in apt-key testDavid Kalnischkies2018-09-101-1/+1
| | | | | | | | | | Reported-By: Guillem Jover <guillem@debian.org> Gbp-Dch: Ignore
* | Fix typos reported by codespell & spellintianDavid Kalnischkies2018-08-2912-16/+28
| | | | | | | | | | | | | | | | No user-visible change as it effects mostly code comments and not a single error message, manpage or similar. Reported-By: codespell & spellintian Gbp-Dch: Ignore
* | Don't use invalid iterator in Fallback-Of handlingDavid Kalnischkies2018-08-293-2/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | cppcheck reports: (error) Iterator 't' used after element has been erased. The loop is actually fashioned to deal with this (not in the most efficient way, but in simplest and speed isn't really a concern here) IF this codepath had a "break" at the end… so I added one. Note that the tests aren't failing before (and hopefully after) the change as the undefined behavior we encounter is too stable. Thanks: David Binderman for reporting
* | fr.po: Do not translate the apt-ftparchive commandsLaurent Bigonville2018-08-281-1/+1
| | | | | | | | Closes: #907481
* | Release 1.7.0~alpha31.7.0_alpha3Julian Andres Klode2018-08-2052-239/+913
| |
* | clear alternative URIs for mirror:// between steps (CVE-2018-0501)David Kalnischkies2018-08-203-21/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | APT in 1.6 saw me rewriting the mirror:// transport method, which works comparable to the decommissioned httpredir.d.o "just" that apt requests a mirror list and performs all the redirections internally with all the bells like parallel download and automatic fallback (more details in the apt-transport-mirror manpage included in the 1.6 release). The automatic fallback is the problem here: The intend is that if a file fails to be downloaded (e.g. because the mirror is offline, broken, out-of-sync, …) instead of erroring out the next mirror in the list is contacted for a retry of the download. Internally the acquire process of an InRelease file (works with the Release/Release.gpg pair, too) happens in steps: 1) download file and 2) verify file, both handled as URL requests passed around. Due to an oversight the fallbacks for the first step are still active for the second step, so that the successful download from another mirror stands in for the failed verification… *facepalm* Note that the attacker can not judge by the request arriving for the InRelease file if the user is using the mirror method or not. If entire traffic is observed Eve might be able to observe the request for a mirror list, but that might or might not be telling if following requests for InRelease files will be based on that list or for another sources.list entry not using mirror (Users have also the option to have the mirror list locally (via e.g. mirror+file://) instead of on a remote host). If the user isn't using mirror:// for this InRelease file apt will fail very visibly as intended. (The mirror list needs to include at least two mirrors and to work reliably the attacker needs to be able to MITM all mirrors in the list. For remotely accessed mirror lists this is no limitation as the attacker is in full control of the file in that case) Fixed by clearing the alternatives after a step completes (and moving a pimpl class further to the top to make that valid compilable code). mirror:// is at the moment the only method using this code infrastructure (for all others this set is already empty) and the only method-independent user so far is the download of deb files, but those are downloaded and verified in a single step; so there shouldn't be much opportunity for regression here even through a central code area is changed. Upgrade instructions: Given all apt-based frontends are affected, even additional restrictions like signed-by are bypassed and the attack in progress is hardly visible in the progress reporting of an update operation (the InRelease file is marked "Ign", but no fallback to "Release/Release.gpg" is happening) and leaves no trace (expect files downloaded from the attackers repository of course) the best course of action might be to change the sources.list to not use the mirror family of transports ({tor+,…}mirror{,+{http{,s},file,…}}) until a fixed version of the src:apt packages are installed. Regression-Of: 355e1aceac1dd05c4c7daf3420b09bd860fd169d, 57fa854e4cdb060e87ca265abd5a83364f9fa681 LP: #1787752
* | Update symbolsJulian Andres Klode2018-08-202-0/+19
| |
* | Report (soon) worthless keys if gpg uses fpr for GOODSIGDavid Kalnischkies2018-08-192-35/+49
| | | | | | | | | | | | | | | | | | | | gpgs DETAILS documentation file declares that GOODSIG could report keyid or fingerprint since gpg2, but for the time being it is still keyid only. Who knows if that will ever change as that feels like an interface break with dangerous security implications, but lets be better safe than sorry especially as the code dealing with signed-by keyids is prepared for this already. This code is rewritten still to have them all use the same code for this type of problem.
* | test: Supports records larger than 32kb in 'apt show'David Kalnischkies2018-08-191-0/+33
| | | | | | | | | | | | | | | | | | | | The 1.7 series rework of show started in bf53f39c9a0221b670ffff74053ed36fc502d5a0 resolved the issue already, but its always a good idea to at least bring the tests along so that we hopeful do not regress in the future with another rewrite. Tests: #905527 Gbp-Dch: Ignore
* | Simplified Chinese program translation updateBoyuan Yang2018-08-191-34/+31
| | | | | | | | | | Reviewed-by: Mo Zhou <cdluminate@gmail.com> Closes: #903695
* | aptwebserver: Prefetch compressors to avoid thread crashesDavid Kalnischkies2018-08-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | If multiple threads act on requests (like if connection comes from a webbrowser) a thread might request the supported compressors while another thread is still working on creating the list to be stored in the static cache variable. As the price to pay for atomic and co seems to high for the fringe usecase of manual usage of aptwebserver the patch just makes a call to generate the list while still single threaded. Gbp-Dch: Ignore
* | CMake: Use ${PROJECT_NAME} instead of hardcoding aptDavid Kalnischkies2018-08-141-6/+7
|/ | | | | | | Completely pointless as it makes no difference for apt, but copying the file to other projects becomes a lot easier. Gbp-Dch: Ignore
* Set DPKG_FRONTEND_LOCKED as needed when doing selection changesJulian Andres Klode2018-08-081-0/+5
| | | | | | | We forgot to set the variable for the selection changes. Let's set it for that and some other dpkg calls. Regression-Of: c2c8b4787b0882234ba2772ec7513afbf97b563a
* Merge branch 'bugfix/big-lock' into 'master'Julian Andres Klode2018-08-076-9/+93
|\ | | | | | | | | Add support for dpkg frontend lock See merge request apt-team/apt!11
| * Add support for dpkg frontend lockJulian Andres Klode2018-08-076-9/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The dpkg frontend lock is a lock dpkg tries to acquire except if the frontend already acquires it. This fixes a race condition in the install command where the dpkg lock is not held for a short period of time between different dpkg invocations. For this reason we also define an environment variable DPKG_FRONTEND_LOCKED for dpkg invocations so dpkg knows not to try to acquire the frontend lock because it's held by a parent process. We can set DPKG_FRONTEND_LOCKED only if the frontend lock really is held; that is, if our lock count is greater than 0 - otherwise an apt client not using the LockInner family of functions would run dpkg without the frontend lock set, but with DPKG_FRONTEND_LOCKED set. Such a process has a weaker guarantee: Because dpkg would not lock the frontend lock either, the process is prone to the existing races, and, more importantly, so is a new style process. Closes: #869546 [fixups: fix error messages, add public IsLocked() method, and make {Un,}LockInner return an error on !debSystem]
* | Merge branch 'master' into 'master'Julian Andres Klode2018-08-0745-62/+62
|\ \ | |/ |/| | | | | Add trailing newline to output of edit-sources. See merge request apt-team/apt!22
| * Add trailing newline to output of edit-sources.Jean-Ralph Aviles2018-06-3045-62/+62
| | | | | | | | Makes the console output cleaner.
* | Release 1.7.0~alpha21.7.0_alpha2Julian Andres Klode2018-07-099-28/+34
| |