| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |
|
| | | |
|
| |/ |
|
| |\
| |
| |
| |
| | |
Fix Phased-Update-Percentage probability mistake
See merge request apt-team/apt!560
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously a package with Phased-Update-Percentage: n would be updated
with probability (n + 1)/101 instead of n/100. For example, a package
with Phased-Update-Percentage: 0 could still be updated even though it
shouldn’t, and a package with Phased-Update-Percentage: 1 would be
installed almost twice as much as it should be. Correct the erroneous
math.
Note that libstdc++ implements std::uniform_int_distribution in such a
way that for a given seed, changing dist(0, 100) to dist(0, 99) has
the effect of decreasing each sample by 0 or 1; therefore, this patch
will not randomly trigger extra phased updates that had previously
been excluded.
Fixes: c5bc86d45e003905ef411146e66b414d26fb1ff8
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Observing a testrun carefully included:
./test-apt-get-satisfy: 101: [: unexpected operator
Yes, == is not a valid operator here, should just be =.
The result is that we unconditionally skip a single check,
hardly so much the end of the world that we need to tell
everyone as no tests were failed, but no good anyhow.
Fixes: 5e8e69cdd6b512480f3208298725e1e44c80f06e
Gbp-Dch: Ignore
|
| |
|
|
| |
Closes: #1127086
|
| |
|
|
| |
Closes: #1119827
|
| |
|
|
| |
Closes: #1120338
|
| |
|
|
| |
Closes: #1120336
|
| |\
| |
| |
| |
| | |
Document inhibitors (see Bug#112933)
See merge request apt-team/apt!558
|
| |/ |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| | |
bash-complete search patterns for more commands
See merge request apt-team/apt!543
|
| |/ |
|
| |\
| |
| |
| |
| | |
Prevent sleep while running dpkg.
See merge request apt-team/apt!554
|
| |/
|
|
|
| |
As long as we are running dpkg, keep an inhibitor that
blocks us from sleeping.
|
| |\
| |
| |
| |
| | |
debian: Trigger apt-daily on AC plug event
See merge request apt-team/apt!547
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
Because the service has ConditionACPower=true, it would be nice to try and
start it when plugging-in the AC power in case that an earlier timer trigger
was missed due to not being plugged-in.
It is not a problem that we may be invoking the service multiple times a day,
because it keeps track of its own timestamp file to run up to once every
"APT::Periodic::Update-Package-Lists" days
Related: https://launchpad.net/bugs/2089151
|
| |\
| |
| |
| |
| | |
solver3: Upgrade by source package
See merge request apt-team/apt!553
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the "APT::Get::Upgrade-By-Source-Package" option as
the classic solver does.
Here this is equally straight forward now: We enqueue optional, but
eager, clauses of the form
foo=2 -> foo-data=2
for each sibling in the source version, assuming they are currently
installed, and the selection is not the current version.
This softly enforces upgrades of already installed siblings, but
in non-strict-pinning mode it will not affect the selection of
new packages to be installed.
A more complete solution to version selection by source package
also seems feasible, where we change the "priority" of versions
in the solver dynamically - currently they are statically evaluated.
Such that, when you select foo=2, and something installs foo-data,
foo-data would be installed in version 2 even if version 3 were its
candidate.
|
| |\
| |
| |
| |
| | |
Introduce JSONL performance counter logging and constexpr-ify the solver and cache
See merge request apt-team/apt!551
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Aside from Clause, which initializes an std::vector
and an std::forward_list, which do not have constexpr
constructors in C++17, we can turn our inline functions
constexpr.
Using `constexpr` implies `inline`, so simplify that
accordingly where needed.
Adding noexcept to the function allows STL components
to utilize more optimized code paths.
Marking SameOrGroup as constexpr significantly improves
performance due to being in the hot path and it now being
inlined - removing branching by 10%.
iolveiolver
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In particular, map_pointer and iterators are now
all literal types, with most functions translated
to constexpr noexcept.
This allows them to be used in constexpr contexts
in C++17; and the compiler to generate better code
knowing they cannot throw exceptions.
This transformation is safe, because the functions
are inline.
more constexpr
|
| | |
| |
| |
| |
| | |
This reduces its memory usage by half and turns it into a
fast map - no destructors needed (and 0 initialization).
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
The for loop with if(foo) continue; return false; was highly
unusual as were the bunch of uses of `!` instead of `not`.
Gbp-dch: ignore
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were trying to compare the dependencies in the first version
with the dependencies in later version, but our loop started
at the first version as well due to an oversight in the use
of the increment operator.
Change the increment from postfix to prefix such that we start
iterating with the 2nd version in the list only.
This should yield minute performance optimizations:
before:
12: 17.80% 0.00% apt libapt-pkg.so.7.0.0 [.] EDSP::ResolveExternal(char const*, pkgDepCache&, unsigned int, OpProgress*)
14: --17.80%--EDSP::ResolveExternal(char const*, pkgDepCache&, unsigned int, OpProgress*)
20: | | |--6.34%--APT::Solver::DependencySolver::RegisterCommonDependencies(pkgCache::PkgIterator)
44: | | --0.85%--APT::Solver::DependencySolver::RegisterCommonDependencies(pkgCache::PkgIterator)
after:
12: 16.98% 0.00% apt libapt-pkg.so.7.0.0 [.] EDSP::ResolveExternal(char const*, pkgDepCache&, unsigned int, OpProgress*)
14: --16.98%--EDSP::ResolveExternal(char const*, pkgDepCache&, unsigned int, OpProgress*)
20: | | |--5.65%--APT::Solver::DependencySolver::RegisterCommonDependencies(pkgCache::PkgIterator)
42: | | --0.70%--APT::Solver::DependencySolver::RegisterCommonDependencies(pkgCache::PkgIterator)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Calculate the head and the tail of the clause in Propagate() and
check based on that if the clause is conflict/unit/undecided.
Special care has been taken to avoid the calculation of tail
when it is not necessary by placing it inside a helper lambda;
as well as skipping the calculation when the clause is inactive.
|
| | |
| |
| |
| |
| |
| |
| | |
It used to be that we reached conflict clauses from the Solve()
loop, however that is no longer the case, so remove the else
branch, and turn the `else if (item.clause->optional)` into
a new `else` with an `assert(item.clause->optional)`.
|
| |/
|
|
|
|
|
|
| |
Introduce a scoped object that starts measuring performance counters
and then dumps them into a JSONL file for later analysis.
Add performance contexts for APT::Solver and pkgDepCache::Init()
as starting points.
|
| |\
| |
| |
| |
| | |
Update Ukrainian translation (fix filesystem statistics message)
See merge request apt-team/apt!550
|
| |/
|
|
| |
message
|
| |\
| |
| |
| |
| | |
Complete Ukrainian translation (uk.po only)
See merge request apt-team/apt!544
|
| |/ |
|
| | |
|
| |\
| |
| |
| |
| | |
solver3: Use classical watchers and minor refactorings
See merge request apt-team/apt!548
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Instead of tracking dependencies and reverse dependencies,
install classical watchers. This vastly streamlines the
propagation code and allows us to easily switch to literals
in the next step.
This implementation watches _all_ solutions rather than using
the modern 2-watched literals scheme or the intermediate
head/tail watchers.
Ultimately a more effective watcher scheme would be interesting
but not a significant priority seeing as most of the solver runtime
is spent not in propagation but in problem translation.
decision trees
--------------
The new watchers produce slightly different decision trees, sometimes
subtly changing solutions. Notably in various observed examples in
Ubuntu 25.04, courier was installed as an MTA instead of postfix:
The old decision tree was:
apcupsd:amd64 -> mailutils:amd64=1:3.18-1 -> mailutils:amd64 -> postfix:amd64=3.9.1-10ubuntu1
The new decision tree is:
lsb:amd64 -> lsb-core:amd64 -> courier-mta:amd64=1.3.13-1
The difference here being that lsb-core declares a mail-transport-agent
dependency whereas mailutils depends on `default-mta | mail-transport-agency`;
but both are effectively subject to selection at similar time.
Further work is needed to optimize selection. A notable choice may also
be to deal with broken packages like lsb-core that declare dependencies
solely on a virtual package by reconstructing the default provider for
that package utilizing default-* dependencies or similar notions.
Likewise in the test suite, explanations are different in some
uninstallable cases.
backtracking
~~~~~~~~~~~~
The following major changes were observed in the 25.04 test suite:
-tmp/regression-remove/07f0a068-36c2-11f0-b7c1-fa163e171f02:18
+tmp/regression-remove/07f0a068-36c2-11f0-b7c1-fa163e171f02:3
-tmp/regression-remove/32078f70-3734-11f0-a75a-fa163ec8ca8c:64
+tmp/regression-remove/32078f70-3734-11f0-a75a-fa163ec8ca8c:19
Other test cases showed little deviation, +/- 1, generally
the same amount of backtracking.
performance
~~~~~~~~~~~
Running Ubuntu's regression test suite resulted in no significant
performance difference being observable.
Before: 290s user time; 16.66% solver
After: 299s user time; 17.36% solver
Tests where run with make -j 8 and solver performance extracted
perf report --symbol-filter=ResolveExternal --stdio
|
| | | |
|
| |/
|
|
| |
Quite a convenient way since we need exactly lifted bool semantics
|
| | |
|
| |\
| |
| |
| |
| | |
variants: Do not report unsupported variants in repositories
See merge request apt-team/apt!546
|
| |/
|
|
|
| |
We configure all variants the CPU supports as active, but repositories
usually do not provide all of them, so let's not be noisy.
|
| |\
| |
| |
| |
| | |
why: Render info about all providers on virtual packages
See merge request apt-team/apt!545
|
| |/
|
|
|
|
|
|
|
|
| |
Refactor code into a doOne helper lambda, and then add loop
over the providers to use it.
This fixes a crash seen by Benjamin in a nice way than just
failing :)
Reported-by: Benjamin Drung
|
| | |
|
| |\
| |
| |
| |
| | |
Updated Irish translation based on Release 3.1.12
See merge request apt-team/apt!540
|