summaryrefslogtreecommitdiff
path: root/apt-inst
Commit message (Collapse)AuthorAgeFilesLines
* fix: Prefer prefix ++/-- operators for non-primitive typesDavid Kalnischkies2014-09-271-1/+1
| | | | | Git-Dch: Ignore Reported-By: cppcheck
* fix: Consecutive return, break, continue, goto or throw statements are ↵David Kalnischkies2014-09-271-1/+0
| | | | | | | unnecessary. Git-Dch: Ignore Reported-By: cppcheck
* increase libapt-inst to version 1.6Michael Vogt2014-07-081-1/+1
|
* Fix ar and tar code to be LFS-safeGuillem Jover2014-07-086-16/+15
| | | | | | This is an ABI break. Closes: #742882
* use wildcard to get files in our library makefilesDavid Kalnischkies2014-04-111-10/+2
| | | | | | | | The explicit listing is a pain every time you want to add a file to the list and serves no propose as we list all files there anyway, so this is not only easier but also documents this fact. Git-Dch: Ignore
* apt-inst: Do not try to create a substring of an empty string in error reportingJulian Andres Klode2014-03-171-2/+4
| | | | | One of our compressors (the empty one) has an empty extension. Calling substr on it fails.
* follow method attribute suggestions by gccDavid Kalnischkies2014-03-132-4/+4
| | | | | Git-Dch: Ignore Reported-By: gcc -Wsuggest-attribute={pure,const,noreturn}
* cleanup headers and especially #includes everywhereDavid Kalnischkies2014-03-138-13/+32
| | | | | | | | Beside being a bit cleaner it hopefully also resolves oddball problems I have with high levels of parallel jobs. Git-Dch: Ignore Reported-By: iwyu (include-what-you-use)
* warning: unused parameter ‘foo’ [-Wunused-parameter]David Kalnischkies2014-03-134-5/+5
| | | | | Reported-By: gcc -Wunused-parameter Git-Dch: Ignore
* warning: cast from type A to type B casts away qualifiers [-Wcast-qual]David Kalnischkies2014-03-131-3/+3
| | | | | Git-Dch: Ignore Reported-By: gcc -Wcast-qual
* warning: extra ‘;’ [-Wpedantic]David Kalnischkies2014-03-131-76/+76
| | | | | Git-Dch: Ignore Reported-By: gcc -Wpedantic
* Add support for data.tar, control.tar and control.tar.xzGuillem Jover2014-02-221-11/+10
| | | | | | | | Sync the deb(5) format support with latest dpkg, by allowing uncompressed tar members and xz compressed control.tar. This also refactors the control.tar member extraction by using ExtractTarMember(), which also means future changes only need to be implemented in a single place.
* DebFile: Refactor ExtractTarMember() out from ExtractArchive()Guillem Jover2014-02-222-5/+13
| | | | | Generalize DebFile::ExtractArchive() to take a member base name, so that we can reuse it for control.tar member extraction too.
* ExtractTar: Allow an empty decompressor programGuillem Jover2014-02-221-0/+6
| | | | | This allows for uncompressed tar files, as the decompressor process will not get interposed in-between the file descriptors.
* Fix typos in documentation (codespell)Michael Vogt2014-02-224-6/+6
|
* use utimes instead of utimensat/futimensDavid Kalnischkies2014-02-111-4/+5
| | | | | | | | | | | cppcheck complains about the obsolete utime as it was removed in POSIX1.2008 and recommends usage of utimensat/futimens instead as those are in POSIX and so commit 9ce3cfc9 switched to them. It is just that they aren't as portable as the standard suggests: At least our kFreeBSD and Hurd ports stumble over it at runtime. So to make both, the ports and cppcheck happy, we use utimes instead. Closes: 738567
* correct some style/performance/warnings from cppcheckDavid Kalnischkies2014-01-161-11/+9
| | | | | | | | The most "visible" change is from utime to utimensat/futimens as the first one isn't part of POSIX anymore. Reported-By: cppcheck Git-Dch: Ignore
* fix libapt-inst for >2G debs (closes: #725483)Michael Vogt2013-10-071-3/+3
|
* compression-neutral message for missing data.tar memberDavid Kalnischkies2013-09-261-2/+1
| | | | | | | It even reuses the message used for the other check-for members, so one less message to translate (good, as not that many people will ever see it). Closes: 722710
* don't truncate 100 char long paths in tar extractionOskari Saarenmaa2013-09-121-13/+11
| | | | | | | | | | | | When a data.tar.{gz,xz} contains a path name that is exactly 100 characters long, it will get truncated to 99 chars upon extraction in ExtractTar::Go(). Using all of the 100 available characters for the filename seems to be new behaviour in gnu tar. Closes: #689582 Thanks: Mika Eloranta for the testcase!
* delete Memb on read-error in arfileNiels Thykier2013-06-241-0/+3
| | | | Git-Dch: Ignore
* depend on libapt-pkg in the libapt-inst build processDavid Kalnischkies2013-06-091-0/+1
| | | | | | | fixing parallel build in the handcrafted buildsystem is a pain, so its not enabled by default, but its works for me – sometimes Git-Dch: Ignore
* don't explicitly init ExtractTar InFd with invalid fdDavid Kalnischkies2013-06-091-1/+0
| | | | | | | The default constructor of the FileFd will kick in anyway, which will know that the Fd is invalid while with this explicit call it must be assumed that the fd is in fact valid, which might generate errors in the future
* various simple changes to fix cppcheck warningsDavid Kalnischkies2013-03-101-2/+1
|
* * apt-inst/deb/debfile.h:David Kalnischkies2012-05-101-0/+4
| | | | - readd 'md5.h' to the uncleaned header includes to make qapt build against us again unchanged to unblock transition (Closes: #669163)
* merge from the lp:~mvo/apt/mvo branchMichael Vogt2012-04-201-1/+1
|\
| * * apt-inst/contrib/extracttar.cc:Michael Vogt2012-04-191-1/+1
| | | | | | | | | | - ensure that in StartGzip the InFd is set to "AutoClose" to ensure that the pipe is closed when InFd is closed. This fixes a Fd leak (LP: #985452)
* | prepare new experimtnal uploadMichael Vogt2012-04-111-1/+1
| |
* | * apt-inst/database.{cc,h}, apt-inst/deb/dpkgdb.{cc,h}:David Kalnischkies2012-03-227-719/+4
| | | | | | | | | | | | | | - drop instead of fix as it is only needed if you want to reimplement dpkg and comes straight from the beginning of last decade (Closes: #663372) * apt-inst/deb/debfile.cc: - {Extract,Merge}Control() is another instance of "lets reimplement dpkg" so shot of this code before someone ends up using this…
* | * methods/rred.cc:David Kalnischkies2012-03-202-3/+2
|/ | | | | | | | | | | - check return of writev() as gcc recommends * methods/mirror.cc: - check return of chdir() as gcc recommends * apt-pkg/deb/dpkgpm.cc: - check return of write() a gcc recommends * apt-inst/deb/debfile.cc: - check return of chdir() as gcc recommends * apt-inst/deb/dpkgdb.cc: - check return of chdir() as gcc recommends
* fix "(style) Statements following return, break, continue, goto or throwDavid Kalnischkies2012-03-041-4/+2
| | | | | will never be executed." from cppcheck. The fd was closed only after a return, so invert the order of lines and be happy
* revert 2184.1.3: forward declaration instead of headersDavid Kalnischkies2011-12-134-0/+13
| | | | | The breakage is just to big for now, so guard the change with #ifndef APT_8_CLEANER_HEADERS and be nice to library users
* revert 2184.1.2: do not pollute namespace in headersDavid Kalnischkies2011-12-131-0/+4
| | | | | The breakage is just to big for now, so guard the change with #ifndef APT_8_CLEANER_HEADERS and be nice to library users
* use forward declaration in headers if possible instead of includesDavid Kalnischkies2011-09-1912-7/+35
|
* do not pollute namespace in the headers with using (Closes: #500198)David Kalnischkies2011-09-1910-21/+19
|
* * [abi-break] Support large files in the complete toolset. Indexes of thisMichael Vogt2011-09-141-1/+1
| | | * bump ABI version
* Support large files in the complete toolset. Indexes of thisDavid Kalnischkies2011-09-131-1/+1
| | | | size are pretty unlikely for now, but we need it for deb packages which could become bigger than 4GB now (LP: #815895)
* reorder includes: add <config.h> if needed and include it at firstDavid Kalnischkies2011-09-138-2/+19
|
* merge lp:~mvo/apt/abi-breakMichael Vogt2011-06-291-1/+1
|
* remove Size >= 0 check as Itm.Size is an unsigned variable (clang warning)David Kalnischkies2011-05-171-1/+1
|
* fix a bunch of cppcheck warnings/errors based on a patch byDavid Kalnischkies2011-04-161-4/+10
| | | Niels Thykier, thanks! (Closes: #622805)
* * apt-inst/deb/debfile.cc:David Kalnischkies2011-02-281-16/+26
| | | - support data.tar's compressed with any configured compressor
* * ftparchive/contents.cc:David Kalnischkies2011-02-241-1/+1
| | | - remove ExtractArchive codecopy from apt-inst/deb/debfile.cc
* * ftparchive/multicompress.cc, apt-inst/deb/debfile.cc:David Kalnischkies2011-02-221-1/+7
|\ | | | | | | | | | | - support xz compressor to create xz-compressed Indexes and be able to open data.tar.xz files * ftparchive/writer.cc: - include xz-compressed Packages and Sources files in Release file
| * * ftparchive/multicompress.cc, apt-inst/deb/debfile.cc:David Kalnischkies2011-02-221-1/+7
| | | | | | | | - support xz compressor to create xz-compressed Indexes and be able to open data.tar.xz files
* | * apt-inst/contrib/extracttar.cc:David Kalnischkies2011-01-131-4/+8
|\ \ | | | | | | | | | - let apt-utils work with encoded tar headers if uid/gid are large. Thanks to Nobuhiro Hayashi for the patch! (Closes: #330162)
| * | Permit base256 encoded value in the numeric field of tar header.Nobuhiro Hayashi2010-12-031-4/+8
| |/
* / FristOwner is never used in the blamed history and gcc-4.6 complains nowDavid Kalnischkies2011-01-121-3/+1
|/
* Switch away from the now deprecated methods for Cache buildingDavid Kalnischkies2010-06-041-1/+1
|
* apt-inst/contrib/arfile.h: Add public ARArchive::Members() which returns the ↵Julian Andres Klode2010-03-121-0/+1
| | | | list of members.