summaryrefslogtreecommitdiff
path: root/apt-inst
Commit message (Collapse)AuthorAgeFilesLines
* Replace APT_CONST with APT_PURE everywhereJulian Andres Klode2017-08-241-1/+1
| | | | | As a follow up to the last commit, let's replace APT_CONST with APT_PURE everywhere to clean stuff up.
* Reformat and sort all includes with clang-formatJulian Andres Klode2017-07-128-35/+33
| | | | | | | | | | | | | This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh.
* Drop cacheiterators.h includeJulian Andres Klode2017-07-122-2/+0
| | | | | Including cacheiterators.h before pkgcache.h fails because pkgcache.h depends on cacheiterators.h.
* fix various typos reported by spellintianDavid Kalnischkies2017-01-193-3/+3
| | | | | | | | Most of them in (old) code comments. The two instances of user visible string changes the po files of the manpages are fixed up as well. Gbp-Dch: Ignore Reported-By: spellintian
* CMake: Document that the globs are expanded during CMakeJulian Andres Klode2017-01-171-1/+3
| | | | | | | This will avoid people from thinking that they have to do nothing when they change the set of files. Gbp-Dch: ignore
* apt-inst: debfile: Pass comp. Name to ExtractTar, not BinaryJulian Andres Klode2016-08-261-1/+1
| | | | | | In the old days, apt-inst used to use binaries, but now it uses the built-in support and matches using Name, and not a Binary.
* Get rid of the old buildsystemJulian Andres Klode2016-08-101-26/+0
| | | | Bye, bye, old friend.
* CMake: Add basic CMake build systemJulian Andres Klode2016-08-061-0/+26
| | | | | | | | | | | Introduce an initial CMake buildsystem. This build system can build a fully working apt system without translation or documentation. The FindBerkelyDB module is from kdelibs, with some small adjustements to also look in db5 directories. Initial work on this CMake build system started in 2009, and was resumed in August 2016.
* Fix several typosVeres Lajos2016-03-071-1/+1
| | | | | | | | | | | | | This effectively merges branch 'typofixes-vlajos-20150807' of github.com:vlajos/apt with the following commit: commit 13cacb3e2e2352ba701e769fc889e3344fabbf7e Author: Veres Lajos <vlajos@gmail.com> Date: Sun Aug 9 00:12:53 2015 +0100 typofix - https://github.com/vlajos/misspell_fixer It has been rebased for a better commit message.
* Sort the list of sources to be built and linkedMattia Rizzolo2016-01-111-2/+2
| | | | | | | | | Fix reproducibility issue due to readdir() order by sorting the list of sources to be built and linked. [jak@debian.org: Added summary and fixed typo] Closes: #810509
* add messages to our deprecation warnings in libaptDavid Kalnischkies2015-11-271-1/+1
| | | | Git-Dch: Ignore
* apply various suggestions made by cppcheckDavid Kalnischkies2015-11-051-1/+1
| | | | | Reported-By: cppcheck Git-Dch: Ignore
* fix some unused parameter/variable warningsDavid Kalnischkies2015-08-312-10/+11
| | | | | Reported-By: gcc Git-Dch: Ignore
* Merge branch 'feature/extractar-filefd' into debian/experimentalJulian Andres Klode2015-08-271-56/+11
|\
| * Use compressor support from FileFd for ExtractTar instead of programsJulian Andres Klode2015-08-271-56/+11
| | | | | | | | This way we do not depend on the decompressor programs anymore.
* | fix various typos reported by codespellDavid Kalnischkies2015-08-271-1/+1
|/ | | | Reported-By: codespell
* Bump apt-inst SONAME to 2.0 to adjust for the ABI break in apt-pkgJulian Andres Klode2015-08-111-1/+1
|
* remove the compatibility markers for 4.13 abiDavid Kalnischkies2015-08-106-44/+1
| | | | | | | | We aren't and we will not be really compatible again with the previous stable abi, so lets drop these markers (which never made it into a released version) for good as they have outlived their intend already. Git-Dch: Ignore
* add c++11 override marker to overridden methodsDavid Kalnischkies2015-08-102-6/+6
| | | | | | | | | C++11 adds the 'override' specifier to mark that a method is overriding a base class method and error out if not. We hide it in the APT_OVERRIDE macro to ensure that we keep compiling in pre-c++11 standards. Reported-By: clang-modernize -add-override -override-macros Git-Dch: Ignore
* guard ABI changes for LFS in apt-instDavid Kalnischkies2014-11-086-4/+49
| | | | Git-Dch: Ignore
* fix: Prefer prefix ++/-- operators for non-primitive typesDavid Kalnischkies2014-09-271-1/+1
| | | | | Git-Dch: Ignore Reported-By: cppcheck
* fix: Consecutive return, break, continue, goto or throw statements are ↵David Kalnischkies2014-09-271-1/+0
| | | | | | | unnecessary. Git-Dch: Ignore Reported-By: cppcheck
* increase libapt-inst to version 1.6Michael Vogt2014-07-081-1/+1
|
* Fix ar and tar code to be LFS-safeGuillem Jover2014-07-086-16/+15
| | | | | | This is an ABI break. Closes: #742882
* use wildcard to get files in our library makefilesDavid Kalnischkies2014-04-111-10/+2
| | | | | | | | The explicit listing is a pain every time you want to add a file to the list and serves no propose as we list all files there anyway, so this is not only easier but also documents this fact. Git-Dch: Ignore
* apt-inst: Do not try to create a substring of an empty string in error reportingJulian Andres Klode2014-03-171-2/+4
| | | | | One of our compressors (the empty one) has an empty extension. Calling substr on it fails.
* follow method attribute suggestions by gccDavid Kalnischkies2014-03-132-4/+4
| | | | | Git-Dch: Ignore Reported-By: gcc -Wsuggest-attribute={pure,const,noreturn}
* cleanup headers and especially #includes everywhereDavid Kalnischkies2014-03-138-13/+32
| | | | | | | | Beside being a bit cleaner it hopefully also resolves oddball problems I have with high levels of parallel jobs. Git-Dch: Ignore Reported-By: iwyu (include-what-you-use)
* warning: unused parameter ‘foo’ [-Wunused-parameter]David Kalnischkies2014-03-134-5/+5
| | | | | Reported-By: gcc -Wunused-parameter Git-Dch: Ignore
* warning: cast from type A to type B casts away qualifiers [-Wcast-qual]David Kalnischkies2014-03-131-3/+3
| | | | | Git-Dch: Ignore Reported-By: gcc -Wcast-qual
* warning: extra ‘;’ [-Wpedantic]David Kalnischkies2014-03-131-76/+76
| | | | | Git-Dch: Ignore Reported-By: gcc -Wpedantic
* Add support for data.tar, control.tar and control.tar.xzGuillem Jover2014-02-221-11/+10
| | | | | | | | Sync the deb(5) format support with latest dpkg, by allowing uncompressed tar members and xz compressed control.tar. This also refactors the control.tar member extraction by using ExtractTarMember(), which also means future changes only need to be implemented in a single place.
* DebFile: Refactor ExtractTarMember() out from ExtractArchive()Guillem Jover2014-02-222-5/+13
| | | | | Generalize DebFile::ExtractArchive() to take a member base name, so that we can reuse it for control.tar member extraction too.
* ExtractTar: Allow an empty decompressor programGuillem Jover2014-02-221-0/+6
| | | | | This allows for uncompressed tar files, as the decompressor process will not get interposed in-between the file descriptors.
* Fix typos in documentation (codespell)Michael Vogt2014-02-224-6/+6
|
* use utimes instead of utimensat/futimensDavid Kalnischkies2014-02-111-4/+5
| | | | | | | | | | | cppcheck complains about the obsolete utime as it was removed in POSIX1.2008 and recommends usage of utimensat/futimens instead as those are in POSIX and so commit 9ce3cfc9 switched to them. It is just that they aren't as portable as the standard suggests: At least our kFreeBSD and Hurd ports stumble over it at runtime. So to make both, the ports and cppcheck happy, we use utimes instead. Closes: 738567
* correct some style/performance/warnings from cppcheckDavid Kalnischkies2014-01-161-11/+9
| | | | | | | | The most "visible" change is from utime to utimensat/futimens as the first one isn't part of POSIX anymore. Reported-By: cppcheck Git-Dch: Ignore
* fix libapt-inst for >2G debs (closes: #725483)Michael Vogt2013-10-071-3/+3
|
* compression-neutral message for missing data.tar memberDavid Kalnischkies2013-09-261-2/+1
| | | | | | | It even reuses the message used for the other check-for members, so one less message to translate (good, as not that many people will ever see it). Closes: 722710
* don't truncate 100 char long paths in tar extractionOskari Saarenmaa2013-09-121-13/+11
| | | | | | | | | | | | When a data.tar.{gz,xz} contains a path name that is exactly 100 characters long, it will get truncated to 99 chars upon extraction in ExtractTar::Go(). Using all of the 100 available characters for the filename seems to be new behaviour in gnu tar. Closes: #689582 Thanks: Mika Eloranta for the testcase!
* delete Memb on read-error in arfileNiels Thykier2013-06-241-0/+3
| | | | Git-Dch: Ignore
* depend on libapt-pkg in the libapt-inst build processDavid Kalnischkies2013-06-091-0/+1
| | | | | | | fixing parallel build in the handcrafted buildsystem is a pain, so its not enabled by default, but its works for me – sometimes Git-Dch: Ignore
* don't explicitly init ExtractTar InFd with invalid fdDavid Kalnischkies2013-06-091-1/+0
| | | | | | | The default constructor of the FileFd will kick in anyway, which will know that the Fd is invalid while with this explicit call it must be assumed that the fd is in fact valid, which might generate errors in the future
* various simple changes to fix cppcheck warningsDavid Kalnischkies2013-03-101-2/+1
|
* * apt-inst/deb/debfile.h:David Kalnischkies2012-05-101-0/+4
| | | | - readd 'md5.h' to the uncleaned header includes to make qapt build against us again unchanged to unblock transition (Closes: #669163)
* merge from the lp:~mvo/apt/mvo branchMichael Vogt2012-04-201-1/+1
|\
| * * apt-inst/contrib/extracttar.cc:Michael Vogt2012-04-191-1/+1
| | | | | | | | | | - ensure that in StartGzip the InFd is set to "AutoClose" to ensure that the pipe is closed when InFd is closed. This fixes a Fd leak (LP: #985452)
* | prepare new experimtnal uploadMichael Vogt2012-04-111-1/+1
| |
* | * apt-inst/database.{cc,h}, apt-inst/deb/dpkgdb.{cc,h}:David Kalnischkies2012-03-227-719/+4
| | | | | | | | | | | | | | - drop instead of fix as it is only needed if you want to reimplement dpkg and comes straight from the beginning of last decade (Closes: #663372) * apt-inst/deb/debfile.cc: - {Extract,Merge}Control() is another instance of "lets reimplement dpkg" so shot of this code before someone ends up using this…
* | * methods/rred.cc:David Kalnischkies2012-03-202-3/+2
|/ | | | | | | | | | | - check return of writev() as gcc recommends * methods/mirror.cc: - check return of chdir() as gcc recommends * apt-pkg/deb/dpkgpm.cc: - check return of write() a gcc recommends * apt-inst/deb/debfile.cc: - check return of chdir() as gcc recommends * apt-inst/deb/dpkgdb.cc: - check return of chdir() as gcc recommends