summaryrefslogtreecommitdiff
path: root/apt-pkg/indexcopy.cc
Commit message (Collapse)AuthorAgeFilesLines
* use HashStringList in the acquire systemDavid Kalnischkies2014-05-091-3/+5
| | | | | | | | | | | | | It is not very extensible to have the supported Hashes hardcoded everywhere and especially if it is part of virtual method names. It is also possible that a method does not support the 'best' hash (yet), so we might end up not being able to verify a file even though we have a common subset of supported hashes. And those are just two of the cases in which it is handy to have a more dynamic selection. The downside is that this is a MAJOR API break, but the HashStringList has a string constructor for compatibility, so with a bit of luck the few frontends playing with the acquire system directly are okay.
* follow method attribute suggestions by gccDavid Kalnischkies2014-03-131-4/+2
| | | | | Git-Dch: Ignore Reported-By: gcc -Wsuggest-attribute={pure,const,noreturn}
* cleanup headers and especially #includes everywhereDavid Kalnischkies2014-03-131-3/+3
| | | | | | | | Beside being a bit cleaner it hopefully also resolves oddball problems I have with high levels of parallel jobs. Git-Dch: Ignore Reported-By: iwyu (include-what-you-use)
* warning: unused parameter ‘foo’ [-Wunused-parameter]David Kalnischkies2014-03-131-1/+1
| | | | | Reported-By: gcc -Wunused-parameter Git-Dch: Ignore
* warning: useless cast to type A [-Wuseless-cast]David Kalnischkies2014-03-131-6/+6
| | | | | Git-Dch: Ignore Reported-By: gcc -Wuseless-cast
* warning: extra ‘;’ [-Wpedantic]David Kalnischkies2014-03-131-2/+2
| | | | | Git-Dch: Ignore Reported-By: gcc -Wpedantic
* fix -Wmissing-field-initializers warningsDavid Kalnischkies2014-03-131-4/+4
| | | | | Reported-By: gcc Git-Dch: Ignore
* fix resource leak when verification failsMichael Vogt2013-07-251-0/+1
|
* apt-pkg/indexcopy.cc: check for pending errors before calling fdopen()Michael Vogt2013-07-251-1/+1
|
* call fdopen() after FileFd was checkedMichael Vogt2013-07-251-1/+1
|
* fail in CopyFile if the FileFds have error flag setDavid Kalnischkies2013-06-091-4/+2
| | | | | | | | | Testing for global PendingErrors in users of CopyFile is incorrect in so far as unrelated errors will prevent us from copying perfectly fine files and checking for the validity of the files is just better in CopyFiles as it already checks if files are at least opened. Add also a higher-level error message to the error stack if it fails.
* non-inline RunGPGV methods to restore ABI compatibility with previous ↵David Kalnischkies2013-05-161-0/+12
| | | | | | | | versions to fix partial upgrades (Closes: #707771) The rename in 0.9.7.9~exp2 moved the method body to the class definition which means it became inline, which isn't ABI compatibile. The reverse of moving inline to non-inline is safe though.
* merged bundle from davidMichael Vogt2013-04-081-4/+2
|\
| * various simple changes to fix cppcheck warningsDavid Kalnischkies2013-03-101-4/+2
| |
* | * apt-pkg/indexcopy.cc:David Kalnischkies2013-03-151-120/+2
|/ | | - rename RunGPGV to ExecGPGV and move it to apt-pkg/contrib/gpgv.cc
* - do not create duplicated flat-archive CD-ROM sources for foreignDavid Kalnischkies2012-09-031-6/+9
| | | | | | | architectures on multi-arch CD-ROMs - do not warn about files which have a record in the Release file, but are not present on the CD to mirror the behavior of the other methods and to allow uncompressed indexes to be dropped without scaring users - handle Components in the reduction for the source.list as multi-arch CDs
* * apt-pkg/indexcopy.cc:David Kalnischkies2012-09-021-4/+7
| | | | - do not create duplicated flat-archive cdrom sources for foreign architectures on multi-arch cdroms
* * apt-pkg/indexcopy.cc:David Kalnischkies2012-08-051-1/+6
| | | | - do not use atomic writing if the target is /dev/null as we don't want to replace it, not even automically. (Closes: #683410)
* Fix IndexCopy::CopyPackages and TranslationsCopy::CopyTranslations toMichael Vogt2012-01-311-2/+2
| | | handle compressed files again (LP: #924182, closes: #658096)
* Allow the FileFd to use an external Compressor to uncompress a given fileDavid Kalnischkies2011-12-131-91/+6
| | | | | | | | | | | internally so that it is exported and can be used like a "normal" uncompressed file with FileFd This allows us to hide th zlib usage in the implementation and use gzip instead if we don't have zlib builtin (the same for other compressors). The code includes quiet a few FIXME's so while all tests are working it shouldn't be used just yet outside of libapt as it might break.
* * apt-pkg/cdrom.cc:David Kalnischkies2011-12-111-5/+21
| | | - support InRelease files on cdrom
* use getCompressors() instead of getCompressorTypes() and use it everywhereDavid Kalnischkies2011-11-241-74/+72
| | | | to replace hardcoding of compressiontypes and compressors
* factored out the decompressor code in IndexCopy::CopyPackages() andSteve McIntyre2011-11-231-80/+94
| | | | TranslationsCopy::CopyTranslations() into a single common function
* merge with debian/experimentalDavid Kalnischkies2011-09-131-11/+10
|\
| * fix a few more cppcheck performance and scope warningsDavid Kalnischkies2011-08-111-2/+1
| |
| * cppcheck complains about some possible speed improvements which could beDavid Kalnischkies2011-08-111-9/+9
| | | | | | | | | | | | done on the mirco-optimazation level, so lets fix them: (performance) Possible inefficient checking for emptiness. (performance) Prefer prefix ++/-- operators for non-primitive types.
* | Support large files in the complete toolset. Indexes of thisDavid Kalnischkies2011-09-131-11/+12
| | | | | | | | size are pretty unlikely for now, but we need it for deb packages which could become bigger than 4GB now (LP: #815895)
* | reorder includes: add <config.h> if needed and include it at firstDavid Kalnischkies2011-09-131-2/+4
|/
* fix from David Kalnischkies for the InRelease gpg verification Michael Vogt2011-07-131-1/+20
| | | code (LP: #784473)
* * apt-pkg/indexcopy.cc:Julian Andres Klode2011-04-071-5/+5
| | | | - Use RealFileExists() instead of FileExists(), allows amongst other things a directory named Sources to exist on a CD-ROM (LP: #750694).
* - try downloading clearsigned InRelease before trying Release.gpgDavid Kalnischkies2011-01-201-1/+2
| | | | * apt-pkg/deb/deblistparser.cc: - rewrite LoadReleaseInfo to cope with clearsigned Releasefiles
* * apt-pkg/indexcopy.cc:Michael Vogt2010-09-071-3/+10
|\ | | | | | | | | - only use trusted.gpg.d directory if it exists - do not replace /dev/null when running in APT::CDROM::NoAct mode (LP: #612666), thanks to Colin Watson
| * do not replace /dev/null when running in APT::CDROM::NoActMichael Vogt2010-09-071-1/+6
| | | | | | mode (LP: #612666), thanks to Colin Watson
| * apt-pkg/indexcopy.cc: include trustedFile (if it exists)Michael Vogt2010-09-031-5/+3
| |
| * * apt-pkg/indexcopy.cc:Michael Vogt2010-09-031-3/+7
| | | | | | - only use trusted.gpg.d directory if it exists
* | * apt-pkg/indexcopy.cc:David Kalnischkies2010-09-041-1/+1
|/ | | | - support really still the APT::GPGV::TrustedKeyring setting, as it breaks d-i badly otherwise (Closes: #595428)
* * apt-pkg/init.cc:David Kalnischkies2010-08-191-3/+2
| | | - set the default values for dir::etc::trusted options correctly
* apt-pkg, methods: Convert users of WriteEmpty to WriteAtomic.Julian Andres Klode2010-08-101-3/+3
|
* enhance the split out of the gpgv commandline mangling by splitting outDavid Kalnischkies2010-06-091-13/+49
| | | | the call completely
* * apt-pkg/indexcopy.cc:David Kalnischkies2010-06-091-39/+70
| | | - move the gpg codecopy to a new method and use it also in methods/gpgv.cc
* * French manpage translation updateMichael Vogt2010-01-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | * spot & fix various typos in all manpages * German manpage translation update * cmdline/apt-cache.cc: - remove translatable marker from the "%4i %s\n" string * buildlib/po4a_manpage.mak: - instruct debiandoc to build files with utf-8 encoding * buildlib/tools.m4: - fix some warning from the buildtools * apt-pkg/acquire-item.cc: - add configuration PDiffs::Limit-options to not download too many or too big patches (Closes: #554349) * debian/control: - let all packages depend on ${misc:Depends} * share/*-archive.gpg: - remove the horrible outdated files. We already depend on the keyring so we don't need to ship our own version * cmdline/apt-key: - errors out if wget is not installed (Closes: #545754) - add --keyring option as we have now possibly many * methods/gpgv.cc: - pass all keyrings (TrustedParts) to gpgv instead of using only one trusted.gpg keyring (Closes: #304846) * methods/https.cc: - finally merge the rest of the patchset from Arnaud Ebalard with the CRL and Issuers options, thanks! (Closes: #485963)
* * apt-pkg/packagemanager.cc:Michael Vogt2009-12-021-3/+3
|\ | | | | | | | | | | | | | | | | | | | | | | | | - add output about pre-depends configuring when debug::pkgPackageManager is used * methods/https.cc: - fix incorrect use of CURLOPT_TIMEOUT, closes: #497983, LP: #354972 thanks to Brian Thomason for the patch * apt-pkg/depcache.cc, apt-pkg/indexcopy.cc: - typo fix (LP: #462328) * cmdline/apt-key: - Emit a warning if removed keys keyring is missing and skip associated checks (LP: #218971)
| * * apt-pkg/depcache.cc, apt-pkg/indexcopy.cc:Michael Vogt2009-10-291-3/+3
| | | | | | | | - typo fix (LP: #462328)
* | [apt-pkg/indexcopy.cc] fix a (hypothetical) memory leak then the ReleaseDavid Kalnischkies2009-08-081-0/+3
|/ | | | file not exists, patch from George Danchev, thanks! (Closes: #511556)
* The 'not dead yet' releaseMichael Vogt2009-07-211-8/+8
|\ | | | | | | | | | | | | | | | | | | | | * add hook for MarkInstall and MarkDelete (closes: #470035) * add the various foldmarkers in apt-pkg & cmdline (no code change) * versions with a pin of -1 shouldn't be a candidate (Closes: #355237) * prefer mmap as memory allocator in MMap instead of a static char array which can (at least in theory) grow dynamic * eliminate (hopefully all) segfaults in pkgcachegen.cc and mmap.cc which can arise if cache doesn't fit into the mmap (Closes: #535218) * display warnings instead of errors if the parts dirs doesn't exist * honor the dpkg hold state in new Marker hooks (closes: #64141)
| * add the various foldmarkers in apt-pkg & cmdline (no code change)David Kalnischkies2009-06-301-8/+8
| |
| * fix various -Wall warningsMichael Vogt2008-10-281-1/+1
| |
* | apt-pkg/indexcopy.cc: discard errors after Verify()Michael Vogt2008-10-281-0/+1
| |
* | * apt-pkg/indexcopy.cc:Michael Vogt2008-08-091-0/+9
| | | | | | | | | | - support having CDs with no Packages file (just a Packages.gz) by not forcing a verification on non-existing files (LP: #255545)
* | fix various -Wall warningsMichael Vogt2008-08-051-1/+1
|/