| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Real webservers (like apache) actually send an error page with a 416
response, but our client didn't expect it leaving the page on the socket
to be parsed as response for the next request (http) or as file content
(https), which isn't what we want at all… Symptom is a "Bad header line"
as html usually doesn't parse that well to an http-header.
This manifests itself e.g. if we have a complete file (or larger) in
partial/ which isn't discarded by If-Range as the server doesn't support
it (or it is just newer, think: mirror rotation).
It is a sort-of regression of 78c72d0ce22e00b194251445aae306df357d5c1a,
which removed the filesize - 1 trick, but this had its own problems…
To properly test this our webserver gains the ability to reply with
transfer-encoding: chunked as most real webservers will use it to send
the dynamically generated error pages.
(The tests and their binary helpers had to be slightly modified to
apply, but the patch to fix the issue itself is unchanged.)
Closes: 768797
|
|
|
|
|
|
|
|
|
|
|
| |
apt-key given a long keyid reports just "OK" all the time, but doesn't
delete the mentioned key as it doesn't find the key.
Note: In debian/experimental this was closed with
29f1b977100aeb6d6ebd38923eeb7a623e264ffe which just added the testcase
as the rewrite of apt-key had fixed this as well.
Closes: 754436
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Collect all hashes we can get from the source record and put them into a
HashStringList so that 'apt-get source' can use it instead of using
always the MD5sum.
We therefore also deprecate the MD5 struct member in favor of the list.
While at it, the parsing of the Files is enhanced so that records which
miss "Files" (aka MD5 checksums) are still searched for other checksums
as they include just as much data, just not with a nice and catchy name.
This is a cherry-pick of 1262d35 with some dirty tricks to preserve ABI.
LP: 1098738
|
|
|
|
|
|
|
|
| |
The code is creating a secure temporary directory, but then creates
the changelog alongside the tmpdir in the same base directory. This
defeats the secure tmpdir creation, making the filename predictable.
Inject a '/' between the tmpdir and the changelog filename.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
When apt-cache search with many args (> 130) is given the allocation
of PatternMatch on the stack may fail resulting in a segmentation
fault. By using the heap the max size is much bigger and we also
get a bad_alloc expection instead of a segfault (which we can catch
*if* this ever becomes a pratical problem). No test for the crash
as its not reproducable with the MALLOC_ settings in framework.
Closes: 759612
|
|
|
|
|
|
|
|
|
| |
When doing Acquire::http{,s}::Proxy-Auto-Detect, run the auto-detect
command for each host instead of only once. This should make using
"proxy" from libproxy-tools feasible which can then be used for PAC
style or other proxy configurations.
Closes: #759264
|
|
|
|
|
|
|
|
|
|
|
| |
dpkg-source can be told to enforce signature checks with
--require-valid-signature, but while this isn't feasible as default for
Debian itself at the moment, a local admin should be able to use it.
This commit also fixes the size limit on the construction of the command
being called for dpkg-source and dpkg-buildpackage.
Closes: 757534
|
| |
|
|\ |
|
| |
| |
| |
| | |
Closes: 748389
|
|\ \
| | |
| | |
| | | |
'mvo/bugfix/apt-get-source-unauthenticated-warning' into debian/sid
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This will show the same unauthenticated warning for source packages
as for binary packages and will not download a source package if
it is unauthenticated. This can be overridden with
--allow-unauthenticated
Closes: #749795
|
| | |
| | |
| | |
| | | |
Closes: 742835
|
| | | |
|
|/ /
| |
| |
| | |
Git-Dch: ignore
|
| |
| |
| |
| |
| |
| |
| | |
3163087b moved SigWinch(int) from apt-get.cc to private-output.cc
without moving #include <sys/ioctl.h>, making SigWinch a nop.
Closes: 748430, 747942
|
| | |
|
|/
|
|
|
|
| |
Those files are in apt-private and used from there.
Git-Dch: Ignore
|
|
|
|
| |
Closes: 743413
|
| |
|
|
|
|
|
| |
Use mkstemp() in apt-extractemplates and add a integrationtest
for apt-extracttemplates too. Thanks to Steve Kemp for the report.
|
|\ |
|
| | |
|
| |
| |
| |
| | |
Git-Dch: Ignore
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The preparation code to deal with auto-detection and co is the same for
both methods, so not sharing them would be bad. Deals also with the
prevention of side effects triggered by the auto-detection like
disabling mounting for the fallback.
Git-Dch: Ignore
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The warning message from gcc doesn't make that much sense in my reading
as there is no loop which could overflow here, but it is better to use
our SPtrArray wrapping anyway which fixes the warning as well.
warning: cannot optimize loop, the loop counter may overflow [-Wunsafe-loop-optimizations]
delete[] Dsc;
Git-Dch: Ignore
Reported-By: gcc -Wunsafe-loop-optimizations
|
| |
| |
| |
| |
| | |
Git-Dch: Ignore
Reported-By: gcc -Wsuggest-attribute={pure,const,noreturn}
|
| |
| |
| |
| |
| |
| |
| |
| | |
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
|
| |
| |
| |
| |
| | |
Reported-By: gcc -Wunused-parameter
Git-Dch: Ignore
|
| |
| |
| |
| |
| | |
Git-Dch: Ignore
Reported-By: gcc -Wmissing-declarations
|
| |
| |
| |
| |
| | |
Git-Dch: Ignore
Reported-By: gcc -Wpedantic
|
| |
| |
| |
| |
| | |
Reported-By: gcc
Git-Dch: Ignore
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Inspired by the rest of the patch in 661537, but abstract the
parsing of various ways of setting the build profiles more so it can
potentially be reused and all apt parts have the same behaviour.
Especially config options, cmdline options and environment will not be
combined as proposed as this isn't APTs usual behaviour and dpkg doesn't
do it either, so one overrides the other as it normally does.
|
|\|
| |
| |
| |
| |
| |
| |
| |
| | |
feature/apt-download-file
Conflicts:
cmdline/apt-helper.cc
test/integration/framework
test/integration/test-apt-https-no-redirect
|
| | |
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
| |
Sync the deb(5) format support with latest dpkg, by allowing
uncompressed tar members and xz compressed control.tar. This
also refactors the control.tar member extraction by using
ExtractTarMember(), which also means future changes only need
to be implemented in a single place.
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Conflicts:
test/integration/test-apt-get-download
|
| |
| |
| |
| |
| |
| |
| | |
Use a APT::VersionSet instead of a APT::VersionList in DoDownload()
to ensure that there is only one version in the set even if the
user passes multiple identical name/versions on the commandline
(Bug#738103)
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If there are multiple CD-ROM drives, `apt-cdrom add` will abort with an
error if any of the drives do not contain a Debian CD which is against
the documentation we have saying "a CD-ROM" and also scripts do not
expect it this way.
This patch modifies apt-cdrom to return success if any of the drives
succeeded. If failures occur, apt-cdrom will still continue trying all
the drives and report the last failure (if none of them succeeded).
The 'ident' command was also changed to match the new 'add' behavior.
Closes: 728153
|
|/
|
|
| |
Closes: 738103
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Conflicts:
apt-private/private-list.cc
doc/po/de.po
test/integration/framework
|
| |
| |
| |
| |
| |
| | |
Avoids that gpg gets the idea it could use files from the user which
weren't overridden specifically like secret keyring and trustdb as
before.
|