From f52c1ce9b31befb71016a20759b96b4946034fcb Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Thu, 1 Sep 2022 15:14:52 +0200 Subject: Allow apt to run if no dpkg/status file exists Not having a dpkg/status file used to be a hard error which from a boostrap perspective is suspect as in the beginning, there is no status so you would need to touch it into existence. We make a difference between factual non-existence and inaccessibility to catch mistakes in which the file is not readable for some reason, the testcase test-bug-254770-segfault-if-cache-not-buildable is an example of this. Note that apt has already figured out at this point that this is a Debian-like system which should have a dpkg/status file. This change does not effect the auto-detection and is not supposed to. --- apt-pkg/deb/debsystem.cc | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'apt-pkg/deb/debsystem.cc') diff --git a/apt-pkg/deb/debsystem.cc b/apt-pkg/deb/debsystem.cc index 65a27f72f..9c55e0a6e 100644 --- a/apt-pkg/deb/debsystem.cc +++ b/apt-pkg/deb/debsystem.cc @@ -338,6 +338,13 @@ bool debSystem::AddStatusFiles(std::vector &List) if (d->StatusFile == nullptr) { auto dpkgstatus = _config->FindFile("Dir::State::status"); + if (dpkgstatus.empty()) + return true; + // we ignore only if the file doesn't exist, not if it is inaccessible + // e.g. due to permissions on parent directories as FileExists would do + errno = 0; + if (access(dpkgstatus.c_str(), R_OK) != 0 && errno == ENOENT) + return true; _error->PushToStack(); d->StatusFile = new debStatusIndex(std::move(dpkgstatus)); bool const errored = _error->PendingError(); -- cgit v1.2.3-70-g09d2