From 10755b590311356ecdaa38dbfdf552b6b8fdaddc Mon Sep 17 00:00:00 2001
From: Julian Andres Klode <julian.klode@canonical.com>
Date: Wed, 26 Feb 2025 12:18:02 +0100
Subject: refactor obsolete checks to use VerFileIterator::Downloadable()

---
 apt-pkg/solver3.cc | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

(limited to 'apt-pkg/solver3.cc')

diff --git a/apt-pkg/solver3.cc b/apt-pkg/solver3.cc
index 7117296ab..c1a1098b5 100644
--- a/apt-pkg/solver3.cc
+++ b/apt-pkg/solver3.cc
@@ -336,12 +336,11 @@ bool APT::Solver::Obsolete(pkgCache::PkgIterator pkg) const
    if (ObsoletedByNewerSourceVersion(ver))
       return true;
 
-   for (auto file = ver.FileList(); !file.end(); file++)
-      if ((file.File()->Flags & pkgCache::Flag::NotSource) == 0)
-      {
-	 pkgObsolete[pkg] = 1;
-	 return false;
-      }
+   if (ver.Downloadable())
+   {
+      pkgObsolete[pkg] = 1;
+      return false;
+   }
    if (debug >= 3)
       std::cerr << "Obsolete: " << ver.ParentPkg().FullName() << "=" << ver.VerStr() << " - not installable\n";
    pkgObsolete[pkg] = 2;
-- 
cgit v1.2.3-70-g09d2