From 92296fe4b0862a04ea3d965b4cd2d4a420e3be9f Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Fri, 8 Jul 2016 15:59:23 +0200 Subject: support "install ./foo.changes" We support installing ./foo.deb (and ./foo.dsc for source) for a while now, but it can be a bit clunky to work with those directly if you e.g. build packages locally in a 'central' build-area. The changes files also include hashsums and can be signed, so this can also be considered an enhancement in terms of security as a user "just" has to verify the signature on the changes file then rather than checking all deb files individually in these manual installation procedures. --- apt-private/private-install.cc | 8 ++++---- apt-private/private-install.h | 4 ++-- apt-private/private-source.cc | 12 ++++++------ apt-private/private-upgrade.cc | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-) (limited to 'apt-private') diff --git a/apt-private/private-install.cc b/apt-private/private-install.cc index 63e7b734d..aa28780da 100644 --- a/apt-private/private-install.cc +++ b/apt-private/private-install.cc @@ -540,15 +540,15 @@ static const unsigned short MOD_INSTALL = 2; bool DoCacheManipulationFromCommandLine(CommandLine &CmdL, CacheFile &Cache, int UpgradeMode) { - std::vector VolatileCmdL; + std::vector VolatileCmdL; return DoCacheManipulationFromCommandLine(CmdL, VolatileCmdL, Cache, UpgradeMode); } -bool DoCacheManipulationFromCommandLine(CommandLine &CmdL, std::vector &VolatileCmdL, CacheFile &Cache, int UpgradeMode) +bool DoCacheManipulationFromCommandLine(CommandLine &CmdL, std::vector &VolatileCmdL, CacheFile &Cache, int UpgradeMode) { std::map verset; return DoCacheManipulationFromCommandLine(CmdL, VolatileCmdL, Cache, verset, UpgradeMode); } -bool DoCacheManipulationFromCommandLine(CommandLine &CmdL, std::vector &VolatileCmdL, CacheFile &Cache, +bool DoCacheManipulationFromCommandLine(CommandLine &CmdL, std::vector &VolatileCmdL, CacheFile &Cache, std::map &verset, int UpgradeMode) { // Enter the special broken fixing mode if the user specified arguments @@ -694,7 +694,7 @@ struct PkgIsExtraInstalled { bool DoInstall(CommandLine &CmdL) { CacheFile Cache; - std::vector VolatileCmdL; + std::vector VolatileCmdL; Cache.GetSourceList()->AddVolatileFiles(CmdL, &VolatileCmdL); // then open the cache diff --git a/apt-private/private-install.h b/apt-private/private-install.h index 6bb863f61..d2a9bed3f 100644 --- a/apt-private/private-install.h +++ b/apt-private/private-install.h @@ -18,9 +18,9 @@ class pkgProblemResolver; APT_PUBLIC bool DoInstall(CommandLine &Cmd); -bool DoCacheManipulationFromCommandLine(CommandLine &CmdL, std::vector &VolatileCmdL, CacheFile &Cache, +bool DoCacheManipulationFromCommandLine(CommandLine &CmdL, std::vector &VolatileCmdL, CacheFile &Cache, std::map &verset, int UpgradeMode); -bool DoCacheManipulationFromCommandLine(CommandLine &CmdL, std::vector &VolatileCmdL, CacheFile &Cache, int UpgradeMode); +bool DoCacheManipulationFromCommandLine(CommandLine &CmdL, std::vector &VolatileCmdL, CacheFile &Cache, int UpgradeMode); bool DoCacheManipulationFromCommandLine(CommandLine &CmdL, CacheFile &Cache, int UpgradeMode); APT_PUBLIC bool InstallPackages(CacheFile &Cache,bool ShwKept,bool Ask = true, diff --git a/apt-private/private-source.cc b/apt-private/private-source.cc index 220f1bd5a..fab1b4532 100644 --- a/apt-private/private-source.cc +++ b/apt-private/private-source.cc @@ -644,7 +644,7 @@ static void WriteBuildDependencyPackage(std::ostringstream &buildDepsPkgFile, bool DoBuildDep(CommandLine &CmdL) { CacheFile Cache; - std::vector VolatileCmdL; + std::vector VolatileCmdL; Cache.GetSourceList()->AddVolatileFiles(CmdL, &VolatileCmdL); _config->Set("APT::Install-Recommends", false); @@ -702,18 +702,18 @@ bool DoBuildDep(CommandLine &CmdL) { for (size_t i = 0; i < VolatileSources.size(); ++i) { - char const * const Src = VolatileCmdL[i]; + auto const Src = VolatileCmdL[i]; if (DirectoryExists(Src)) - ioprintf(c1out, _("Note, using directory '%s' to get the build dependencies\n"), Src); + ioprintf(c1out, _("Note, using directory '%s' to get the build dependencies\n"), Src.c_str()); else - ioprintf(c1out, _("Note, using file '%s' to get the build dependencies\n"), Src); + ioprintf(c1out, _("Note, using file '%s' to get the build dependencies\n"), Src.c_str()); std::unique_ptr Last(VolatileSources[i]->CreateSrcParser()); if (Last == nullptr) - return _error->Error(_("Unable to find a source package for %s"), Src); + return _error->Error(_("Unable to find a source package for %s"), Src.c_str()); std::string const pseudo = std::string("builddeps:") + Src; WriteBuildDependencyPackage(buildDepsPkgFile, pseudo, pseudoArch, - GetBuildDeps(Last.get(), Src, StripMultiArch, hostArch)); + GetBuildDeps(Last.get(), Src.c_str(), StripMultiArch, hostArch)); pseudoPkgs.emplace_back(pseudo, pseudoArch); } } diff --git a/apt-private/private-upgrade.cc b/apt-private/private-upgrade.cc index 4e0197a3f..679140bfd 100644 --- a/apt-private/private-upgrade.cc +++ b/apt-private/private-upgrade.cc @@ -19,7 +19,7 @@ static bool UpgradeHelper(CommandLine &CmdL, int UpgradeFlags) { CacheFile Cache; - std::vector VolatileCmdL; + std::vector VolatileCmdL; Cache.GetSourceList()->AddVolatileFiles(CmdL, &VolatileCmdL); if (Cache.OpenForInstall() == false || Cache.CheckDeps() == false) -- cgit v1.2.3-70-g09d2