From 4460551841d909d3ee9c1de00156ed3cdf8b1665 Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Tue, 5 Jul 2016 13:07:29 +0200 Subject: avoid 416 response teardown binding to null pointer methods/http.cc:640:13: runtime error: reference binding to null pointer of type 'struct FileFd' This reference is never used in the cases it has a nullptr, so the practical difference is non-existent, but its a bug still. Reported-By: gcc -fsanitize=undefined --- methods/server.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'methods/server.h') diff --git a/methods/server.h b/methods/server.h index 1f90f6bd4..af0914b9c 100644 --- a/methods/server.h +++ b/methods/server.h @@ -97,7 +97,7 @@ struct ServerState virtual bool Close() = 0; virtual bool InitHashes(HashStringList const &ExpectedHashes) = 0; virtual Hashes * GetHashes() = 0; - virtual bool Die(FileFd &File) = 0; + virtual bool Die(FileFd * const File) = 0; virtual bool Flush(FileFd * const File) = 0; virtual bool Go(bool ToFile, FileFd * const File) = 0; -- cgit v1.2.3-70-g09d2