From ba18c4323ecbc66e6a1e3fedae60721f9c5701b1 Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Fri, 4 Jun 2021 14:15:46 +0200 Subject: Do not use filename of local sources in 'apt download' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If a source is not copying files to the destination the download code forces the copy – which in practice are local repositories accessed via file:/ – but in that process takes the filename the local repo used rather than the filename it e.g. advertised via --print-uris. A local repository could hence override a file in the current directory if you use 'apt download', which is a rather weak ability, but still. --- test/integration/framework | 3 +++ test/integration/test-uri-encode-filename-field | 7 +------ 2 files changed, 4 insertions(+), 6 deletions(-) (limited to 'test/integration') diff --git a/test/integration/framework b/test/integration/framework index 412a96577..f14b4da64 100644 --- a/test/integration/framework +++ b/test/integration/framework @@ -1776,6 +1776,9 @@ msgfailoutput() { shift done echo '#### cmp output ####' + elif [ "$1" = 'rm' ]; then + echo "#### Directory listing of: $(pwd) ####" + ls -l fi catfile "$OUTPUT" msgfail "$MSG" diff --git a/test/integration/test-uri-encode-filename-field b/test/integration/test-uri-encode-filename-field index 136cce8d2..dffee21aa 100755 --- a/test/integration/test-uri-encode-filename-field +++ b/test/integration/test-uri-encode-filename-field @@ -25,12 +25,7 @@ runtest() { sed -i -e 's#_0+0~0_#_0%3a0+0~0_#' ../rootdir/var/lib/apt/lists/*Packages testsuccess apt download foo - # FIXME: we shouldn't take filename from file:/ in 'apt download' - if [ "$1" = 'file' ]; then - testsuccess rm 'foo_0%3a0+0~0_all.deb' - else - testsuccess rm 'foo_0+0~0_all.deb' - fi + testsuccess rm 'foo_0+0~0_all.deb' testsuccess apt install foo cd "$TMPWORKINGDIRECTORY" >/dev/null -- cgit v1.2.3-70-g09d2