1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
|
#include <config.h>
#include <apt-pkg/error.h>
#include <apt-pkg/fileutl.h>
#include <apt-pkg/strutl.h>
#include <apt-pkg/aptconfiguration.h>
#include <string>
#include <vector>
#include <stdlib.h>
#include <string.h>
#include <gtest/gtest.h>
#include "file-helpers.h"
static void TestFileFd(mode_t const a_umask, mode_t const ExpectedFilePermission,
unsigned int const filemode, APT::Configuration::Compressor const &compressor)
{
std::string trace;
strprintf(trace, "TestFileFd: Compressor: %s umask: %#o permission: %#o mode: %d", compressor.Name.c_str(), a_umask, ExpectedFilePermission, filemode);
SCOPED_TRACE(trace);
static const char* fname = "apt-filefd-test.txt";
if (FileExists(fname) == true)
EXPECT_EQ(0, unlink(fname));
FileFd f;
umask(a_umask);
EXPECT_TRUE(f.Open(fname, filemode, compressor));
EXPECT_TRUE(f.IsOpen());
EXPECT_FALSE(f.Failed());
EXPECT_EQ(umask(a_umask), a_umask);
std::string test = "This is a test!\n";
EXPECT_TRUE(f.Write(test.c_str(), test.size()));
EXPECT_TRUE(f.IsOpen());
EXPECT_FALSE(f.Failed());
f.Close();
EXPECT_FALSE(f.IsOpen());
EXPECT_FALSE(f.Failed());
EXPECT_TRUE(f.Open(fname, FileFd::ReadOnly, compressor));
EXPECT_TRUE(f.IsOpen());
EXPECT_FALSE(f.Failed());
EXPECT_FALSE(f.Eof());
EXPECT_NE(0, f.FileSize());
EXPECT_FALSE(f.Failed());
EXPECT_NE(0, f.ModificationTime());
EXPECT_FALSE(f.Failed());
// ensure the memory is as predictably messed up
#define APT_INIT_READBACK \
char readback[20]; \
memset(readback, 'D', sizeof(readback)*sizeof(readback[0])); \
readback[19] = '\0';
#define EXPECT_N_STR(expect, actual) \
EXPECT_EQ(0, strncmp(expect, actual, strlen(expect)));
{
APT_INIT_READBACK
char const * const expect = "DDDDDDDDDDDDDDDDDDD";
EXPECT_STREQ(expect,readback);
EXPECT_N_STR(expect, readback);
}
{
APT_INIT_READBACK
char const * const expect = "This";
EXPECT_TRUE(f.Read(readback, strlen(expect)));
EXPECT_FALSE(f.Failed());
EXPECT_FALSE(f.Eof());
EXPECT_N_STR(expect, readback);
EXPECT_EQ(strlen(expect), f.Tell());
}
{
APT_INIT_READBACK
char const * const expect = "test!\n";
EXPECT_TRUE(f.Skip((test.size() - f.Tell()) - strlen(expect)));
EXPECT_TRUE(f.Read(readback, strlen(expect)));
EXPECT_FALSE(f.Failed());
EXPECT_FALSE(f.Eof());
EXPECT_N_STR(expect, readback);
EXPECT_EQ(test.size(), f.Tell());
}
{
APT_INIT_READBACK
EXPECT_TRUE(f.Seek(0));
EXPECT_FALSE(f.Eof());
EXPECT_TRUE(f.Read(readback, 20, true));
EXPECT_FALSE(f.Failed());
EXPECT_TRUE(f.Eof());
EXPECT_N_STR(test.c_str(), readback);
EXPECT_EQ(f.Size(), f.Tell());
}
{
APT_INIT_READBACK
EXPECT_TRUE(f.Seek(0));
EXPECT_FALSE(f.Eof());
EXPECT_TRUE(f.Read(readback, test.size(), true));
EXPECT_FALSE(f.Failed());
EXPECT_FALSE(f.Eof());
EXPECT_N_STR(test.c_str(), readback);
EXPECT_EQ(f.Size(), f.Tell());
}
{
APT_INIT_READBACK
EXPECT_TRUE(f.Seek(0));
EXPECT_FALSE(f.Eof());
unsigned long long actual;
EXPECT_TRUE(f.Read(readback, 20, &actual));
EXPECT_FALSE(f.Failed());
EXPECT_TRUE(f.Eof());
EXPECT_EQ(test.size(), actual);
EXPECT_N_STR(test.c_str(), readback);
EXPECT_EQ(f.Size(), f.Tell());
}
{
APT_INIT_READBACK
EXPECT_TRUE(f.Seek(0));
EXPECT_FALSE(f.Eof());
f.ReadLine(readback, 20);
EXPECT_FALSE(f.Failed());
EXPECT_FALSE(f.Eof());
EXPECT_EQ(test, readback);
EXPECT_EQ(f.Size(), f.Tell());
}
{
APT_INIT_READBACK
EXPECT_TRUE(f.Seek(0));
EXPECT_FALSE(f.Eof());
char const * const expect = "This";
f.ReadLine(readback, strlen(expect) + 1);
EXPECT_FALSE(f.Failed());
EXPECT_FALSE(f.Eof());
EXPECT_N_STR(expect, readback);
EXPECT_EQ(strlen(expect), f.Tell());
}
#undef APT_INIT_READBACK
f.Close();
EXPECT_FALSE(f.IsOpen());
EXPECT_FALSE(f.Failed());
// regression test for permission bug LP: #1304657
struct stat buf;
EXPECT_EQ(0, stat(fname, &buf));
EXPECT_EQ(0, unlink(fname));
EXPECT_EQ(ExpectedFilePermission, buf.st_mode & 0777);
}
static void TestFileFd(unsigned int const filemode)
{
std::vector<APT::Configuration::Compressor> compressors = APT::Configuration::getCompressors();
// testing the (un)compress via pipe, as the 'real' compressors are usually built in via libraries
compressors.push_back(APT::Configuration::Compressor("rev", ".reversed", "rev", NULL, NULL, 42));
//compressors.push_back(APT::Configuration::Compressor("cat", ".ident", "cat", NULL, NULL, 42));
for (std::vector<APT::Configuration::Compressor>::const_iterator c = compressors.begin(); c != compressors.end(); ++c)
{
if ((filemode & FileFd::ReadWrite) == FileFd::ReadWrite &&
(c->Name.empty() != true && c->Binary.empty() != true))
continue;
TestFileFd(0002, 0664, filemode, *c);
TestFileFd(0022, 0644, filemode, *c);
TestFileFd(0077, 0600, filemode, *c);
TestFileFd(0026, 0640, filemode, *c);
}
}
TEST(FileUtlTest, FileFD)
{
std::string const startdir = SafeGetCWD();
EXPECT_FALSE(startdir.empty());
std::string tempdir;
createTemporaryDirectory("filefd", tempdir);
EXPECT_EQ(0, chdir(tempdir.c_str()));
TestFileFd(FileFd::WriteOnly | FileFd::Create);
TestFileFd(FileFd::WriteOnly | FileFd::Create | FileFd::Empty);
TestFileFd(FileFd::WriteOnly | FileFd::Create | FileFd::Exclusive);
TestFileFd(FileFd::WriteOnly | FileFd::Atomic);
TestFileFd(FileFd::WriteOnly | FileFd::Create | FileFd::Atomic);
// short-hands for ReadWrite with these modes
TestFileFd(FileFd::WriteEmpty);
TestFileFd(FileFd::WriteAny);
TestFileFd(FileFd::WriteTemp);
TestFileFd(FileFd::WriteAtomic);
EXPECT_EQ(0, chdir(startdir.c_str()));
removeDirectory(tempdir);
}
TEST(FileUtlTest, Glob)
{
std::vector<std::string> files;
// normal match
files = Glob("*akefile");
EXPECT_EQ(1, files.size());
// not there
files = Glob("xxxyyyzzz");
EXPECT_TRUE(files.empty());
EXPECT_FALSE(_error->PendingError());
// many matches (number is a bit random)
files = Glob("*.cc");
EXPECT_LT(10, files.size());
}
TEST(FileUtlTest, GetTempDir)
{
char const * const envtmp = getenv("TMPDIR");
std::string old_tmpdir;
if (envtmp != NULL)
old_tmpdir = envtmp;
unsetenv("TMPDIR");
EXPECT_EQ("/tmp", GetTempDir());
setenv("TMPDIR", "", 1);
EXPECT_EQ("/tmp", GetTempDir());
setenv("TMPDIR", "/not-there-no-really-not", 1);
EXPECT_EQ("/tmp", GetTempDir());
// here but not accessible for non-roots
setenv("TMPDIR", "/usr", 1);
EXPECT_EQ("/tmp", GetTempDir());
// files are no good for tmpdirs, too
setenv("TMPDIR", "/dev/null", 1);
EXPECT_EQ("/tmp", GetTempDir());
setenv("TMPDIR", "/var/tmp", 1);
EXPECT_EQ("/var/tmp", GetTempDir());
unsetenv("TMPDIR");
if (old_tmpdir.empty() == false)
setenv("TMPDIR", old_tmpdir.c_str(), 1);
}
TEST(FileUtlTest, Popen)
{
FileFd Fd;
pid_t Child;
char buf[1024];
std::string s;
unsigned long long n = 0;
std::vector<std::string> OpenFds;
// count Fds to ensure we don't have a resource leak
if(FileExists("/proc/self/fd"))
OpenFds = Glob("/proc/self/fd/*");
// output something
const char* Args[10] = {"/bin/echo", "meepmeep", NULL};
EXPECT_TRUE(Popen(Args, Fd, Child, FileFd::ReadOnly));
EXPECT_TRUE(Fd.Read(buf, sizeof(buf)-1, &n));
buf[n] = 0;
EXPECT_NE(n, 0);
EXPECT_STREQ(buf, "meepmeep\n");
// wait for the child to exit and cleanup
EXPECT_TRUE(ExecWait(Child, "PopenRead"));
EXPECT_TRUE(Fd.Close());
// ensure that after a close all is good again
if(FileExists("/proc/self/fd"))
EXPECT_EQ(Glob("/proc/self/fd/*").size(), OpenFds.size());
// ReadWrite is not supported
_error->PushToStack();
EXPECT_FALSE(Popen(Args, Fd, Child, FileFd::ReadWrite));
EXPECT_FALSE(Fd.IsOpen());
EXPECT_FALSE(Fd.Failed());
EXPECT_TRUE(_error->PendingError());
_error->RevertToStack();
// write something
Args[0] = "/bin/bash";
Args[1] = "-c";
Args[2] = "read";
Args[3] = NULL;
EXPECT_TRUE(Popen(Args, Fd, Child, FileFd::WriteOnly));
s = "\n";
EXPECT_TRUE(Fd.Write(s.c_str(), s.length()));
EXPECT_TRUE(Fd.Close());
EXPECT_FALSE(Fd.IsOpen());
EXPECT_FALSE(Fd.Failed());
EXPECT_TRUE(ExecWait(Child, "PopenWrite"));
}
TEST(FileUtlTest, flAbsPath)
{
std::string cwd = SafeGetCWD();
int res = chdir("/etc/");
EXPECT_EQ(res, 0);
std::string p = flAbsPath("passwd");
EXPECT_EQ(p, "/etc/passwd");
res = chdir(cwd.c_str());
EXPECT_EQ(res, 0);
}
|
