diff options
author | Julian Andres Klode <julian.klode@canonical.com> | 2020-10-21 11:47:29 +0200 |
---|---|---|
committer | Julian Andres Klode <julian.klode@canonical.com> | 2020-10-21 11:47:29 +0200 |
commit | 998a17d7e6f834c341f198ca5b6df2f27e18df38 (patch) | |
tree | 2944f11ec8860c4dff82fe0a06de6114074b5ad9 /apt-pkg/packagemanager.cc | |
parent | 766b24b7f7484751950c76bc66d3d6cdeaf949a5 (diff) |
Do not produce late error if immediate configuration fails, just warn
We are seeing more and more installations fail due to immediate
configuration issues related to libc6. Immediate configuration is
supposed to ensure that an essential package is configured immediately,
just in case some other packages use a part of the essential package
that only works if that package is configured.
This used to be a warning, it was turned into an error in some commit I
can't remember right now, but importantly, the error missed a return,
which means that ordering completed succesfully and packages were being
installed anyway; and after all that happened successfully, we'd print
an error at the end and exit with an error code, which is not super
useful.
Revert the error back to a warning such that the behavior stays the same
but we do not fail (unless we mess up ordering which then gets caught by
a consistency check later on.
Closes: #953260
Closes: #972552
LP: #1871268
Diffstat (limited to 'apt-pkg/packagemanager.cc')
-rw-r--r-- | apt-pkg/packagemanager.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apt-pkg/packagemanager.cc b/apt-pkg/packagemanager.cc index 515de972c..55880d1b5 100644 --- a/apt-pkg/packagemanager.cc +++ b/apt-pkg/packagemanager.cc @@ -1007,7 +1007,7 @@ bool pkgPackageManager::SmartUnPack(PkgIterator Pkg, bool const Immediate, int c if (Immediate == true) { // Perform immediate configuration of the package. if (SmartConfigure(Pkg, Depth + 1) == false) - _error->Error(_("Could not perform immediate configuration on '%s'. " + _error->Warning(_("Could not perform immediate configuration on '%s'. " "Please see man 5 apt.conf under APT::Immediate-Configure for details. (%d)"),Pkg.FullName().c_str(),2); } |