diff options
| author | David Kalnischkies <david@kalnischkies.de> | 2016-07-05 13:07:29 +0200 |
|---|---|---|
| committer | David Kalnischkies <david@kalnischkies.de> | 2016-07-05 20:44:45 +0200 |
| commit | 4460551841d909d3ee9c1de00156ed3cdf8b1665 (patch) | |
| tree | 9cd879c2463cbb474a816b04008e5345a2a3dd5d /methods/http.h | |
| parent | 60b48d4fc85593c9eabd8bea89fc6a7e6758410d (diff) | |
avoid 416 response teardown binding to null pointer
methods/http.cc:640:13: runtime error: reference binding to null pointer
of type 'struct FileFd'
This reference is never used in the cases it has a nullptr, so the
practical difference is non-existent, but its a bug still.
Reported-By: gcc -fsanitize=undefined
Diffstat (limited to 'methods/http.h')
| -rw-r--r-- | methods/http.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/methods/http.h b/methods/http.h index 5567de715..ac5f52314 100644 --- a/methods/http.h +++ b/methods/http.h @@ -112,7 +112,7 @@ struct HttpServerState: public ServerState virtual bool Close() APT_OVERRIDE; virtual bool InitHashes(HashStringList const &ExpectedHashes) APT_OVERRIDE; virtual Hashes * GetHashes() APT_OVERRIDE; - virtual bool Die(FileFd &File) APT_OVERRIDE; + virtual bool Die(FileFd * const File) APT_OVERRIDE; virtual bool Flush(FileFd * const File) APT_OVERRIDE; virtual bool Go(bool ToFile, FileFd * const File) APT_OVERRIDE; |